Merge pull request #5795 from mvieth/deprecate_crfnormalsegmentation

mvieth · web-flow · commit 11a6627eb0fc · 2023-09-02T14:59:51.000+02:00
Deprecate CrfNormalSegmentation
diff --git a/segmentation/CMakeLists.txt b/segmentation/CMakeLists.txt
@@ -25,7 +25,6 @@ set(srcs
   src/organized_multi_plane_segmentation.cpp
   src/planar_polygon_fusion.cpp
   src/crf_segmentation.cpp
-  src/crf_normal_segmentation.cpp
   src/unary_classifier.cpp
   src/conditional_euclidean_clustering.cpp
   src/supervoxel_clustering.cpp
diff --git a/segmentation/include/pcl/segmentation/crf_normal_segmentation.h b/segmentation/include/pcl/segmentation/crf_normal_segmentation.h
@@ -47,7 +47,7 @@ namespace pcl
    * \author Christian Potthast
    */
   template <typename PointT>
-  class PCL_EXPORTS CrfNormalSegmentation
+  class PCL_DEPRECATED(1, 17, "CrfNormalSegmentation is not implemented and does not do anything useful") CrfNormalSegmentation
   {
     public:
       /** \brief Constructor that sets default values for member variables. */
@@ -71,6 +71,4 @@ namespace pcl
   };
 }
 
-#ifdef PCL_NO_PRECOMPILE
 #include <pcl/segmentation/impl/crf_normal_segmentation.hpp>
-#endif
diff --git a/segmentation/src/crf_normal_segmentation.cpp b/segmentation/src/crf_normal_segmentation.cpp

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ namespace pcl`
`47`	`47`	`* \author Christian Potthast`
`48`	`48`	`*/`
`49`	`49`	`template <typename PointT>`
`50`		`- class PCL_EXPORTS CrfNormalSegmentation`
	`50`	`+ class PCL_DEPRECATED(1, 17, "CrfNormalSegmentation is not implemented and does not do anything useful") CrfNormalSegmentation`
`51`	`51`	`{`
`52`	`52`	`public:`
`53`	`53`	`/** \brief Constructor that sets default values for member variables. */`
`@@ -71,6 +71,4 @@ namespace pcl`
`71`	`71`	`};`
`72`	`72`	`}`
`73`	`73`
`74`		`-#ifdef PCL_NO_PRECOMPILE`
`75`	`74`	`#include <pcl/segmentation/impl/crf_normal_segmentation.hpp>`
`76`		`-#endif`