Add check for whitespace when parsing TreeNodesModel

Author: dsobek

src/xml_parsing.cpp

@@ -10,14 +10,18 @@
 *   WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */
 
+#include <algorithm>
+#include <cctype>
 #include <cstdio>
 #include <cstring>
 #include <functional>
 #include <iostream>
 #include <list>
 #include <sstream>
 #include <string>
+#include <string_view>
 #include <typeindex>
+
 #include "behaviortree_cpp/basic_types.h"
 #include "behaviortree_cpp/utils/strcat.hpp"
 
@@ -214,6 +218,13 @@ void BT::XMLParser::PImpl::loadSubtreeModel(const XMLElement* xml_root)
           {
             throw RuntimeError("Missing attribute [name] in port (SubTree model)");
           }
+          std::string_view sname(name);
+          if(std::any_of(sname.begin(), sname.end(),
+                         [](unsigned char c) { return std::isspace(c); }))
+          {
+            throw RuntimeError(
+                StrCat("The name of a port must not contain whitespace: '", sname, "'"));
+          }
           if(auto default_value = port_node->Attribute("default"))
           {
             port.setDefaultValue(default_value);

tests/gtest_subtree.cpp

@@ -620,6 +620,48 @@ TEST(SubTree, SubtreeModels)
   tree.tickWhileRunning();
 }
 
+TEST(SubTree, WhitespaceInSubtreeModel)
+{
+  // clang-format off
+
+  static const char* xml_text = R"(
+<root main_tree_to_execute = "MainTree" BTCPP_format="4">
+  <TreeNodesModel>
+    <SubTree ID="MySub">
+      <input_port name="port with space" default="42"/>
+    </SubTree>
+  </TreeNodesModel>
+
+  <BehaviorTree ID="MainTree">
+    <Sequence>
+      <SubTree ID="MySub" />
+    </Sequence>
+  </BehaviorTree>
+
+  <BehaviorTree ID="MySub">
+    <Sequence>
+      <AlwaysSuccess />
+    </Sequence>
+  </BehaviorTree>
+</root>
+ )";
+
+  // clang-format on
+
+  BehaviorTreeFactory factory;
+  try
+  {
+    auto _ = factory.createTreeFromText(xml_text);
+  }
+  catch(RuntimeError e)
+  {
+    EXPECT_NE(std::string_view(e.what()).find("not contain whitespace"),
+              std::string_view::npos);
+    return;
+  }
+  FAIL() << "Exception was not thrown.";
+}
+
 class PrintToConsole : public BT::SyncActionNode
 {
 public: