Skip to content

warnings.md

Latest commit

 

History

History
59 lines (44 loc) · 2.63 KB

warnings.md

File metadata and controls

59 lines (44 loc) · 2.63 KB

Maven Build Warnings Analysis

Priority 1: Critical Build Configuration Issues

1.1 Empty JAR Warning

Module: approvaltests-util-tests
Warning: JAR will be empty - no content was marked for inclusion!
Impact: Creates empty artifact, may break downstream dependencies
Fix: Either add source files or configure the module as test-only

Priority 2: Compilation Warnings

2.1 Java Module System Path Not Set

Warning: system modules path not set in conjunction with -source 15
Impact: May cause issues with Java module system compatibility
Fix: Update Maven compiler plugin configuration to properly handle Java modules

2.2 Varargs Method Call Warning

Location: approvaltests-tests/src/test/java/org/approvaltests/combinations/PairWiseTest.java:124
Warning: non-varargs call of varargs method with inexact argument type for last parameter
Impact: Type safety warning, potential runtime issues
Fix: Cast to Object[] for varargs call or Object[][] for non-varargs call

Priority 3: Test Discovery Issues

3.1 JUnit Jupiter Test Discovery Warning

Warning: TestEngine with ID 'junit-jupiter' encountered a non-critical issue during test discovery
Details: Inner class LoadersAndSaversExamplesTest$Step3a not executable (must be static or @Nested)
Impact: Test class won't be executed
Fix: Make the inner class static or annotate with @Nested

Priority 4: Logging Configuration

4.1 SLF4J Logger Implementation Missing

Warning: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder"
Impact: Logging defaults to no-operation implementation
Fix: Add SLF4J implementation dependency (e.g., logback-classic or slf4j-simple)

Summary Statistics

  • Total Warnings: 6 unique warning types
  • Critical (Priority 1): 1 warning - Build configuration issue
  • High (Priority 2): 2 warnings - Compilation warnings
  • Medium (Priority 3): 1 warning - Test discovery issue
  • Low (Priority 4): 1 warning - Logging configuration

Skipped Tests Summary

Multiple tests are being skipped across different modules:

  • Machine-specific tests: 8 tests skipped (requires machine configuration)
  • Platform-specific tests: Several tests skipped on non-matching platforms
  • Total skipped tests across all modules: ~20 tests

Recommendations

  1. Immediate Action Required: Fix empty JAR warning in approvaltests-util-tests module
  2. Short Term: Address compilation warnings and empty JAR issue
  3. Medium Term: Configure SLF4J logging implementation
  4. Optional: Review skipped tests to ensure they're intentionally excluded