Remove useless parameter javadoc, replace some overly terse names

Author: coderbot16

patchwork-networking/src/main/java/com/patchworkmc/mixin/networking/handler/MixinClientLoginNetworkHandler.java

@@ -37,7 +37,7 @@ public abstract class MixinClientLoginNetworkHandler {
 	public abstract ClientConnection getConnection();
 
 	@Inject(method = "onQueryRequest", at = @At("HEAD"), cancellable = true)
-	private void patchwork$hookCustomPayload(LoginQueryRequestS2CPacket packet, CallbackInfo callback) {
+	private void patchwork$hookQueryRequest(LoginQueryRequestS2CPacket packet, CallbackInfo callback) {
 		if (NetworkHooks.onCustomPayload((ICustomPacket<?>) packet, getConnection())) {
 			callback.cancel();
 		}

patchwork-networking/src/main/java/com/patchworkmc/mixin/networking/handler/MixinServerLoginNetworkHandler.java

@@ -37,7 +37,7 @@ public abstract class MixinServerLoginNetworkHandler {
 	public abstract ClientConnection getConnection();
 
 	@Inject(method = "onQueryResponse", at = @At("HEAD"), cancellable = true)
-	private void patchwork$hookCustomPayload(LoginQueryResponseC2SPacket packet, CallbackInfo callback) {
+	private void patchwork$hookQueryResponse(LoginQueryResponseC2SPacket packet, CallbackInfo callback) {
 		if (NetworkHooks.onCustomPayload((ICustomPacket<?>) packet, getConnection())) {
 			callback.cancel();
 		}

patchwork-networking/src/main/java/net/minecraftforge/fml/network/PacketDistributor.java

@@ -128,6 +128,7 @@ public PacketTarget noArg() {
 		return new PacketTarget(functor.apply(this, () -> null), this);
 	}
 
+	// TODO: Fix Checkstyle on lambda returns
 	// CHECKSTYLE.OFF: Indentation - lambda returns are broken
 	private Consumer<Packet<?>> playerConsumer(final Supplier<ServerPlayerEntity> player) {
 		return packet -> player.get().networkHandler.client.send(packet);
@@ -145,10 +146,10 @@ private Consumer<Packet<?>> clientToServer(final Supplier<Void> ignored) {
 		return packet -> MinecraftClient.getInstance().getNetworkHandler().sendPacket(packet);
 	}
 
-	private Consumer<Packet<?>> playerListPointConsumer(final Supplier<TargetPoint> point) {
+	private Consumer<Packet<?>> playerListPointConsumer(final Supplier<TargetPoint> pointSupplier) {
 		return packet -> {
-			final TargetPoint tp = point.get();
-			getServer().getPlayerManager().sendToAround(tp.excluded, tp.x, tp.y, tp.z, tp.r2, tp.dim, packet);
+			final TargetPoint point = pointSupplier.get();
+			getServer().getPlayerManager().sendToAround(point.excluded, point.x, point.y, point.z, point.radius, point.dim, packet);
 		};
 	}
 
@@ -188,65 +189,46 @@ public static final class TargetPoint {
 		private final double x;
 		private final double y;
 		private final double z;
-		private final double r2;
+		private final double radius;
 		private final DimensionType dim;
 
 		/**
-		 * A target point with excluded entity.
-		 *
-		 * @param excluded the {@link ServerPlayerEntity} to exclude
-		 * @param x X
-		 * @param y Y
-		 * @param z Z
-		 * @param r2 Radius
-		 * @param dim DimensionType
+		 * A target point that excludes the provided player entity.
 		 */
-		public TargetPoint(final ServerPlayerEntity excluded, final double x, final double y, final double z, final double r2, final DimensionType dim) {
+		public TargetPoint(final ServerPlayerEntity excluded, final double x, final double y, final double z, final double radius, final DimensionType dim) {
 			this.excluded = excluded;
 			this.x = x;
 			this.y = y;
 			this.z = z;
-			this.r2 = r2;
+			this.radius = radius;
 			this.dim = dim;
 		}
 
 		/**
 		 * A target point that does not exclude any entities.
-		 * @param x X
-		 * @param y Y
-		 * @param z Z
-		 * @param r2 Radius
-		 * @param dim DimensionType
 		 */
-		public TargetPoint(final double x, final double y, final double z, final double r2, final DimensionType dim) {
+		public TargetPoint(final double x, final double y, final double z, final double radius, final DimensionType dim) {
 			this.excluded = null;
 			this.x = x;
 			this.y = y;
 			this.z = z;
-			this.r2 = r2;
+			this.radius = radius;
 			this.dim = dim;
 		}
 
 		/**
 		 * Helper to build a target point that does not exclude any entities.
-		 * @param x X
-		 * @param y Y
-		 * @param z Z
-		 * @param r2 Radius
-		 * @param dim DimensionType
-		 * @return A TargetPoint supplier
 		 */
-		public static Supplier<TargetPoint> p(double x, double y, double z, double r2, DimensionType dim) {
-			TargetPoint tp = new TargetPoint(x, y, z, r2, dim);
-			return () -> tp;
+		public static Supplier<TargetPoint> p(double x, double y, double z, double radius, DimensionType dim) {
+			TargetPoint point = new TargetPoint(x, y, z, radius, dim);
+			return () -> point;
 		}
 	}
 
 	/**
-	 * A Distributor curried with a specific value instance, for actual dispatch.
+	 * A {@link PacketDistributor} curried with a specific value instance. Can be used for packet dispatch.
 	 *
 	 * @see net.minecraftforge.fml.network.simple.SimpleChannel#send(PacketTarget, Object)
-	 *
 	 */
 	public static class PacketTarget {
 		private final Consumer<Packet<?>> packetConsumer;

patchwork-networking/src/main/java/net/minecraftforge/fml/network/simple/IndexedMessageCodec.java

@@ -81,18 +81,17 @@ private static <M> int tryEncode(PacketByteBuf target, M message, MessageHandler
 	}
 
 	@SuppressWarnings("unchecked")
-	public <M> MessageHandler<M> findMessageType(final M msgToReply) {
-		return (MessageHandler<M>) types.get(msgToReply.getClass());
+	public <M> MessageHandler<M> findMessageType(final M message) {
+		return (MessageHandler<M>) types.get(message.getClass());
 	}
 
 	@SuppressWarnings("unchecked")
-	<M> MessageHandler<M> findIndex(final short i) {
-		return (MessageHandler<M>) indices.get(i);
+	<M> MessageHandler<M> findIndex(final short index) {
+		return (MessageHandler<M>) indices.get(index);
 	}
 
 	public <M> int build(M message, PacketByteBuf target) {
-		@SuppressWarnings("unchecked")
-		MessageHandler<M> codec = (MessageHandler<M>) types.get(message.getClass());
+		MessageHandler<M> codec = findMessageType(message);
 
 		if (codec == null) {
 			LOGGER.error(SIMPLENET, "Received invalid message {} on channel {}", message.getClass().getName(), channelName);

patchwork-networking/src/main/java/net/minecraftforge/fml/network/simple/SimpleChannel.java

@@ -83,9 +83,9 @@ public <M> IndexedMessageCodec.MessageHandler<M> registerMessage(int index, Clas
 		return this.indexedCodec.addCodecIndex(index, messageType, encoder, decoder, messageConsumer);
 	}
 
-	private <M> Pair<PacketByteBuf, Integer> toBuffer(M msg) {
+	private <M> Pair<PacketByteBuf, Integer> toBuffer(M message) {
 		final PacketByteBuf bufIn = new PacketByteBuf(Unpooled.buffer());
-		int index = encodeMessage(msg, bufIn);
+		int index = encodeMessage(message, bufIn);
 		return Pair.of(bufIn, index);
 	}
 
@@ -194,9 +194,9 @@ public MessageBuilder<M> consumer(BiConsumer<M, Supplier<NetworkEvent.Context>>
 		 * @return this
 		 */
 		public MessageBuilder<M> consumer(ToBooleanBiFunction<M, Supplier<NetworkEvent.Context>> handler) {
-			this.consumer = (msg, ctx) -> {
-				boolean handled = handler.applyAsBool(msg, ctx);
-				ctx.get().setPacketHandled(handled);
+			this.consumer = (message, context) -> {
+				boolean handled = handler.applyAsBool(message, context);
+				context.get().setPacketHandled(handled);
 			};
 			return this;
 		}