Mark off the unsupported parts of the API, make them fail hard

Author: coderbot16

patchwork-networking/src/main/java/net/minecraftforge/fml/network/NetworkDirection.java

@@ -99,10 +99,10 @@ private <T extends Packet<?>> ICustomPacket<T> construct() {
 			return (ICustomPacket<T>) CustomPayloadS2CPacketAccessor.patchwork$create();
 		case LOGIN_TO_SERVER:
 			throw new UnsupportedOperationException("login packets are not supported");
-			// return (ICustomPacket<T>) LoginQueryResponseC2SPacketAccessor.patchwork$create();
+			// TODO: return (ICustomPacket<T>) LoginQueryResponseC2SPacketAccessor.patchwork$create();
 		case LOGIN_TO_CLIENT:
 			throw new UnsupportedOperationException("login packets are not supported");
-			// return (ICustomPacket<T>) LoginQueryRequestS2CPacketAccessor.patchwork$create();
+			// TODO: return (ICustomPacket<T>) LoginQueryRequestS2CPacketAccessor.patchwork$create();
 		default:
 			throw new IllegalStateException("Unexpected NetworkDirection " + this + ", someone's been tampering with enums!");
 		}

patchwork-networking/src/main/java/net/minecraftforge/fml/network/event/EventNetworkChannel.java

@@ -39,6 +39,9 @@ public EventNetworkChannel(ListenableChannel channel) {
 		channel.setPacketListener(this::packetListener);
 		channel.setRegistrationChangeListener(networkEventBus::post);
 		channel.setGatherLoginPayloadsListener(networkEventBus::post);
+
+		// TODO: Login packet stuff, registration change listeners
+		throw new UnsupportedOperationException("Registration change / gather login payload events aren't supported");
 	}
 
 	private void handleError(IEventBus bus, Event event, IEventListener[] listeners, int i, Throwable throwable) {

patchwork-networking/src/main/java/net/minecraftforge/fml/network/simple/SimpleChannel.java

@@ -217,6 +217,9 @@ public void add() {
 
 			if (this.loginPacketGenerators != null) {
 				this.channel.loginPackets.add((Function<Boolean, List<Pair<String, ?>>>) (Object) this.loginPacketGenerators);
+
+				// TODO: Login packet stuff
+				throw new UnsupportedOperationException("Login packet generators are unsupported");
 			}
 		}
 

patchwork-networking/src/main/resources/patchwork-networking.accessor.mixins.json

@@ -6,8 +6,8 @@
     "ClientConnectionAccessor",
     "CustomPayloadC2SPacketAccessor",
     "CustomPayloadS2CPacketAccessor",
-//    "LoginQueryRequestS2CPacketAccessor",
-//    "LoginQueryResponseC2SPacketAccessor",
+    "LoginQueryRequestS2CPacketAccessor",
+    "LoginQueryResponseC2SPacketAccessor",
     "ThreadExecutorAccessor"
   ],
   "injectors": {

patchwork-networking/src/main/resources/patchwork-networking.packet.mixins.json

@@ -5,8 +5,8 @@
   "mixins": [
     "MixinCustomPayloadC2SPacket",
     "MixinCustomPayloadS2CPacket",
-//    "MixinLoginQueryRequestS2CPacket",
-//    "MixinLoginQueryResponseC2SPacket"
+    "MixinLoginQueryRequestS2CPacket",
+    "MixinLoginQueryResponseC2SPacket"
   ],
   "injectors": {
     "defaultRequire": 1