Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Commit b2e0406

Browse files
committed
Reviews pt. 3
1 parent b6f8652 commit b2e0406

1 file changed

Lines changed: 12 additions & 14 deletions

File tree

patchwork-fml/src/main/java/net/minecraftforge/fml/common/ObfuscationReflectionHelper.java

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,16 @@ public static String remapName(INameMappingService.Domain domain, String name) {
7171
return name;
7272
}
7373

74+
if (domain == INameMappingService.Domain.CLASS) {
75+
return MAPPINGS.getDefaultNamespaceClassMap().get(name).getName(NAMED);
76+
}
77+
7478
for (ClassDef classDef : MAPPINGS.getClasses()) {
75-
if (domain == INameMappingService.Domain.CLASS) {
76-
if (classDef.getName(INTERMEDIARY).equals(name)) {
77-
return classDef.getName(NAMED);
78-
}
79-
} else {
80-
boolean domainIsMethod = domain == INameMappingService.Domain.METHOD;
79+
boolean domainIsMethod = domain == INameMappingService.Domain.METHOD;
8180

82-
for (Mapped mapped : domainIsMethod ? classDef.getMethods() : classDef.getFields()) {
83-
if (mapped.getName(INTERMEDIARY).equals(name)) {
84-
return mapped.getName(NAMED);
85-
}
81+
for (Mapped mapped : domainIsMethod ? classDef.getMethods() : classDef.getFields()) {
82+
if (mapped.getName(INTERMEDIARY).equals(name)) {
83+
return mapped.getName(NAMED);
8684
}
8785
}
8886
}
@@ -99,14 +97,14 @@ public static String remapName(INameMappingService.Domain domain, String name) {
9997
* @return The remapped name, or the original name if it couldn't be remapped.
10098
*/
10199
public static String remapNameFast(INameMappingService.Domain domain, Class<?> clazz, String name) {
102-
if (domain == INameMappingService.Domain.CLASS) {
103-
remapName(domain, name);
104-
}
105-
106100
if (FabricLoader.getInstance().getMappingResolver().getCurrentRuntimeNamespace().equals(INTERMEDIARY)) {
107101
return name;
108102
}
109103

104+
if (domain == INameMappingService.Domain.CLASS) {
105+
remapName(domain, name);
106+
}
107+
110108
ClassDef classDef = MAPPINGS.getDefaultNamespaceClassMap().get(clazz.getName());
111109
boolean domainIsMethod = domain == INameMappingService.Domain.METHOD;
112110

0 commit comments

Comments
 (0)