From ed01ecab3c77abb88c4a87bce3973fb37b76cc92 Mon Sep 17 00:00:00 2001 From: "robocop-the-helper[bot]" <320614534+robocop-the-helper[bot]@users.noreply.github.com> Date: Wed, 11 Nov 2026 18:51:44 +0000 Subject: [PATCH] Fix decode-uri-component DoS in Gatsby example (CVE-2026-118664) gatsby@5.16.1 pins query-string@^6.14.1, which pulls in decode-uri-component@0.2.2 (GHSA-qr28-fpjm-wq7f, GHSA-vcc3-ghjq-m6fr). No gatsby release ships a fixed query-string. Override query-string to ^9.5.1, which depends on decode-uri-component ^0.5.0, and floor decode-uri-component at ^0.5.1. Overriding only decode-uri-component is not enough: 0.5.x is ESM-only, so the CommonJS query-string 6.x gets a namespace object and throws "decodeComponent is not a function". Gatsby's only consumer is the develop-only dev 404 page, which webpack bundles via a default import that query-string 9 provides. Co-Authored-By: Claude Opus 5.5 --- examples/gatsbyjs/package-lock.json | 54 +++++++++++++---------------- examples/gatsbyjs/package.json | 4 ++- 2 files changed, 28 insertions(+), 30 deletions(-) diff --git a/examples/gatsbyjs/package-lock.json b/examples/gatsbyjs/package-lock.json index f3bfcd0..4b740fd 100644 --- a/examples/gatsbyjs/package-lock.json +++ b/examples/gatsbyjs/package-lock.json @@ -10463,12 +10463,12 @@ } }, "node_modules/decode-uri-component": { - "version": "0.2.2", - "resolved": "https://registry.npmjs.org/decode-uri-component/-/decode-uri-component-0.2.2.tgz", - "integrity": "sha512-FqUYQ+8o158GyGTrMFJms9qh3CqTKvAqgqsTnkLI8sKu0028orqBhxNMFkFen0zGyg6epACD32pjVk58ngIErQ==", + "version": "0.5.1", + "resolved": "https://registry.npmjs.org/decode-uri-component/-/decode-uri-component-0.5.1.tgz", + "integrity": "sha512-vWHQkXgg2cE3BB4rR0c+PYw9BCQzLoNIRMI7AunIkZst74tw/vpPp7VLoYtsR/cy1f55g3XDWUslfeCZjiZJyA==", "license": "MIT", "engines": { - "node": ">=0.10" + "node": ">=14.16" } }, "node_modules/decompress-response": { @@ -12329,12 +12329,15 @@ } }, "node_modules/filter-obj": { - "version": "1.1.0", - "resolved": "https://registry.npmjs.org/filter-obj/-/filter-obj-1.1.0.tgz", - "integrity": "sha512-8rXg1ZnX7xzy2NGDVkBVaAy+lSlPNwad13BtgSlLuxfIslyt5Vg64U7tFcCt4WS1R0hvtnQybT/IyCkGZ3DpXQ==", + "version": "5.1.0", + "resolved": "https://registry.npmjs.org/filter-obj/-/filter-obj-5.1.0.tgz", + "integrity": "sha512-qWeTREPoT7I0bifpPUXtxkZJ1XJzxWtfoWWkdVGqa+eCr3SHW/Ocp89o8vLvbUuQnadybJpjOKu4V+RwO6sGng==", "license": "MIT", "engines": { - "node": ">=0.10.0" + "node": ">=14.16" + }, + "funding": { + "url": "https://github.com/sponsors/sindresorhus" } }, "node_modules/finalhandler": { @@ -17560,18 +17563,17 @@ } }, "node_modules/query-string": { - "version": "6.14.1", - "resolved": "https://registry.npmjs.org/query-string/-/query-string-6.14.1.tgz", - "integrity": "sha512-XDxAeVmpfu1/6IjyT/gXHOl+S0vQ9owggJ30hhWKdHAsNPOcasn5o9BW0eejZqL2e4vMjhAxoW3jVHcD6mbcYw==", + "version": "9.5.1", + "resolved": "https://registry.npmjs.org/query-string/-/query-string-9.5.1.tgz", + "integrity": "sha512-/zO3RwuRCMTIcEgq6YMv4OrtEE1XzBG7w5N6zc6ydYnkWYOWsnLI/5894hYEzfESfMOT4cHCsRTIdxsSl1KjGg==", "license": "MIT", "dependencies": { - "decode-uri-component": "^0.2.0", - "filter-obj": "^1.1.0", - "split-on-first": "^1.0.0", - "strict-uri-encode": "^2.0.0" + "decode-uri-component": "^0.5.0", + "filter-obj": "^5.1.0", + "split-on-first": "^3.0.0" }, "engines": { - "node": ">=6" + "node": ">=18" }, "funding": { "url": "https://github.com/sponsors/sindresorhus" @@ -19060,12 +19062,15 @@ } }, "node_modules/split-on-first": { - "version": "1.1.0", - "resolved": "https://registry.npmjs.org/split-on-first/-/split-on-first-1.1.0.tgz", - "integrity": "sha512-43ZssAJaMusuKWL8sKUBQXHWOpq8d6CfN/u1p4gUzfJkM05C8rxTmYrkIPTXapZpORA6LkkzcUulJ8FqA7Uudw==", + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/split-on-first/-/split-on-first-3.0.0.tgz", + "integrity": "sha512-qxQJTx2ryR0Dw0ITYyekNQWpz6f8dGd7vffGNflQQ3Iqj9NJ6qiZ7ELpZsJ/QBhIVAiDfXdag3+Gp8RvWa62AA==", "license": "MIT", "engines": { - "node": ">=6" + "node": ">=12" + }, + "funding": { + "url": "https://github.com/sponsors/sindresorhus" } }, "node_modules/sponge-case": { @@ -19135,15 +19140,6 @@ "node": ">=10.0.0" } }, - "node_modules/strict-uri-encode": { - "version": "2.0.0", - "resolved": "https://registry.npmjs.org/strict-uri-encode/-/strict-uri-encode-2.0.0.tgz", - "integrity": "sha512-QwiXZgpRcKkhTj2Scnn++4PKtWsH0kpzZ62L2R6c/LUVYv7hVnZqcg2+sMuT6R7Jusu1vviK/MFsu6kNJfWlEQ==", - "license": "MIT", - "engines": { - "node": ">=4" - } - }, "node_modules/string_decoder": { "version": "1.3.0", "resolved": "https://registry.npmjs.org/string_decoder/-/string_decoder-1.3.0.tgz", diff --git a/examples/gatsbyjs/package.json b/examples/gatsbyjs/package.json index eafed3b..0facbde 100644 --- a/examples/gatsbyjs/package.json +++ b/examples/gatsbyjs/package.json @@ -56,6 +56,8 @@ "@graphql-tools/schema": { ".": "10.0.31", "@graphql-tools/merge": "9.1.7" - } + }, + "query-string": "^9.5.1", + "decode-uri-component": "^0.5.1" } }