From 0b0f8e3f0f9ed7fb301bbbad906e0763cbce0d65 Mon Sep 17 00:00:00 2001 From: MahmoudElsayad Date: Fri, 6 Nov 2026 00:31:13 +0200 Subject: [PATCH 1/3] fix(electron): update examples to patched supported Electron --- examples/electron-nodeintegration/.npmrc | 2 ++ examples/electron-nodeintegration/README.md | 4 +++- .../electron-nodeintegration/package-lock.json | 16 ++++++++++------ examples/electron-nodeintegration/package.json | 6 +++++- examples/electron/.npmrc | 2 ++ examples/electron/README.md | 4 +++- examples/electron/package-lock.json | 16 ++++++++++------ examples/electron/package.json | 6 +++++- 8 files changed, 40 insertions(+), 16 deletions(-) create mode 100644 examples/electron-nodeintegration/.npmrc create mode 100644 examples/electron/.npmrc diff --git a/examples/electron-nodeintegration/.npmrc b/examples/electron-nodeintegration/.npmrc new file mode 100644 index 00000000..a886a41e --- /dev/null +++ b/examples/electron-nodeintegration/.npmrc @@ -0,0 +1,2 @@ +min-release-age=7 +engine-strict=true diff --git a/examples/electron-nodeintegration/README.md b/examples/electron-nodeintegration/README.md index c330df24..e4db2a86 100644 --- a/examples/electron-nodeintegration/README.md +++ b/examples/electron-nodeintegration/README.md @@ -7,7 +7,9 @@ This example uses node integration. If you're looking for an example with contex ## Prerequisites -- [Node.js](http://nodejs.org/) +- [Node.js](http://nodejs.org/) 22.12.0 or later and npm 11.21.1 or later. + +The `.npmrc` configuration excludes dependency releases younger than seven days when npm resolves new versions. ## Support and Issues diff --git a/examples/electron-nodeintegration/package-lock.json b/examples/electron-nodeintegration/package-lock.json index da716997..595f78d3 100644 --- a/examples/electron-nodeintegration/package-lock.json +++ b/examples/electron-nodeintegration/package-lock.json @@ -13,7 +13,11 @@ "devDependencies": { "@electron/packager": "20.3.0", "@electron/remote": "^2.1.3", - "electron": "^41.2.0" + "electron": "^43.8.4" + }, + "engines": { + "node": ">=22.12.0", + "npm": ">=11.21.1" } }, "node_modules/@electron-internal/extract-zip": { @@ -325,11 +329,10 @@ } }, "node_modules/electron": { - "version": "41.10.7", - "resolved": "https://registry.npmjs.org/electron/-/electron-41.10.7.tgz", - "integrity": "sha512-AqIiefddlf5i+HYCGatr8VlBuEbWJpad4/yloBFYcMB2r57j7xhW1ogiJ+BfA5kxQyfmSs5yjwy54Me+wJn1jw==", + "version": "43.8.4", + "resolved": "https://registry.npmjs.org/electron/-/electron-43.8.4.tgz", + "integrity": "sha512-Vt1SigFO1Oe5ZX5aJYtkAtGaB4XZFipr9l565/ghd4IA/FYJCnRbp5I2PhKqPKoDJESXBitaK6NMBkl+bTGy6Q==", "dev": true, - "hasInstallScript": true, "license": "MIT", "dependencies": { "@electron-internal/extract-zip": "^1.0.1", @@ -337,7 +340,8 @@ "@types/node": "^24.9.0" }, "bin": { - "electron": "cli.js" + "electron": "cli.js", + "install-electron": "install.js" }, "engines": { "node": ">= 22.12.0" diff --git a/examples/electron-nodeintegration/package.json b/examples/electron-nodeintegration/package.json index 481a3b0d..fa7f8824 100644 --- a/examples/electron-nodeintegration/package.json +++ b/examples/electron-nodeintegration/package.json @@ -26,9 +26,13 @@ "devDependencies": { "@electron/packager": "20.3.0", "@electron/remote": "^2.1.3", - "electron": "^41.2.0" + "electron": "^43.8.4" }, "dependencies": { "@nutrient-sdk/viewer": "1.25.0" + }, + "engines": { + "node": ">=22.12.0", + "npm": ">=11.21.1" } } diff --git a/examples/electron/.npmrc b/examples/electron/.npmrc new file mode 100644 index 00000000..a886a41e --- /dev/null +++ b/examples/electron/.npmrc @@ -0,0 +1,2 @@ +min-release-age=7 +engine-strict=true diff --git a/examples/electron/README.md b/examples/electron/README.md index fcc5ed1c..bd2996fd 100644 --- a/examples/electron/README.md +++ b/examples/electron/README.md @@ -7,7 +7,9 @@ This example uses context isolation, with node integration disabled. If you're l ## Prerequisites -- [Node.js](http://nodejs.org/) +- [Node.js](http://nodejs.org/) 22.12.0 or later and npm 11.21.1 or later. + +The `.npmrc` configuration excludes dependency releases younger than seven days when npm resolves new versions. ## Usage with a license key diff --git a/examples/electron/package-lock.json b/examples/electron/package-lock.json index 8c119542..9392ed59 100644 --- a/examples/electron/package-lock.json +++ b/examples/electron/package-lock.json @@ -12,7 +12,11 @@ }, "devDependencies": { "@electron/packager": "20.3.0", - "electron": "^41.2.0" + "electron": "^43.8.4" + }, + "engines": { + "node": ">=22.12.0", + "npm": ">=11.21.1" } }, "node_modules/@electron-internal/extract-zip": { @@ -314,11 +318,10 @@ } }, "node_modules/electron": { - "version": "41.10.7", - "resolved": "https://registry.npmjs.org/electron/-/electron-41.10.7.tgz", - "integrity": "sha512-AqIiefddlf5i+HYCGatr8VlBuEbWJpad4/yloBFYcMB2r57j7xhW1ogiJ+BfA5kxQyfmSs5yjwy54Me+wJn1jw==", + "version": "43.8.4", + "resolved": "https://registry.npmjs.org/electron/-/electron-43.8.4.tgz", + "integrity": "sha512-Vt1SigFO1Oe5ZX5aJYtkAtGaB4XZFipr9l565/ghd4IA/FYJCnRbp5I2PhKqPKoDJESXBitaK6NMBkl+bTGy6Q==", "dev": true, - "hasInstallScript": true, "license": "MIT", "dependencies": { "@electron-internal/extract-zip": "^1.0.1", @@ -326,7 +329,8 @@ "@types/node": "^24.9.0" }, "bin": { - "electron": "cli.js" + "electron": "cli.js", + "install-electron": "install.js" }, "engines": { "node": ">= 22.12.0" diff --git a/examples/electron/package.json b/examples/electron/package.json index 034146e7..43a99c98 100644 --- a/examples/electron/package.json +++ b/examples/electron/package.json @@ -25,9 +25,13 @@ ], "devDependencies": { "@electron/packager": "20.3.0", - "electron": "^41.2.0" + "electron": "^43.8.4" }, "dependencies": { "@nutrient-sdk/viewer": "1.25.0" + }, + "engines": { + "node": ">=22.12.0", + "npm": ">=11.21.1" } } From 2a94bd3c94b1439e8ac2c50caea2cdb8c73a240e Mon Sep 17 00:00:00 2001 From: MahmoudElsayad Date: Mon, 9 Nov 2026 16:44:06 +0200 Subject: [PATCH 2/3] fix(electron): require npm 11.10.0, the first release that enforces min-release-age npm 11.21.1 is newer than the npm that Node 24 LTS bundles (11.19.1), so the Playwright workflow failed with EBADENGINE while installing the Electron examples. npm 11.10.0 is the first release that withholds versions younger than min-release-age, so the cooldown still holds wherever the install succeeds. --- examples/electron-nodeintegration/README.md | 2 +- examples/electron-nodeintegration/package-lock.json | 2 +- examples/electron-nodeintegration/package.json | 2 +- examples/electron/README.md | 2 +- examples/electron/package-lock.json | 2 +- examples/electron/package.json | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/electron-nodeintegration/README.md b/examples/electron-nodeintegration/README.md index e4db2a86..f37f50ea 100644 --- a/examples/electron-nodeintegration/README.md +++ b/examples/electron-nodeintegration/README.md @@ -7,7 +7,7 @@ This example uses node integration. If you're looking for an example with contex ## Prerequisites -- [Node.js](http://nodejs.org/) 22.12.0 or later and npm 11.21.1 or later. +- [Node.js](http://nodejs.org/) 22.12.0 or later and npm 11.10.0 or later. The `.npmrc` configuration excludes dependency releases younger than seven days when npm resolves new versions. diff --git a/examples/electron-nodeintegration/package-lock.json b/examples/electron-nodeintegration/package-lock.json index 595f78d3..296a9fe0 100644 --- a/examples/electron-nodeintegration/package-lock.json +++ b/examples/electron-nodeintegration/package-lock.json @@ -17,7 +17,7 @@ }, "engines": { "node": ">=22.12.0", - "npm": ">=11.21.1" + "npm": ">=11.10.0" } }, "node_modules/@electron-internal/extract-zip": { diff --git a/examples/electron-nodeintegration/package.json b/examples/electron-nodeintegration/package.json index fa7f8824..58b204d0 100644 --- a/examples/electron-nodeintegration/package.json +++ b/examples/electron-nodeintegration/package.json @@ -33,6 +33,6 @@ }, "engines": { "node": ">=22.12.0", - "npm": ">=11.21.1" + "npm": ">=11.10.0" } } diff --git a/examples/electron/README.md b/examples/electron/README.md index bd2996fd..e0e321ea 100644 --- a/examples/electron/README.md +++ b/examples/electron/README.md @@ -7,7 +7,7 @@ This example uses context isolation, with node integration disabled. If you're l ## Prerequisites -- [Node.js](http://nodejs.org/) 22.12.0 or later and npm 11.21.1 or later. +- [Node.js](http://nodejs.org/) 22.12.0 or later and npm 11.10.0 or later. The `.npmrc` configuration excludes dependency releases younger than seven days when npm resolves new versions. diff --git a/examples/electron/package-lock.json b/examples/electron/package-lock.json index 9392ed59..6dc0208e 100644 --- a/examples/electron/package-lock.json +++ b/examples/electron/package-lock.json @@ -16,7 +16,7 @@ }, "engines": { "node": ">=22.12.0", - "npm": ">=11.21.1" + "npm": ">=11.10.0" } }, "node_modules/@electron-internal/extract-zip": { diff --git a/examples/electron/package.json b/examples/electron/package.json index 43a99c98..c9efc6e0 100644 --- a/examples/electron/package.json +++ b/examples/electron/package.json @@ -32,6 +32,6 @@ }, "engines": { "node": ">=22.12.0", - "npm": ">=11.21.1" + "npm": ">=11.10.0" } } From 5a6574ec321af859e46302c55e8b32c2f7eafd87 Mon Sep 17 00:00:00 2001 From: MahmoudElsayad Date: Wed, 11 Nov 2026 15:38:41 +0200 Subject: [PATCH 3/3] Drop the npm engine requirement from the Electron examples The lockfiles already pin Electron 43.8.4 for any npm version, and the npm requirement broke the SDK bump workflow, which runs npm 10.9.3. Also note that Electron downloads its binary on the first npm start. --- examples/electron-nodeintegration/README.md | 6 ++++-- examples/electron-nodeintegration/package-lock.json | 3 +-- examples/electron-nodeintegration/package.json | 3 +-- examples/electron/README.md | 6 ++++-- examples/electron/package-lock.json | 3 +-- examples/electron/package.json | 3 +-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/examples/electron-nodeintegration/README.md b/examples/electron-nodeintegration/README.md index f37f50ea..a88fb565 100644 --- a/examples/electron-nodeintegration/README.md +++ b/examples/electron-nodeintegration/README.md @@ -7,9 +7,11 @@ This example uses node integration. If you're looking for an example with contex ## Prerequisites -- [Node.js](http://nodejs.org/) 22.12.0 or later and npm 11.10.0 or later. +- [Node.js](http://nodejs.org/) 22.12.0 or later. -The `.npmrc` configuration excludes dependency releases younger than seven days when npm resolves new versions. +With npm 11.10.0 or later, the `.npmrc` configuration excludes dependency releases younger than seven days when npm resolves new versions. + +`npm install` does not download the Electron binary. The first `npm start` downloads it, so the first start takes longer and needs internet access. ## Support and Issues diff --git a/examples/electron-nodeintegration/package-lock.json b/examples/electron-nodeintegration/package-lock.json index 296a9fe0..d72168ee 100644 --- a/examples/electron-nodeintegration/package-lock.json +++ b/examples/electron-nodeintegration/package-lock.json @@ -16,8 +16,7 @@ "electron": "^43.8.4" }, "engines": { - "node": ">=22.12.0", - "npm": ">=11.10.0" + "node": ">=22.12.0" } }, "node_modules/@electron-internal/extract-zip": { diff --git a/examples/electron-nodeintegration/package.json b/examples/electron-nodeintegration/package.json index 58b204d0..cdc8b481 100644 --- a/examples/electron-nodeintegration/package.json +++ b/examples/electron-nodeintegration/package.json @@ -32,7 +32,6 @@ "@nutrient-sdk/viewer": "1.25.0" }, "engines": { - "node": ">=22.12.0", - "npm": ">=11.10.0" + "node": ">=22.12.0" } } diff --git a/examples/electron/README.md b/examples/electron/README.md index e0e321ea..33e26111 100644 --- a/examples/electron/README.md +++ b/examples/electron/README.md @@ -7,9 +7,11 @@ This example uses context isolation, with node integration disabled. If you're l ## Prerequisites -- [Node.js](http://nodejs.org/) 22.12.0 or later and npm 11.10.0 or later. +- [Node.js](http://nodejs.org/) 22.12.0 or later. -The `.npmrc` configuration excludes dependency releases younger than seven days when npm resolves new versions. +With npm 11.10.0 or later, the `.npmrc` configuration excludes dependency releases younger than seven days when npm resolves new versions. + +`npm install` does not download the Electron binary. The first `npm start` downloads it, so the first start takes longer and needs internet access. ## Usage with a license key diff --git a/examples/electron/package-lock.json b/examples/electron/package-lock.json index 6dc0208e..1ca90f53 100644 --- a/examples/electron/package-lock.json +++ b/examples/electron/package-lock.json @@ -15,8 +15,7 @@ "electron": "^43.8.4" }, "engines": { - "node": ">=22.12.0", - "npm": ">=11.10.0" + "node": ">=22.12.0" } }, "node_modules/@electron-internal/extract-zip": { diff --git a/examples/electron/package.json b/examples/electron/package.json index c9efc6e0..cd9695b3 100644 --- a/examples/electron/package.json +++ b/examples/electron/package.json @@ -31,7 +31,6 @@ "@nutrient-sdk/viewer": "1.25.0" }, "engines": { - "node": ">=22.12.0", - "npm": ">=11.10.0" + "node": ">=22.12.0" } }