Skip to content

Commit 36ea676

Browse files
committed
newprinter.py: Do not enable IPP in firewall when adding printer
It looks unnecessary to enable incoming traffic via TCP IPP port when adjusting firewall during printer installation - local communication happens over domain socket and if the machine acts as print server, it will have TCP port opened already.
1 parent bd8e863 commit 36ea676

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

newprinter.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2306,9 +2306,6 @@ def on_firewall_read (self, data):
23062306
def adjust_firewall_response (self, dialog, response):
23072307
dialog.destroy ()
23082308
if response == Gtk.ResponseType.YES:
2309-
ipp_server_allowed = self.firewall.check_ipp_server_allowed ()
2310-
if not ipp_server_allowed:
2311-
self.firewall.add_service (firewallsettings.IPP_SERVER_SERVICE)
23122309
self.firewall.write ()
23132310

23142311
debugprint ("Fetching network devices after firewall dialog response")

0 commit comments

Comments
 (0)