Skip to content

Commit a994c73

Browse files
committed
Fix support for simple punch finisher (Issue #821)
1 parent ac809be commit a994c73

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ Changes in CUPS v2.4.8 (TBA)
2424
- Fixed "Upgrade" header handling when there is no TLS support (Issue #775)
2525
- Fixed memory leak when unloading a job (Issue #813)
2626
- Fixed memory leak when creating color profiles (Issue #815)
27+
- Fixed a punch finishing bug in the IPP Everywhere support (Issue #821)
2728
- Fixed crash in `scan_ps()` if incoming argument is NULL (Issue #831)
2829
- Fixed setting job state reasons for successful jobs (Issue #832)
2930
- Fixed infinite loop in IPP backend if hostname is IP address with Kerberos

cups/ppd-cache.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4713,7 +4713,7 @@ _ppdCreateFromIPP2(
47134713
value = ippGetInteger(attr, i);
47144714
keyword = ippEnumString("finishings", value);
47154715

4716-
if (!strncmp(keyword, "cups-punch-", 11) || !strncmp(keyword, "punch-", 6))
4716+
if (!strcmp(keyword, "punch") || !strncmp(keyword, "cups-punch-", 11) || !strncmp(keyword, "punch-", 6))
47174717
break;
47184718
}
47194719

@@ -4759,7 +4759,7 @@ _ppdCreateFromIPP2(
47594759

47604760
if (!strncmp(keyword, "cups-punch-", 11))
47614761
keyword += 5;
4762-
else if (strncmp(keyword, "punch-", 6))
4762+
else if (strcmp(keyword, "punch") && strncmp(keyword, "punch-", 6))
47634763
continue;
47644764

47654765
if (cupsArrayFind(names, (char *)keyword))

0 commit comments

Comments
 (0)