Skip to content

Commit baf60c9

Browse files
committed
Add a todo for future callback changes
1 parent f0b01b3 commit baf60c9

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

libs/acn/LLRPProbeRequestInflator.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,14 +103,12 @@ bool LLRPProbeRequestInflator::HandlePDUData(uint32_t vector,
103103
OLA_DEBUG << "Probe from " << UID(pdu_data.lower_uid) << " to "
104104
<< UID(pdu_data.upper_uid);
105105

106-
// string rdm_message(reinterpret_cast<const char*>(&data[0]), pdu_len);
107-
108106
if (m_llrp_probe_request_handler.get()) {
109107
m_llrp_probe_request_handler->Run(&headers,
110108
UID(pdu_data.lower_uid),
111109
UID(pdu_data.upper_uid)
112-
//,
113-
// UIDSet()
110+
// TODO(Peter): Should we add the filter and known UIDs to the callback too?
111+
//, UIDSet()
114112
);
115113
} else {
116114
OLA_WARN << "No LLRP Probe Request handler defined!";

libs/acn/LLRPProbeRequestInflator.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ class LLRPProbeRequestInflator: public BaseInflator {
3939
const HeaderSet*, // the HeaderSet
4040
const ola::rdm::UID&, // lower UID
4141
const ola::rdm::UID& // upper UID
42-
//,
43-
// const ola::rdm::UIDSet, // known UIDs
42+
// TODO(Peter): Should we add the filter and known UIDs to the callback too?
43+
//, const ola::rdm::UIDSet, // known UIDs
4444
> LLRPProbeRequestHandler;
4545

4646
LLRPProbeRequestInflator();

0 commit comments

Comments
 (0)