fix: papers sizes depending on the citations count

Author: andreishket

vis/js/dataprocessing/managers/DataManager.ts

@@ -2,7 +2,6 @@
 
 import $ from "jquery";
 import d3 from "d3";
-
 import {
   getDiameterScale,
   getInitialCoordsScale,
@@ -19,6 +18,7 @@ import {
   getVisibleMetric,
   isOpenAccess,
   parseCoordinate,
+  getValueOrZero,
 } from "../../utils/data";
 import { transformData } from "../../utils/streamgraph";
 
@@ -250,14 +250,8 @@ class DataManager {
     paper.num_readers = 0;
     paper.internal_readers = 1;
 
-    // ? should we use numb_readers in some cases?
-    function parseNumber(value, defaultValue = 0) {
-      const num = Number(value);
-      return isNaN(num) ? defaultValue : num;
-    }
-
-    paper.num_readers = parseNumber(paper.readers);
-    paper.readers = parseNumber(paper.readers);
+    paper.num_readers = getValueOrZero(paper.readers);
+    paper.readers = getValueOrZero(paper.readers);
     paper.tweets = getVisibleMetric(paper, "cited_by_tweeters_count");
     paper.citations = getVisibleMetric(paper, "citation_count");
     // ? should we use readers.mendeley in some cases?

vis/js/reducers/data.ts

@@ -1,8 +1,12 @@
 import d3 from "d3";
 
 import { getDiameterScale, getResizedScale } from "../utils/scale";
+import { getValueOrZero } from "../utils/data";
 
-const data = (state = { list: [], options: {}, size: null } as any, action: any) => {
+const data = (
+  state = { list: [], options: {}, size: null } as any,
+  action: any
+) => {
   if (action.canceled) {
     return state;
   }
@@ -48,19 +52,23 @@ const data = (state = { list: [], options: {}, size: null } as any, action: any)
 
 export default data;
 
-
-const resizePapers = (papers: any[], currentSize: number, newSize: number, options: any) => {
+const resizePapers = (
+  papers: any[],
+  currentSize: number,
+  newSize: number,
+  options: any
+) => {
   const resizedPapers = papers.slice(0);
 
   let coordsScale = getResizedScale(currentSize, newSize);
 
-  let diameters = resizedPapers.map((e) => e.internal_readers);
+  let diameters = resizedPapers.map((e) => getValueOrZero(e.citation_count));
   let dScale = getDiameterScale(d3.extent(diameters), newSize, options);
 
   resizedPapers.forEach((paper: any) => {
     paper.x = coordsScale(paper.x);
     paper.y = coordsScale(paper.y);
-    paper.diameter = dScale(paper.internal_readers);
+    paper.diameter = dScale(getValueOrZero(paper.citation_count));
     paper.width =
       options.paperWidthFactor * Math.sqrt(Math.pow(paper.diameter, 2) / 2.6);
     paper.height =

vis/js/utils/data.ts

@@ -549,3 +549,8 @@ export const queryConcatenator = (terms) => {
   let concatenatedQueries = filtered_terms.join(" and ");
   return concatenatedQueries;
 };
+
+export const getValueOrZero = (value: unknown): number => {
+  const transformedValue = Number(value);
+  return isNaN(transformedValue) ? 0 : transformedValue;
+};