Merge pull request #735 from OpenKnowledgeMaps/security-updates

chreman · web-flow · commit 89846f0b6e41 · 2023-08-03T19:37:45.000+02:00
security bugfixes
diff --git a/server/services/displayPDF.php b/server/services/displayPDF.php
@@ -1,6 +1,6 @@
 <html>
 <head>
-<meta http-equiv="refresh" content="0; url=pdf.js-hypothes.is/viewer/web/viewer.html?file=<?php echo $_GET["file"] ?>" />
+<meta http-equiv="refresh" content="0; url=pdf.js-hypothes.is/viewer/web/viewer.html?file=<?php echo htmlspecialchars($_GET["file"]) ?>" />
 </head>
 <body>
 </body>
diff --git a/server/services/snapshot/headstart_snapshot.php b/server/services/snapshot/headstart_snapshot.php
@@ -8,7 +8,7 @@
     <body style="margin:0px; padding:0px">
 
         <div id="visualization"></div>
-        <script type="text/javascript" src="data-config_<?php echo $_GET['service'] ?>.js"></script>
+        <script type="text/javascript" src="data-config_<?php echo htmlspecialchars($_GET['service']) ?>.js"></script>
 		<script src="../../../../js/search_options.js"></script>
         <script>
             data_config.files = [{
@@ -18,7 +18,7 @@
             data_config.server_url = window.location.href.replace(/[^/]*$/, '') + "../../";
             data_config.show_context = true;
             data_config.create_title_from_context= true;
-            data_config.options = options_<?php echo $_GET['service']; ?>.dropdowns;
+            data_config.options = options_<?php echo htmlspecialchars($_GET['service']); ?>.dropdowns;
             if (<?php echo json_encode($_GET['service']) ?> === "linkedcat" ||
                 <?php echo json_encode($_GET['service']) ?> === "linkedcat_authorview" ||
                 <?php echo json_encode($_GET['service']) ?> === "linkedcat_browseview") {

-Original file line number
+Diff line change
@@ @@ -1,6 +1,6 @@ @@
 <html>
 <head>
 -<meta http-equiv="refresh" content="0; url=pdf.js-hypothes.is/viewer/web/viewer.html?file=<?php echo $_GET["file"] ?>" />
 +<meta http-equiv="refresh" content="0; url=pdf.js-hypothes.is/viewer/web/viewer.html?file=<?php echo htmlspecialchars($_GET["file"]) ?>" />
 </head>
 <body>
 </body>