Skip to content

Commit 4df0401

Browse files
KonstimanKonstiman
committed
removed in from source (list entry); fixed tests
1 parent 12a5f60 commit 4df0401

3 files changed

Lines changed: 2 additions & 95 deletions

File tree

‎vis/js/templates/listentry/Details.jsx‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ const Details = ({ authors, source, isSelected }) => {
2424
</div>
2525
{!!source && (
2626
<div className={"list_source" + (isSelected ? "" : " short")}>
27-
<span className="list_in">
28-
<Highlight> in </Highlight>
29-
</span>
3027
<span className="list_published_in">
3128
<Highlight queryHighlight>{source}</Highlight>
3229
</span>

‎vis/test/component/modals.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ describe("Modals component", () => {
310310

311311
expect(
312312
document.querySelector("#copy-paper-citation").textContent.trim()
313-
).toEqual("Doe, J. (2021). Test paper.");
313+
).toEqual("Doe, J. (2021). Test paper. https://example.com");
314314
});
315315

316316
it("triggers a correct redux action when citation modal is closed", () => {
@@ -374,7 +374,7 @@ describe("Modals component", () => {
374374
// tbh I don't get it why the output is this and not ACM
375375
expect(
376376
document.querySelector("#copy-paper-citation").textContent.trim()
377-
).toBe("Doe, J. (2021). Test paper.");
377+
).toBe("Doe, J. (2021). Test paper. https://example.com");
378378
});
379379
});
380380

‎vis/test/snapshot/__snapshots__/list-base.test.js.snap‎

Lines changed: 0 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -339,11 +339,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-in, p
339339
<div
340340
className="list_source"
341341
>
342-
<span
343-
className="list_in"
344-
>
345-
in
346-
</span>
347342
<span
348343
className="list_published_in"
349344
>
@@ -815,11 +810,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
815810
<div
816811
className="list_source short"
817812
>
818-
<span
819-
className="list_in"
820-
>
821-
in
822-
</span>
823813
<span
824814
className="list_published_in"
825815
>
@@ -966,11 +956,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
966956
<div
967957
className="list_source short"
968958
>
969-
<span
970-
className="list_in"
971-
>
972-
in
973-
</span>
974959
<span
975960
className="list_published_in"
976961
>
@@ -1119,11 +1104,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
11191104
<div
11201105
className="list_source short"
11211106
>
1122-
<span
1123-
className="list_in"
1124-
>
1125-
in
1126-
</span>
11271107
<span
11281108
className="list_published_in"
11291109
>
@@ -1270,11 +1250,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
12701250
<div
12711251
className="list_source short"
12721252
>
1273-
<span
1274-
className="list_in"
1275-
>
1276-
in
1277-
</span>
12781253
<span
12791254
className="list_published_in"
12801255
>
@@ -1412,11 +1387,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
14121387
<div
14131388
className="list_source short"
14141389
>
1415-
<span
1416-
className="list_in"
1417-
>
1418-
in
1419-
</span>
14201390
<span
14211391
className="list_published_in"
14221392
>
@@ -1565,11 +1535,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
15651535
<div
15661536
className="list_source short"
15671537
>
1568-
<span
1569-
className="list_in"
1570-
>
1571-
in
1572-
</span>
15731538
<span
15741539
className="list_published_in"
15751540
>
@@ -1716,11 +1681,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
17161681
<div
17171682
className="list_source short"
17181683
>
1719-
<span
1720-
className="list_in"
1721-
>
1722-
in
1723-
</span>
17241684
<span
17251685
className="list_published_in"
17261686
>
@@ -1858,11 +1818,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
18581818
<div
18591819
className="list_source short"
18601820
>
1861-
<span
1862-
className="list_in"
1863-
>
1864-
in
1865-
</span>
18661821
<span
18671822
className="list_published_in"
18681823
>
@@ -2000,11 +1955,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
20001955
<div
20011956
className="list_source short"
20021957
>
2003-
<span
2004-
className="list_in"
2005-
>
2006-
in
2007-
</span>
20081958
<span
20091959
className="list_published_in"
20101960
>
@@ -2142,11 +2092,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
21422092
<div
21432093
className="list_source short"
21442094
>
2145-
<span
2146-
className="list_in"
2147-
>
2148-
in
2149-
</span>
21502095
<span
21512096
className="list_published_in"
21522097
>
@@ -2284,11 +2229,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
22842229
<div
22852230
className="list_source short"
22862231
>
2287-
<span
2288-
className="list_in"
2289-
>
2290-
in
2291-
</span>
22922232
<span
22932233
className="list_published_in"
22942234
>
@@ -2426,11 +2366,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
24262366
<div
24272367
className="list_source short"
24282368
>
2429-
<span
2430-
className="list_in"
2431-
>
2432-
in
2433-
</span>
24342369
<span
24352370
className="list_published_in"
24362371
>
@@ -2568,11 +2503,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
25682503
<div
25692504
className="list_source short"
25702505
>
2571-
<span
2572-
className="list_in"
2573-
>
2574-
in
2575-
</span>
25762506
<span
25772507
className="list_published_in"
25782508
>
@@ -2710,11 +2640,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
27102640
<div
27112641
className="list_source short"
27122642
>
2713-
<span
2714-
className="list_in"
2715-
>
2716-
in
2717-
</span>
27182643
<span
27192644
className="list_published_in"
27202645
>
@@ -2863,11 +2788,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
28632788
<div
28642789
className="list_source short"
28652790
>
2866-
<span
2867-
className="list_in"
2868-
>
2869-
in
2870-
</span>
28712791
<span
28722792
className="list_published_in"
28732793
>
@@ -3014,11 +2934,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
30142934
<div
30152935
className="list_source short"
30162936
>
3017-
<span
3018-
className="list_in"
3019-
>
3020-
in
3021-
</span>
30222937
<span
30232938
className="list_published_in"
30242939
>
@@ -3431,11 +3346,6 @@ exports[`List entries component snapshot (BASE) matches a snapshot (zoomed-out)
34313346
<div
34323347
className="list_source short"
34333348
>
3434-
<span
3435-
className="list_in"
3436-
>
3437-
in
3438-
</span>
34393349
<span
34403350
className="list_published_in"
34413351
>

0 commit comments

Comments
 (0)