Skip to content

Commit 36f2b85

Browse files
committed
bugfix: fallback cycle in the getPDFLinkForBASE
1 parent 7f76500 commit 36f2b85

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

server/services/getPDF.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@ function extractValidPdfUrls(array $revision_data, string $paper_id, string $vis
150150

151151
function getPDFLinkForBASE($url) {
152152
$link_list = preg_split("/;/", $url);
153+
$link_list = array_map('trim', $link_list);
154+
$link_list = array_filter($link_list);
153155

154156
$matches_pdf = array_filter($link_list, function($item) { return substr($item, -strlen(".pdf")) === ".pdf"; });
155157
if(count($matches_pdf) != 0) {
@@ -173,6 +175,13 @@ function getPDFLinkForBASE($url) {
173175
}
174176
}
175177

178+
foreach ($link_list as $fallback_url) {
179+
$resolved = getRedirectURL($fallback_url);
180+
if ($resolved) {
181+
return $resolved;
182+
}
183+
}
184+
176185
return getRedirectURL(array_values($link_list)[0]);
177186
}
178187

0 commit comments

Comments
 (0)