Fixed: compilation for MINGW

TheNicker · Lior Lahav · commit b17ad23047f1 · 2024-06-25T01:55:51.000+03:00
diff --git a/Codecs/CodecJPG/CMakeLists.txt b/Codecs/CodecJPG/CMakeLists.txt
@@ -32,7 +32,7 @@ add_subdirectory(${libjpeg-turboFolder} ./external/libjpeg-turbo)
 target_include_directories(${TargetName} PRIVATE ${libjpeg-turboFolder})
 
 target_link_libraries(${TargetName} turbojpeg)
-if (${CMAKE_SYSTEM_NAME} MATCHES "Windows")
+if (${CMAKE_SYSTEM_NAME} MATCHES "Windows" AND  NOT MINGW)
     target_link_options(${TargetName} PUBLIC "/DELAYLOAD:$<TARGET_FILE_BASE_NAME:turbojpeg>.dll")
 else()
 endif()
diff --git a/Codecs/CodecPNG/CMakeLists.txt b/Codecs/CodecPNG/CMakeLists.txt
@@ -56,7 +56,7 @@ target_include_directories(${TargetName} PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/ext
 target_link_libraries(${TargetName} png_shared )
 target_include_directories(png_shared PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/external/zlib)
 
-if(MSVC)
+if (${CMAKE_SYSTEM_NAME} MATCHES "Windows" AND (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" OR CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC"))
   target_link_options(${TargetName} PUBLIC "/DELAYLOAD:$<TARGET_FILE_BASE_NAME:png_shared>.dll")
   target_link_options(${TargetName} PUBLIC "/DELAYLOAD:$<TARGET_FILE_BASE_NAME:zlib>.dll")
 endif()
diff --git a/Codecs/CodecTiff/CMakeLists.txt b/Codecs/CodecTiff/CMakeLists.txt
@@ -68,7 +68,6 @@ target_include_directories(${TargetName} PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/ext
 
 
 target_link_libraries(${TargetName} tiff)
-if(MSVC)
-   #set_property(TARGET tiff PROPERTY WINDOWS_EXPORT_ALL_SYMBOLS true)
+if (${CMAKE_SYSTEM_NAME} MATCHES "Windows" AND NOT MINGW)
    target_link_options(${TargetName} PUBLIC "/DELAYLOAD:$<TARGET_FILE_BASE_NAME:tiff>.dll")
 endif()
diff --git a/Example/example.cpp b/Example/example.cpp
@@ -21,9 +21,14 @@ int main()
 			
 			std::cout << "\ncat.png has been encoded in: " << std::setprecision(2) << std::fixed<< encodeTime.GetElapsedTimeReal(LLUtils::StopWatch::Milliseconds) << " ms";
 		}
+		else
+		{
+			std::cout << "\nError, cannot encode image";
+		}
 	}
 	else
 	{
+		std::cout << "\nError, cannot decode image";
 		resultCode = 1;
 	}
 
diff --git a/External/LLUtils b/External/LLUtils
@@ -1 +1 @@
-Subproject commit 3d5172eb5c43e9b1510ed1a05b639e7399f1d4ee
+Subproject commit a663625aaa487718c56179e5e1a337022b168144
diff --git a/External/libpsd b/External/libpsd
@@ -1 +1 @@
-Subproject commit 2f78b031130e91477cd0d79105bc890be0382dbd
+Subproject commit e670ae0be0c50a4afb83d3f1703cff1e6ca0c9ec
diff --git a/ImageUtil/CMakeLists.txt b/ImageUtil/CMakeLists.txt
@@ -8,4 +8,4 @@ add_library (${TargetName} STATIC ${sourceFiles})
 
 target_include_directories(${TargetName} PRIVATE ./Include)
 target_include_directories(${TargetName} PRIVATE ./Source)
-target_include_directories(${TargetName} PRIVATE ../External/ExoticNumbers/Include)
+target_include_directories(${TargetName} PRIVATE ../External/ExoticNumbers/include)
diff --git a/ImageUtil/Include/ImageUtil/ImageUtil.h b/ImageUtil/Include/ImageUtil/ImageUtil.h
@@ -324,7 +324,7 @@ namespace IMUtil
                 std::span sourceData(reinterpret_cast<const SourceSampleType*>(sampleData), totalPixels);
                 std::span bgraData(reinterpret_cast<PixelUtil::BitTexel32Ex*>(imageItem->data.data()), totalPixels);
                 //Find minMax is a single pass since image data is consecutive 
-                auto minMax = std::minmax_element(std::execution::parallel_unsequenced_policy(), std::begin(sourceData), std::end(sourceData));
+                auto minMax = std::minmax_element(std::execution::par_unseq, std::begin(sourceData), std::end(sourceData));
                 NormalizeAnyToRGBA(std::begin(bgraData), std::end(bgraData), std::begin(sourceData), std::end(sourceData), normalizeMode, std::make_pair(*minMax.first, *minMax.second) );
             }
             else
diff --git a/ImageUtil/Source/ImageUtil.cpp b/ImageUtil/Source/ImageUtil.cpp
@@ -1,5 +1,5 @@
 #include <ImageUtil/ImageUtil.h> 
-#include <ImageUtil\TexelConvertor.h>
+#include <ImageUtil/TexelConvertor.h>
 #include <ExoticNumbers/Float24.h>
 #include <ExoticNumbers/half.hpp>
 

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,14 @@ int main()`
`21`	`21`
`22`	`22`	`std::cout << "\ncat.png has been encoded in: " << std::setprecision(2) << std::fixed<< encodeTime.GetElapsedTimeReal(LLUtils::StopWatch::Milliseconds) << " ms";`
`23`	`23`	`}`
	`24`	`+ else`
	`25`	`+ {`
	`26`	`+ std::cout << "\nError, cannot encode image";`
	`27`	`+ }`
`24`	`28`	`}`
`25`	`29`	`else`
`26`	`30`	`{`
	`31`	`+ std::cout << "\nError, cannot decode image";`
`27`	`32`	`resultCode = 1;`
`28`	`33`	`}`
`29`	`34`
Original file line number	Diff line number	Diff line change
`@@ -324,7 +324,7 @@ namespace IMUtil`
`324`	`324`	`std::span sourceData(reinterpret_cast<const SourceSampleType*>(sampleData), totalPixels);`
`325`	`325`	`std::span bgraData(reinterpret_cast<PixelUtil::BitTexel32Ex*>(imageItem->data.data()), totalPixels);`
`326`	`326`	`//Find minMax is a single pass since image data is consecutive`
`327`		`- auto minMax = std::minmax_element(std::execution::parallel_unsequenced_policy(), std::begin(sourceData), std::end(sourceData));`
	`327`	`+ auto minMax = std::minmax_element(std::execution::par_unseq, std::begin(sourceData), std::end(sourceData));`
`328`	`328`	`NormalizeAnyToRGBA(std::begin(bgraData), std::end(bgraData), std::begin(sourceData), std::end(sourceData), normalizeMode, std::make_pair(minMax.first, minMax.second) );`
`329`	`329`	`}`
`330`	`330`	`else`