fix: Force implementation of finalize in subclasses of AnakysisType

Author: annehaley

uvdat/core/tasks/analytics/analysis_type.py

@@ -37,8 +37,7 @@ def validate_inputs(self, inputs):
 
     @abstractmethod
     def finalize(self, result):
-        # Override this to perform custom finalization
-        pass
+        raise NotImplementedError
 
 
 class AnalysisInputError(Exception):

uvdat/core/tasks/analytics/create_road_network.py

@@ -51,6 +51,9 @@ def run_task(self, *, project, **inputs):
         create_road_network.delay(result.id)
         return result
 
+    def finalize(self, result):
+        pass
+
 
 def metadata_for_row(row):
     return {

uvdat/core/tasks/analytics/flood_network_failure.py

@@ -68,6 +68,9 @@ def validate_inputs(self, inputs):
             # data is at 10 meter resolution
             raise AnalysisInputError("Station radius must be greater than 10")
 
+    def finalize(self, result):
+        pass
+
 
 def _get_station_region(point: Point, radius_meters: float) -> dict[str, Any]:
     """Get a rectangular region around a point, sized by radius_meters."""

uvdat/core/tasks/analytics/geoai_segmentation.py

@@ -59,6 +59,9 @@ def run_task(self, *, project, **inputs):
         geoai_segmentation.delay(result.id)
         return result
 
+    def finalize(self, result):
+        pass
+
 
 @shared_task(base=AnalysisTask)
 def geoai_segmentation(result_id):  # noqa: PLR0915

uvdat/core/tasks/analytics/network_recovery.py

@@ -79,6 +79,9 @@ def validate_inputs(self, inputs):
         if mode not in RECOVERY_MODES:
             raise AnalysisInputError("Recovery mode not a valid option")
 
+    def finalize(self, result):
+        pass
+
 
 def get_network_graph(network):
     network = {