Reformat with Rubocop

Author: thatbudakguy

lib/geo_combine/ckan_metadata.rb

@@ -32,7 +32,7 @@ def geoblacklight_terms
         layer_slug_s: @metadata['name'],
         solr_geom: envelope,
         dc_subject_sm: subjects,
-        dct_references_s: external_references.to_json.to_s,
+        dct_references_s: external_references.to_json,
         dc_format_s: downloadable? ? 'ZIP' : nil # TODO: we only allow direct ZIP file downloads
       }.compact
     end

lib/geo_combine/ogp.rb

@@ -123,7 +123,7 @@ def references
     # Builds a Solr Envelope using CQL syntax
     # @return [String]
     def envelope
-      raise ArgumentError unless west >= -180 && west <= 180 &&
+      raise ArgumentError unless west.between?(-180, 180) &&
                                  east >= -180 && east <= 180 &&
                                  north >= -90 && north <= 90 &&
                                  south >= -90 && south <= 90 &&
@@ -144,6 +144,15 @@ def fgdc
       GeoCombine::Fgdc.new(metadata['FgdcText']) if metadata['FgdcText']
     end
 
+    SLUG_STRIP_VALUES = %w[
+      SDE_DATA.
+      SDE.
+      SDE2.
+      GISPORTAL.GISOWNER01.
+      GISDATA.
+      MORIS.
+    ].freeze
+
     private
 
     ##
@@ -207,15 +216,6 @@ def slug
       sluggify(filter_name(name))
     end
 
-    SLUG_STRIP_VALUES = %w[
-      SDE_DATA.
-      SDE.
-      SDE2.
-      GISPORTAL.GISOWNER01.
-      GISDATA.
-      MORIS.
-    ].freeze
-
     def filter_name(name)
       # strip out schema and usernames
       SLUG_STRIP_VALUES.each do |strip_val|