Skip to content

[Feature]: make v1_resource_descriptor_support feature additive #1663

Description

@Javagedes

Feature Overview

The v1_resource_dscriptor_support feature currently swaps ResourceDescriptorV2 support for ResourceDescriptorV1 support. As the parent issue suggests, this goes against rust's rules that Features should be additive (as specified in Feature Unification.

Solution Overview

Paths to resolve this feature:

  1. If both HOBs can exist at the same time, then we should elect to always support ResourceDescritporV2 HOBs and the feature should only add support for parsing ResourceDescriptorV1 HOBs.

  2. Create a v2_resource_descriptor_support feature that is enabled by default and allow the platform to elect to enable one or the other (or both)

  3. If both HOBs cannot exist at the same time, then the feature should be completely removed, and a platform configuration should be added to decide which HOB to acknowledge.

Alternatives Considered

N/A

Urgency

Medium

Are you going to implement the feature request?

I will implement the feature

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

@os-d @makubacki for comments on solutions. I've provided three and amlooking for feedback.

Metadata

Metadata

Assignees

Labels

Type

Projects

Status
No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions