Enforce php import codestyle

Prior to this change, a uniform import style was not enforced. This resulted in feedback and manual rework in reviews.

This change automatically enforces a consistent standard way of using imports.

- no fqn in the code
- sorted by alphabet
- no unused imports

Author: johanib

ci/qa-config/phpcs.xml

@@ -6,10 +6,8 @@
     </description>
 
     <exclude-pattern>src/*/*Bundle/Resources</exclude-pattern>
-    <exclude-pattern>src/*/*Bundle/Tests</exclude-pattern>
     <exclude-pattern>src/*/Bundle/*Bundle/Resources</exclude-pattern>
-    <exclude-pattern>src/*/Bundle/*Bundle/Tests</exclude-pattern>
-    <exclude-pattern>*/Tests/*</exclude-pattern>
+    <exclude-pattern>tests/library</exclude-pattern>
 
     <!-- This is the rule we inherit from. If you want to exlude some specific rules, see the docs on how to do that -->
     <rule ref="PSR2"/>
@@ -20,5 +18,18 @@
             <property name="lineLimit" value="120"/>
             <property name="absoluteLineLimit" value="150"/>
         </properties>
+        <exclude-pattern>tests/</exclude-pattern>
     </rule>
+
+    <rule ref="PSR1.Methods.CamelCapsMethodName">
+        <exclude-pattern>tests/</exclude-pattern>
+    </rule>
+
+    <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly"/>
+    <rule ref="SlevomatCodingStandard.Namespaces.UnusedUses">
+        <properties>
+            <property name="searchAnnotations" type="bool" value="true"/>
+        </properties>
+    </rule>
+    <rule ref="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses"/>
 </ruleset>

ci/qa/phpcbf.sh

@@ -4,7 +4,7 @@ set -e
 cd $(dirname $0)/../../
 
 echo -e "\nPHP CodeSniffer\n"
-./vendor/bin/phpcbf --standard=ci/qa-config/phpcs.xml src
+./vendor/bin/phpcbf --standard=ci/qa-config/phpcs.xml src tests
 
 echo -e "\nPHP CodeSniffer (legacy code)\n"
 ./vendor/bin/phpcs --standard=ci/qa-config/phpcs-legacy.xml library

ci/qa/phpcs.sh

@@ -4,7 +4,7 @@ set -e
 cd $(dirname $0)/../../
 
 echo -e "\nPHP CodeSniffer\n"
-./vendor/bin/phpcs --report=full --standard=ci/qa-config/phpcs.xml --warning-severity=0 --extensions=php src
+./vendor/bin/phpcs --report=full --standard=ci/qa-config/phpcs.xml --warning-severity=0 --extensions=php src tests
 
 echo -e "\nPHP CodeSniffer (legacy code)\n"
 ./vendor/bin/phpcs --standard=ci/qa-config/phpcs-legacy.xml --warning-severity=0 --extensions=php -s library

composer.json

@@ -71,6 +71,7 @@
         "phpmd/phpmd": "^2.15",
         "phpunit/phpunit": "^11",
         "rector/rector": "^2.2.7",
+        "slevomat/coding-standard": "^8.28",
         "squizlabs/php_codesniffer": "^4.0",
         "symfony/debug-bundle": "6.4.*",
         "symfony/http-client": "6.4.*",
@@ -131,6 +132,7 @@
         },
         "sort-packages": true,
         "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true,
             "endroid/installer": false,
             "symfony/flex": true
         }

composer.lock

@@ -24,6 +24,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Kernel as BaseKernel;
 use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
+use function dirname;
 
 class Kernel extends BaseKernel
 {
@@ -43,7 +44,7 @@ public function registerBundles(): iterable
 
     public function getProjectDir(): string
     {
-        return \dirname(__DIR__);
+        return dirname(__DIR__);
     }
 
     protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void

src/Kernel.php

@@ -19,6 +19,7 @@
 namespace OpenConext\EngineBlock\Assert;
 
 use Assert\Assertion as BaseAssertion;
+use OpenConext\EngineBlock\Exception\InvalidArgumentException;
 
 /**
  * @method static void nullOrNonEmptyString($value, $message = null, $propertyPath = null)
@@ -29,7 +30,7 @@ class Assertion extends BaseAssertion
     const INVALID_NON_EMPTY_STRING  = 1001;
     const INVALID_HASHING_ALGORITHM = 1002;
 
-    protected static $exceptionClass = \OpenConext\EngineBlock\Exception\InvalidArgumentException::class;
+    protected static $exceptionClass = InvalidArgumentException::class;
 
     /**
      * @param string $value

src/OpenConext/EngineBlock/Assert/Assertion.php

@@ -19,9 +19,9 @@
 namespace OpenConext\EngineBlock\Authentication\Dto;
 
 use DateTime;
+use OpenConext\EngineBlock\Authentication\Model\Consent as ConsentEntity;
 use OpenConext\EngineBlock\Metadata\ContactPerson;
 use OpenConext\EngineBlock\Metadata\Entity\ServiceProvider;
-use OpenConext\EngineBlock\Authentication\Model\Consent as ConsentEntity;
 
 final class Consent
 {