upgrade Engine block to php 8.5 (#1962)

* Upgrade to PHP 8.5 and Node 24

- Rename Dockerfile-php82 → Dockerfile-php85, use php85-apache2-node24 base image
- Rename docker-compose-php82.yml → docker-compose-php85.yml
- Update Dockerfile.prod to php85-apache2
- Update docker-compose-tag-release.yml to php85-apache2-node24
- Bump composer.json PHP constraint to ^8.5, run composer update
- Run yarn upgrade for Node 24 compatibility
- Update GitHub Actions matrix and PROD_PHP to php85

Fixes #1847

* Fix PHP 8.5 implicit nullable parameter deprecations

Apply ExplicitNullableParamTypeRector across src/, library/ and tests/
to replace implicit nullable params (Foo $x = null) with explicit
nullable types (?Foo $x = null), fixing the PHP 8.5 deprecation that
was crashing the PHPUnit bootstrap.

794 PHPUnit tests passing on PHP 8.5 after this change.

* Fix remaining PHP 8.5 deprecations breaking Behat in CI

- Bindings.php: replace null array key with empty string
- NameIdResolver.php: cast spId/idpId to string before session access
- XmlToArray.php: remove xml_parser_free() deprecated since PHP 8.5

All 277 Behat scenarios now pass.

* Patch fix

Author: kayjoosten

.github/workflows/run-cypress.yml

@@ -16,9 +16,9 @@ jobs:
         timeout-minutes: 30
         strategy:
             matrix:
-                php: [ php82 ]
+                php: [ php85 ]
         env:
-            PROD_PHP: php82
+            PROD_PHP: php85
             DOCKER_COMPOSE: docker compose -f docker-compose.yml -f docker-compose-${{matrix.php}}.yml
         steps:
             -   name: Checkout

.github/workflows/test-integration.yml

@@ -15,9 +15,9 @@ jobs:
         timeout-minutes: 30
         strategy:
             matrix:
-                php: [ php82 ]
+                php: [ php85 ]
         env:
-            PROD_PHP: php82
+            PROD_PHP: php85
             DOCKER_COMPOSE: docker compose -f docker-compose.yml -f docker-compose-${{matrix.php}}.yml
         steps:
             -   name: Checkout

composer.json

@@ -16,7 +16,7 @@
         "source": "https://github.com/OpenConext/OpenConext-engineblock"
     },
     "require": {
-        "php": "^8.2",
+        "php": "^8.5",
         "ext-dom": "*",
         "ext-json": "*",
         "ext-mbstring": "*",
@@ -58,6 +58,7 @@
         "behat/behat": "^3.26",
         "behat/mink": "^1.12",
         "behat/mink-browserkit-driver": "^2.2",
+        "cweagans/composer-patches": "^1.7",
         "dmore/behat-chrome-extension": "^1.4",
         "dmore/chrome-mink-driver": "2.9.3",
         "friends-of-behat/mink-extension": "^2.7.5",
@@ -129,16 +130,23 @@
     "config": {
         "optimize-autoloader": true,
         "platform": {
-            "php": "8.2"
+            "php": "8.5"
         },
         "sort-packages": true,
         "allow-plugins": {
+            "cweagans/composer-patches": true,
             "dealerdirect/phpcodesniffer-composer-installer": true,
             "endroid/installer": false,
             "symfony/flex": true
         }
     },
     "extra": {
+        "composer-exit-on-patch-failure": true,
+        "patches": {
+            "phrity/websocket": {
+                "PHP 8.5: fix implicit nullable param in ConnectionException": "patches/phrity-websocket-php85-nullable.patch"
+            }
+        },
         "symfony": {
             "allow-contrib": false,
             "require": "7.4.*"