Skip to content

Commit 90e2541

Browse files
committed
Sign MacOS app folder as well as DMG
1 parent 2ab68ce commit 90e2541

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

.github/workflows/mac_build_deploy.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,18 @@ jobs:
8080
run: |
8181
python $GITHUB_WORKSPACE/release/build.py
8282
cp $GITHUB_WORKSPACE/OpenBCI_GUI/sketch.icns $GITHUB_WORKSPACE/application.macosx/OpenBCI_GUI.app/Contents/Resources/sketch.icns
83-
dmgbuild -s release/mac/dmgbuild_settings.py -D app=$GITHUB_WORKSPACE/application.macosx/OpenBCI_GUI.app \
83+
84+
- name: Sign Build
85+
run: |
86+
codesign -f -v -s "Developer ID Application: OpenBCI, Inc. (3P82WRGLM8)" $GITHUB_WORKSPACE/application.macosx/OpenBCI_GUI.app
87+
88+
- name: Create DMG
89+
run: |
90+
dmgbuild -s release/mac/dmgbuild_settings.py \
91+
-D app=$GITHUB_WORKSPACE/application.macosx/OpenBCI_GUI.app \
8492
OpenBCI_GUI $GITHUB_WORKSPACE/application.macosx.dmg
8593
86-
- name: Sign
94+
- name: Sign DMG
8795
run: |
8896
codesign -f -v -s "Developer ID Application: OpenBCI, Inc. (3P82WRGLM8)" $GITHUB_WORKSPACE/application.macosx.dmg
8997

release/package.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def main ():
6060

6161
if LOCAL_OS == MAC:
6262
shutil.move(flavors[LOCAL_OS] + ".dmg", new_name + "macosx.dmg")
63-
else:
63+
else: # Windows and Linux
6464
release_directory = flavors[LOCAL_OS].replace("application.", new_name)
6565
release_directory = os.path.join(os.getcwd(), release_directory)
6666

0 commit comments

Comments
 (0)