Skip to content

Commit 0db7671

Browse files
committed
Fix FFT and BandPower widget dropdowns linked settings on frontend
1 parent 88280fa commit 0db7671

3 files changed

Lines changed: 29 additions & 5 deletions

File tree

OpenBCI_GUI/FFTEnums.pde

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public enum FFTSmoothingFactor implements IndexingInterface {
7777
// Used by FFT Widget and Band Power Widget
7878
public enum FFTFilteredEnum implements IndexingInterface {
7979
FILTERED (0, "Filtered"),
80-
UNFILTERED (1, "Unfiltered");
80+
UNFILTERED (1, "Unfilt.");
8181

8282
private final int index;
8383
private final String label;

OpenBCI_GUI/W_BandPower.pde

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,16 @@ class W_BandPower extends Widget {
255255
normalizedBandPowers[i] = activePower[i] / normalizingSum;
256256
}
257257
}
258+
259+
public void setSmoothingDropdownFrontend(FFTSmoothingFactor _smoothingFactor) {
260+
String s = _smoothingFactor.getString();
261+
cp5_widget.getController("bandPowerSmoothingDropdown").getCaptionLabel().setText(s);
262+
}
263+
264+
public void setFilteringDropdownFrontend(FFTFilteredEnum _filteredEnum) {
265+
String s = _filteredEnum.getString();
266+
cp5_widget.getController("bandPowerDataFilteringDropdown").getCaptionLabel().setText(s);
267+
}
258268
};
259269

260270
public void bandPowerAutoCleanDropdown(int n) {
@@ -271,10 +281,12 @@ public void bandPowerAutoCleanTimerDropdown(int n) {
271281

272282
public void bandPowerSmoothingDropdown(int n) {
273283
globalFFTSettings.setSmoothingFactor(FFTSmoothingFactor.values()[n]);
274-
//FIX ME TO UPDATE THE FFT WIDGET DROPDOWN ALSO
284+
FFTSmoothingFactor smoothingFactor = globalFFTSettings.getSmoothingFactor();
285+
w_fft.setSmoothingDropdownFrontend(smoothingFactor);
275286
}
276287

277288
public void bandPowerDataFilteringDropdown(int n) {
278289
globalFFTSettings.setFilteredEnum(FFTFilteredEnum.values()[n]);
279-
//FIX ME TO UPDATE THE FFT WIDGET DROPDOWN ALSO
290+
FFTFilteredEnum filteredEnum = globalFFTSettings.getFilteredEnum();
291+
w_fft.setFilteringDropdownFrontend(filteredEnum);
280292
}

OpenBCI_GUI/W_FFT.pde

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,16 @@ class W_fft extends Widget {
198198
fftPlot.setLogScale("");
199199
}
200200
}
201+
202+
public void setSmoothingDropdownFrontend(FFTSmoothingFactor _smoothingFactor) {
203+
String s = _smoothingFactor.getString();
204+
cp5_widget.getController("fftSmoothingDropdown").getCaptionLabel().setText(s);
205+
}
206+
207+
public void setFilteringDropdownFrontend(FFTFilteredEnum _filteredEnum) {
208+
String s = _filteredEnum.getString();
209+
cp5_widget.getController("fftFilteringDropdown").getCaptionLabel().setText(s);
210+
}
201211
};
202212

203213
//These functions need to be global! These functions are activated when an item from the corresponding dropdown is selected
@@ -215,10 +225,12 @@ public void fftLogLinDropdown(int n) {
215225

216226
public void fftSmoothingDropdown(int n) {
217227
globalFFTSettings.setSmoothingFactor(FFTSmoothingFactor.values()[n]);
218-
//FIX ME TO UPDATE THE BAND POWER WIDGET DROPDOWN ALSO
228+
FFTSmoothingFactor smoothingFactor = globalFFTSettings.getSmoothingFactor();
229+
w_bandPower.setSmoothingDropdownFrontend(smoothingFactor);
219230
}
220231

221232
public void fftFilteringDropdown(int n) {
222233
globalFFTSettings.setFilteredEnum(FFTFilteredEnum.values()[n]);
223-
//FIX ME TO UPDATE THE BAND POWER WIDGET DROPDOWN ALSO
234+
FFTFilteredEnum filteredEnum = globalFFTSettings.getFilteredEnum();
235+
w_bandPower.setFilteringDropdownFrontend(filteredEnum);
224236
}

0 commit comments

Comments
 (0)