Innocuous changes. Some array allocation removal.

Author: electricessence

ExpressiveCommandBase.cs

@@ -486,7 +486,7 @@ public T ExecuteReturn<T>()
 		/// <param name="behavior">The command behavior for once the command the reader is complete.</param>
 		public void ExecuteReader(Action<IDataReader> handler, CommandBehavior behavior = CommandBehavior.Default)
 		{
-			if (Connection == null || Connection.State == ConnectionState.Closed) behavior = behavior | CommandBehavior.CloseConnection;
+			if (Connection == null || Connection.State == ConnectionState.Closed) behavior |= CommandBehavior.CloseConnection;
 			Execute(command => command.ExecuteReader(handler, behavior));
 		}
 
@@ -499,7 +499,7 @@ public void ExecuteReader(Action<IDataReader> handler, CommandBehavior behavior
 		/// <returns>The result of the transform.</returns>
 		public T ExecuteReader<T>(Func<IDataReader, T> transform, CommandBehavior behavior = CommandBehavior.Default)
 		{
-			if (Connection == null || Connection.State == ConnectionState.Closed) behavior = behavior | CommandBehavior.CloseConnection;
+			if (Connection == null || Connection.State == ConnectionState.Closed) behavior |= CommandBehavior.CloseConnection;
 			return Execute(command => command.ExecuteReader(transform, behavior));
 		}
 

Extensions.Dataflow.cs

@@ -107,7 +107,7 @@ public static async Task ToTargetBlockAsync<T>(this DbCommand command,
 			if (target.IsStillAlive())
 			{
 				var state = await command.Connection.EnsureOpenAsync(cancellationToken);
-				if (state == ConnectionState.Closed) behavior = behavior | CommandBehavior.CloseConnection;
+				if (state == ConnectionState.Closed) behavior |= CommandBehavior.CloseConnection;
 				using (var reader = await command.ExecuteReaderAsync(behavior, cancellationToken))
 				{
 					if (target.IsStillAlive())

Extensions.Retrieve.cs

@@ -59,7 +59,7 @@ public static QueryResult<Queue<object[]>> Retrieve(this IDataReader reader, IEn
 		/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
 		public static QueryResult<Queue<object[]>> Retrieve(this IDataReader reader, int n, params int[] others)
-			=> Retrieve(reader, new[] { n }.Concat(others));
+			=> Retrieve(reader, Enumerable.Repeat(n, 1).Concat(others));
 
 		/// <summary>
 		/// Iterates all records within the current result set using an IDataReader and returns the desired results.
@@ -84,7 +84,7 @@ public static QueryResult<Queue<object[]>> Retrieve(this IDataReader reader, IEn
 		/// <param name="others">The remaining column names to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
 		public static QueryResult<Queue<object[]>> Retrieve(this IDataReader reader, string c, params string[] others)
-			=> Retrieve(reader, new[] { c }.Concat(others));
+			=> Retrieve(reader, Enumerable.Repeat(c, 1).Concat(others));
 
 		/// <summary>
 		/// Iterates all records within the first result set using an IDataReader and returns the results.
@@ -115,7 +115,7 @@ public static QueryResult<Queue<object[]>> Retrieve(this IDbCommand command, IEn
 		/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
 		public static QueryResult<Queue<object[]>> Retrieve(this IDbCommand command, int n, params int[] others)
-			=> ExecuteReader(command, reader => Retrieve(reader, new[] { n }.Concat(others)));
+			=> ExecuteReader(command, reader => Retrieve(reader, Enumerable.Repeat(n, 1).Concat(others)));
 
 		/// <summary>
 		/// Iterates all records within the first result set using an IDataReader and returns the desired results as a list of Dictionaries containing only the specified column values.
@@ -136,7 +136,7 @@ public static QueryResult<Queue<object[]>> Retrieve(this IDbCommand command, IEn
 		/// <param name="others">The remaining column names to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
 		public static QueryResult<Queue<object[]>> Retrieve(this IDbCommand command, string c, params string[] others)
-			=> ExecuteReader(command, reader => Retrieve(reader, new[] { c }.Concat(others)));
+			=> ExecuteReader(command, reader => Retrieve(reader, Enumerable.Repeat(c, 1).Concat(others)));
 
 		/// <summary>
 		/// Asynchronously enumerates all the remaining values of the current result set of a data reader.
@@ -224,7 +224,7 @@ public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbDataReader
 		/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains a buffer block of the results and the column mappings.</returns>
 		public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbDataReader reader, int n, params int[] others)
-			=> RetrieveAsync(reader, new[] { n }.Concat(others));
+			=> RetrieveAsync(reader, Enumerable.Repeat(n, 1).Concat(others));
 
 		/// <summary>
 		/// Asynchronously enumerates all the remaining values of the current result set of a data reader.
@@ -236,7 +236,7 @@ public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbDataReader
 		/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains a buffer block of the results and the column mappings.</returns>
 		public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbDataReader reader, CancellationToken token, int n, params int[] others)
-			=> RetrieveAsync(reader, new[] { n }.Concat(others), token);
+			=> RetrieveAsync(reader, Enumerable.Repeat(n, 1).Concat(others), token);
 
 		/// <summary>
 		/// Asynchronously enumerates all records within the current result set using an IDataReader and returns the desired results.
@@ -268,7 +268,7 @@ public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbDataReader
 		/// <param name="others">The remaining column names to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
 		public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbDataReader reader, string c, params string[] others)
-			=> RetrieveAsync(reader, new[] { c }.Concat(others));
+			=> RetrieveAsync(reader, Enumerable.Repeat(c, 1).Concat(others));
 
 		/// <summary>
 		/// Asynchronously enumerates all records within the current result set using an IDataReader and returns the desired results.
@@ -280,7 +280,7 @@ public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbDataReader
 		/// <param name="others">The remaining column names to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
 		public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbDataReader reader, CancellationToken token, string c, params string[] others)
-			=> RetrieveAsync(reader, new[] { c }.Concat(others), false, token);
+			=> RetrieveAsync(reader, Enumerable.Repeat(c, 1).Concat(others), false, token);
 
 		/// <summary>
 		/// Asynchronously enumerates all the remaining values of the current result set of a data reader.
@@ -317,7 +317,7 @@ public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbCommand co
 		/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains a buffer block of the results and the column mappings.</returns>
 		public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbCommand command, int n, params int[] others)
-			=> RetrieveAsync(command, new[] { n }.Concat(others));
+			=> RetrieveAsync(command, Enumerable.Repeat(n, 1).Concat(others));
 
 		/// <summary>
 		/// Asynchronously enumerates all the remaining values of the current result set of a data reader.
@@ -329,7 +329,7 @@ public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbCommand co
 		/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains a buffer block of the results and the column mappings.</returns>
 		public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbCommand command, CancellationToken token, int n, params int[] others)
-			=> RetrieveAsync(command, new[] { n }.Concat(others), token);
+			=> RetrieveAsync(command, Enumerable.Repeat(n, 1).Concat(others), token);
 
 		/// <summary>
 		/// Asynchronously enumerates all records within the current result set using an IDataReader and returns the desired results.
@@ -353,7 +353,7 @@ public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbCommand co
 		/// <param name="others">The remaining column names to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
 		public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbCommand command, string c, params string[] others)
-			=> RetrieveAsync(command, new[] { c }.Concat(others));
+			=> RetrieveAsync(command, Enumerable.Repeat(c, 1).Concat(others));
 
 		/// <summary>
 		/// Asynchronously enumerates all records within the current result set using an IDataReader and returns the desired results.
@@ -365,7 +365,7 @@ public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbCommand co
 		/// <param name="others">The remaining column names to request from the reader for each record.</param>
 		/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
 		public static Task<QueryResult<Queue<object[]>>> RetrieveAsync(this DbCommand command, CancellationToken token, string c, params string[] others)
-			=> RetrieveAsync(command, new[] { c }.Concat(others), false, token);
+			=> RetrieveAsync(command, Enumerable.Repeat(c, 1).Concat(others), false, token);
 
 	}
 }

SqlClient/ExpressiveSqlCommand.cs

@@ -47,8 +47,12 @@ protected override void AddParams(SqlCommand command)
 		{
 			foreach (var p in Params)
 			{
-				var np = command.Parameters.AddWithValue(p.Name, p.Value);
-				if (p.Type.HasValue) np.SqlDbType = p.Type.Value;
+				var np = command
+                    .Parameters
+                    .AddWithValue(p.Name, p.Value);
+
+				if (p.Type.HasValue)
+                    np.SqlDbType = p.Type.Value;
 			}
 		}
 

SqlClient/Extensions.CreateCommand.cs

@@ -60,7 +60,10 @@ public static SqlCommand CreateStoredProcedureCommand(this SqlConnection connect
 		public static SqlCommand CreateCommand(this SqlTransaction transaction,
 			CommandType type, string commandText, int secondsTimeout = CommandTimeout.DEFAULT_SECONDS)
 		{
-			var command = transaction.Connection.CreateCommand(type, commandText, secondsTimeout);
+			var command = transaction
+                .Connection
+                .CreateCommand(type, commandText, secondsTimeout);
+
 			command.Transaction = transaction;
 			return command;
 		}