Revised "AddThese" to just "Add"

Author: electricessence

source/CollectionWrapper.cs

@@ -32,8 +32,8 @@ protected virtual void AddInternal(T item)
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public virtual void Add(T item) => AddInternal(item);
 
-    /// <inheritdoc cref="IAddMultiple{T}.AddThese(T, T, T[])"/>
-    public virtual void AddThese(T item1, T item2, params T[] items)
+    /// <inheritdoc cref="IAddMultiple{T}.Add(T, T, T[])"/>
+    public virtual void Add(T item1, T item2, params T[] items)
     {
         AddInternal(item1);
         AddInternal(item2);

source/IAddMultiple.cs

@@ -7,7 +7,7 @@ public interface IAddMultiple<T>
     /// <param name="item1">First item to add.</param>
     /// <param name="item2">Additional item to add.</param>
     /// <param name="items">Extended param items to add.</param>
-    void AddThese(T item1, T item2, params T[] items);
+    void Add(T item1, T item2, params T[] items);
 
     /// <summary>
     /// Adds all the items in <paramref name="items"/> to this collection.

source/ReadOnlyCollectionWrapper.cs

@@ -70,7 +70,6 @@ public virtual Span<T> CopyTo(Span<T> span)
         => InternalSource.CopyToSpan(span);
 
     /// <inheritdoc cref="ISynchronizedCollection&lt;T&gt;.Export(ICollection{T})" />
-
     [ExcludeFromCodeCoverage]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public virtual void Export(ICollection<T> to)

source/Synchronized/LockSynchronizedCollectionWrapper.cs

@@ -23,7 +23,7 @@ public override void Add(T item)
 
     /// <inheritdoc />
     [SuppressMessage("Roslynator", "RCS1235:Optimize method call.")]
-    public override void AddThese(T item1, T item2, params T[] items)
+    public override void Add(T item1, T item2, params T[] items)
     {
         lock (Sync)
         {

source/Synchronized/ReadWriteSynchronizedCollectionWrapper.cs

@@ -32,7 +32,7 @@ public override void Add(T item)
 
     /// <inheritdoc />
     [SuppressMessage("Roslynator", "RCS1235:Optimize method call.")]
-    public override void AddThese(T item1, T item2, params T[] items)
+    public override void Add(T item1, T item2, params T[] items)
     {
         using var write = RWLock.WriteLock();
         base.Add(item1);

source/Synchronized/TrackedCollectionWrapper.cs

@@ -5,6 +5,7 @@
 using System.Collections.Immutable;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
+using System.Runtime.CompilerServices;
 using System.Threading;
 
 namespace Open.Collections.Synchronized;
@@ -37,6 +38,9 @@ protected override void OnDispose()
         Nullify(ref InternalSource); // Eliminate risk from wrapper.
     }
 
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    private bool AssertIsAliveCore() => AssertIsAlive();
+
     /// <inheritdoc />
     public int Count
         => Sync!.Reading(() =>
@@ -51,15 +55,15 @@ protected virtual void AddInternal(T item)
 
     /// <inheritdoc />
     public void Add(T item)
-        => Sync!.Modifying(() => AssertIsAlive(), () =>
+        => Sync!.Modifying(AssertIsAliveCore, () =>
         {
             AddInternal(item);
             return true;
         });
 
-    /// <inheritdoc cref="IAddMultiple{T}.AddThese(T, T, T[])" />
-    public void AddThese(T item1, T item2, params T[] items)
-        => Sync!.Modifying(() => AssertIsAlive(), () =>
+    /// <inheritdoc cref="IAddMultiple{T}.Add(T, T, T[])" />
+    public void Add(T item1, T item2, params T[] items)
+        => Sync!.Modifying(AssertIsAliveCore, () =>
         {
             AddInternal(item1);
             AddInternal(item2);
@@ -83,7 +87,7 @@ public void AddRange(IEnumerable<T> items)
         if (enumerable.Count == 0)
             return;
 
-        Sync!.Modifying(() => AssertIsAlive(), () =>
+        Sync!.Modifying(AssertIsAliveCore, () =>
         {
             foreach (var item in enumerable)
                 AddInternal(item);
@@ -122,7 +126,7 @@ public void CopyTo(T[] array, int arrayIndex)
     /// <inheritdoc />
     public virtual bool Remove(T item)
         => Sync!.Modifying(
-            () => AssertIsAlive(),
+            AssertIsAliveCore,
             () => InternalSource.Remove(item));
 
     [ExcludeFromCodeCoverage]

testing/Open.Collections.Tests/BasicCollectionTests.cs

@@ -33,12 +33,12 @@ public void AddThese()
         if (Collection is not IAddMultiple<int> c) return;
         if (Collection.IsReadOnly)
         {
-            Assert.Throws<Exception>(() => c.AddThese(1, 2, 3, 4));
+            Assert.Throws<Exception>(() => c.Add(1, 2, 3, 4));
             return;
         }
 
         int count = Collection.Count;
-        c.AddThese(1, 2, 3, 4);
+        c.Add(1, 2, 3, 4);
         Collection.Count.Should().Be(count + 4);
     }