Test updates.

Author: electricessence

benchmarking/Program.cs

@@ -193,7 +193,7 @@ static void DictionaryTests()
             _ => () => new ConcurrentDictionary<int, object>());
 
         report.AddBenchmark("LockSynchronized Dictionary",
-            _ => () => new LockSynchronizedDictionaryWrapper<int, object>());
+            _ => () => new LockSynchronizedDictionary<int, object>());
         //report.AddBenchmark("ReadWriteSynchronized Dictionary",
         //    _ => () => new ReadWriteSynchronizedDictionaryWrapper<int, object>());
 

source/Synchronized/LockSynchronizedDictionaryWrapper.cs

@@ -65,6 +65,11 @@ public class LockSynchronizedDictionaryWrapper<TKey, TValue>
     public LockSynchronizedDictionaryWrapper(IDictionary<TKey, TValue> dictionary) : base(dictionary)
     {
     }
+}
 
-    public LockSynchronizedDictionaryWrapper(int capacity = 0) : this(new Dictionary<TKey, TValue>(capacity)) { }
+[ExcludeFromCodeCoverage]
+public class LockSynchronizedDictionary<TKey, TValue>
+    : LockSynchronizedDictionaryWrapper<TKey, TValue>
+{
+    public LockSynchronizedDictionary(int capacity = 0) : base(new Dictionary<TKey, TValue>(capacity)) { }
 }

source/Synchronized/LockSynchronizedList.cs

@@ -4,7 +4,8 @@
 namespace Open.Collections.Synchronized;
 
 [ExcludeFromCodeCoverage]
-public class LockSynchronizedList<T> : LockSynchronizedListWrapper<T>
+public sealed class LockSynchronizedList<T>
+    : LockSynchronizedListWrapper<T>
 {
     public LockSynchronizedList(int capacity = 0) : base(new List<T>(capacity)) { }
     public LockSynchronizedList(IEnumerable<T> collection) : base(new List<T>(collection)) { }

source/Synchronized/ReadWriteSynchronizedDictionaryWrapper.cs

@@ -102,6 +102,11 @@ public class ReadWriteSynchronizedDictionaryWrapper<TKey, TValue>
     public ReadWriteSynchronizedDictionaryWrapper(IDictionary<TKey, TValue> dictionary, bool owner = false) : base(dictionary, owner)
     {
     }
+}
 
-    public ReadWriteSynchronizedDictionaryWrapper(int capacity = 0) : this(new Dictionary<TKey, TValue>(capacity)) { }
+[ExcludeFromCodeCoverage]
+public class ReadWriteSynchronizedDictionary<TKey, TValue>
+    : ReadWriteSynchronizedDictionaryWrapper<TKey, TValue>
+{
+    public ReadWriteSynchronizedDictionary(int capacity = 0) : base(new Dictionary<TKey, TValue>(capacity)) { }
 }

source/Synchronized/ReadWriteSynchronizedList.cs

@@ -4,7 +4,8 @@
 namespace Open.Collections.Synchronized;
 
 [ExcludeFromCodeCoverage]
-public sealed class ReadWriteSynchronizedList<T> : ReadWriteSynchronizedListWrapper<T>
+public sealed class ReadWriteSynchronizedList<T>
+    : ReadWriteSynchronizedListWrapper<T>
 {
     public ReadWriteSynchronizedList(int capacity = 0)
         : base(new List<T>(capacity)) { }

source/Synchronized/TrackedDictionaryWrapper.cs

@@ -58,8 +58,8 @@ public bool SetValue(TKey key, TValue value)
     private bool SetValueInternal(TKey key, TValue value)
     {
         bool changing
-            = InternalSource.TryGetValue(key, out var current)
-            && !(current?.Equals(value) ?? value is null);
+            = !InternalSource.TryGetValue(key, out var current)
+            || !(current?.Equals(value) ?? value is null);
         if (changing)
             InternalSource[key] = value;
         return changing;

source/Synchronized/TrackedListWrapper.cs

@@ -114,7 +114,7 @@ public bool Replace(T target, T replacement, bool throwIfNotFound = false)
     }
 }
 
-public class TrackedList<T> : TrackedListWrapper<T>
+public sealed class TrackedList<T> : TrackedListWrapper<T>
 {
     [ExcludeFromCodeCoverage]
     public TrackedList(int capacity, ModificationSynchronizer? sync = null)

source/Synchronized/TrackedOrderedDictionaryWrapper.cs

@@ -149,7 +149,7 @@ public TrackedOrderedDictionaryWrapper(IOrderedDictionary<TKey, TValue> dictiona
     }
 }
 
-public class TrackedOrderedDictionary<TKey, TValue>
+public sealed class TrackedOrderedDictionary<TKey, TValue>
     : TrackedOrderedDictionaryWrapper<TKey, TValue>
 {
 

testing/Open.Collections.Tests/Collections/LockSyncDictionaryTests.cs

@@ -1,16 +1,18 @@
 using Open.Collections.Synchronized;
 
 namespace Open.Collections.Tests.Collections;
-public class LockSyncDictionaryTests : BasicDictionaryTests<LockSynchronizedDictionaryWrapper<int, int>>
+public class LockSyncDictionaryTests
+    : BasicDictionaryTests<LockSynchronizedDictionary<int, int>>
 {
     public LockSyncDictionaryTests() : base(new())
     {
     }
 }
 
-public class LockSyncOrderedDictionaryTests : BasicDictionaryTests<LockSynchronizedDictionaryWrapper<int, int>>
+public class LockSyncOrderedDictionaryTests
+    : BasicDictionaryTests<LockSynchronizedDictionary<int, int>>
 {
-    public LockSyncOrderedDictionaryTests() : base(new(new OrderedDictionary<int, int>()))
+    public LockSyncOrderedDictionaryTests() : base(new())
     {
     }
 }

testing/Open.Collections.Tests/Collections/LockSyncLinkedListTests.cs

@@ -1,7 +1,8 @@
 using Open.Collections.Synchronized;
 
 namespace Open.Collections.Tests.Collections;
-public class LockSyncLinkedListTests : BasicLinkedListTests<LockSynchronizedLinkedList<int>>
+public class LockSyncLinkedListTests
+    : BasicLinkedListTests<LockSynchronizedLinkedList<int>>
 {
     public LockSyncLinkedListTests() : base(new())
     {