From a2cf5c0af24ca11a7ab73f6fb710a40a67998f48 Mon Sep 17 00:00:00 2001 From: jfishman1 Date: Thu, 29 Oct 2026 15:39:16 -0700 Subject: [PATCH] fix: align Firebase guidance with the documented google-services.json recommendation The skills told the agent that google-services.json is "NOT required" and called the OneSignal docs recommending it "a known bug." That text came from the July 31 vendor baseline (803f234), months before Android SDK 5.11.0 existed. It is no longer accurate. What changed upstream: on 5.11.0+, when the host app has its own default FirebaseApp whose sender ID and applicationId project number both match the sender configured in OneSignal, push registers through the customer's Firebase project instead of OneSignal's shared one. The docs now recommend google-services.json for all new Android integrations, and require it when firebase_messaging_installation_id_enabled is true in the merged manifest (a dependency such as Braze 43.0.0+ can set it through manifest merging). The agent's behavior barely changes: it still must not add the file, since it cannot produce one -- that comes from the customer's Firebase console -- and applying the Gradle plugin without a file to process fails the build. What changes is the framing, that the agent now tells the user the file is recommended rather than asserting it is unnecessary, and that it stops when the FID manifest flag is set. Skills updated: setup/android.md, setup/cross-platform.md (4 places), setup/SKILL.md, credentials/SKILL.md, credentials/api-uploaded-credentials.md, verify/SKILL.md, verify/platform-verification.md. references/platform-matrix.md is updated too because setup/android.md defers to it; leaving it would have made the two contradict. verify_integration.py: android_no_stray_google_services warned whenever google-services.json existed without other Firebase client usage -- exactly the state of a project that followed the docs, so it flagged correct setups. Replaced with android_google_services_plugin_without_file, which catches the real build-breaking case: the Google Services plugin applied with no file to process, which fails with "File google-services.json is missing." Raised from warn to error because it breaks the build. Touches setup/android.md in the Firebase section near the top of the file, away from the composite-login region changed in #85. Applied cleanly to the pre-#85 base, so the two should not conflict. Refs SDK-5427. --- references/platform-matrix.md | 2 +- scripts/verify_integration.py | 19 ++++++++++++------- skills/credentials/SKILL.md | 2 +- .../credentials/api-uploaded-credentials.md | 2 +- skills/setup/SKILL.md | 2 +- skills/setup/android.md | 13 +++++++++++-- skills/setup/cross-platform.md | 8 ++++---- skills/verify/SKILL.md | 2 +- skills/verify/platform-verification.md | 2 +- 9 files changed, 33 insertions(+), 19 deletions(-) diff --git a/references/platform-matrix.md b/references/platform-matrix.md index 59adc92..48f23d6 100644 --- a/references/platform-matrix.md +++ b/references/platform-matrix.md @@ -8,7 +8,7 @@ What the agent can do vs. what stays human, per platform. Verified against SDK r |---|---|---|---| | **Web** (most automatable) | `