fixed possible performance regression due to failure to cache compilation results

mikesamuel · mikesamuel · commit 0eb25464d5ba · 2017-05-15T12:35:49.000-04:00
diff --git a/src/main/java/org/owasp/html/HtmlPolicyBuilder.java b/src/main/java/org/owasp/html/HtmlPolicyBuilder.java
@@ -817,7 +817,9 @@ public String apply(String url) {
               elementName,
               elPolicy, attrs.build(), skipIfEmpty.contains(elementName)));
     }
-    return new CompiledState(globalAttrPolicies, policiesBuilder.build());
+    compiledState = new CompiledState(
+        globalAttrPolicies, policiesBuilder.build());
+    return compiledState;
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -817,7 +817,9 @@ public String apply(String url) {`
`817`	`817`	`elementName,`
`818`	`818`	`elPolicy, attrs.build(), skipIfEmpty.contains(elementName)));`
`819`	`819`	`}`
`820`		`- return new CompiledState(globalAttrPolicies, policiesBuilder.build());`
	`820`	`+ compiledState = new CompiledState(`
	`821`	`+ globalAttrPolicies, policiesBuilder.build());`
	`822`	`+ return compiledState;`
`821`	`823`	`}`
`822`	`824`
`823`	`825`	`/**`