Skip to content

Commit 6bc862a

Browse files
authored
Merge pull request #320 from itk-dev/feature/update-readme
Update README
2 parents f64cd24 + f1531f7 commit 6bc862a

3 files changed

Lines changed: 48 additions & 47 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ before starting to add changes. Use example [placed in the end of the page](#exa
1111

1212
## [Unreleased]
1313

14+
- [PR-320](https://github.com/OS2Forms/os2forms/pull/320)
15+
Update README.
1416
- [PR-301](https://github.com/OS2Forms/os2forms/pull/301)
1517
Add address information to Digital Post shipments to ensure "*fjernprint*"
1618
can be sent.

README.md

Lines changed: 45 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -2,42 +2,31 @@
22

33
## Install
44

5-
OS2Forms Drupal 8 module is available to download via composer.
5+
OS2Forms Drupal 10 module is available to download via composer.
66

77
```sh
88
composer require os2forms/os2forms
9-
drush en os2forms
9+
drush pm:install os2forms
1010
```
1111

1212
If you don't have Drupal installed on you server, you will to need install it first.
13-
Read more about [how to install drupal core](https://www.drupal.org/docs/8/install).
13+
Read more about [how to install drupal core](https://www.drupal.org/docs/getting-started/installing-drupal).
1414

15-
We are recommending to install drupal via composer by using
16-
[OS2Forms composer project](https://github.com/OS2Forms/composer-project).
17-
By this way you will get standalone project with OS2Forms module on board, plus
18-
all the other contrib modules you will probably need to configure OS2Forms to
19-
your specific demands.
20-
21-
```sh
22-
composer create-project os2forms/composer-project:8.x-dev some-dir --no-interaction
23-
```
24-
25-
To get more benefits on your Drupal project we are offering you to use
15+
To get more benefits on your Drupal project we recommend you use
2616
[OS2web](https://packagist.org/packages/os2web/os2web) as installation
27-
profile for Drupal. This profile is a part of OS2Forms composer project
28-
mentioned above.
17+
profile for Drupal.
2918

3019
You can easy download and install OS2web installation profile to your
3120
composer based Drupal project with commands:
3221

3322
```sh
3423
composer require os2web/os2web
35-
drush si os2web --db-url=mysql://db_user:db_pass@mysql_host/db_name --locale=da --site-name="OS2Forms" --account-pass=admin -y
24+
drush site:install os2web --db-url=mysql://db_user:db_pass@mysql_host/db_name --locale=da --site-name="OS2Forms" --account-pass=admin -y
3625
```
3726

3827
## Update
3928

40-
Updating process for OS2forms module is similar to usual Drupal 8 module.
29+
Updating process for OS2forms module is similar to usual Drupal 10 module.
4130
Use Composer's built-in command for listing packages that have updates available:
4231

4332
```sh
@@ -46,53 +35,62 @@ composer outdated os2forms/os2forms
4635

4736
## Automated testing and code quality
4837

49-
See [OS2Forms testing and CI information](https://github.com/OS2Forms/docs#testing-and-ci)
38+
See [OS2Forms testing and CI information](https://os2forms.github.io/os2forms-docs/for-developers.html#testing-and-ci)
5039

5140
## Contribution
5241

53-
OS2Forms project is opened for new features and os course bugfixes.
54-
If you have any suggestion or you found a bug in project, you are very welcome
55-
to create an issue in github repository issue tracker.
56-
For issue description there is expected that you will provide clear and
57-
sufficient information about your feature request or bug report.
42+
The OS2Forms project is open for new features and bugfixes. If you have any
43+
suggestion, or you found a bug in the project, you are very welcome to create
44+
an issue in github repository issue tracker. For issue description was ask
45+
that you will provide clear and sufficient information about your feature
46+
request or bug report.
5847

5948
### Code review policy
6049

61-
See [OS2Forms code review policy](https://github.com/OS2Forms/docs#code-review)
50+
See [OS2Forms code review policy](https://os2forms.github.io/os2forms-docs/for-developers.html#code-review)
6251

6352
### Git name convention
6453

65-
See [OS2Forms git name convention](https://github.com/OS2Forms/docs#git-guideline)
54+
See [OS2Forms git name convention](https://os2forms.github.io/os2forms-docs/for-developers.html#git-guideline)
6655

6756
## Important notes
6857

6958
### Webforms
7059

71-
Each webform, including all its settings, is stored as configuration in db and
72-
will(could) be exported as `yml` file via Drupal configuration management
73-
system. And afterwards could be tracked by `git`.
60+
Each webform, along with all its settings, is stored as configuration in the
61+
database and can be exported as a `yml` file through Drupal's configuration
62+
management system, making it trackable via `git`.
7463

75-
It means that all webform settings from drupal database will
76-
be syncronized (exported/imported) with state stored in `yml` files from
77-
configuration folder stored in git repository. Without proper actions webforms
78-
could be deleted or reverted to state in `yml` during synchronization.
64+
This means that webform settings in the Drupal database will be synchronized
65+
(exported/imported) with the state defined in `yml` files located in the
66+
configuration folder of your git repository. Without taking the appropriate
67+
precautions, webforms may be deleted or reverted to the state captured in
68+
those `yml` files during synchronization.
7969

80-
To avoid/prevent this behavior we recommend use `Config ignore` module, where
81-
you can add all settings you do not want to export/import via configuration
82-
management system.
70+
To prevent this, we recommend using the
71+
`Config ignore`-[module](https://www.drupal.org/project/config_ignore), which
72+
allows you to exclude specific settings from the configuration management
73+
export/import process.
8374

8475
### Serviceplatformen plugins
8576

86-
Settings for CPR and CVR serviceplantormen plugins are storing as configuration
87-
in db and will(could) be exported as `yml` file via Drupal configuration
88-
management system. And afterwards could be tracked by `git`.
77+
Similar to webforms, settings for the CPR and CVR Serviceplatformen plugins
78+
are stored as configuration in the database and can be exported as `yml` files
79+
through Drupal's configuration management system, making them trackable via
80+
`git`.
81+
82+
Note that if your git repository is publicly accessible, these plugin settings
83+
— which may contain sensitive information — will be exposed. As with webforms,
84+
we recommend using the `Config ignore`-module to exclude them from the
85+
export/import process.
8986

90-
If case you have public access to your git repository all setting from plugins
91-
will be exposed for third persons.
87+
### Other configuration
9288

93-
To avoid/prevent this behavior we recommend use `Config ignore` module, where
94-
you can add all settings you do not want to export/import via configuration
95-
management system.
89+
The two cases above are just some examples of configuration that may be
90+
sensitive or subject to unintended changes during synchronization. In general,
91+
any configuration that is environment-specific, contains sensitive data, or is
92+
managed directly in the database rather than through code should be considered
93+
for exclusion via the `Config ignore`-module.
9694

9795
## Unstable features
9896

@@ -148,11 +146,12 @@ docker compose run --rm markdownlint markdownlint '**/*.md'
148146

149147
We use [PHPStan](https://phpstan.org/) for static code analysis.
150148

151-
Running statis code analysis on a standalone Drupal module is a bit tricky, so we use a helper script to run the
149+
Running static code analysis on a standalone Drupal module is a bit tricky, so we use a helper script to run the
152150
analysis:
153151

154152
```shell
155153
docker compose run --rm php ./scripts/code-analysis
156154
```
157155

158-
**Note**: Currently the code analysis is only run on the `os2forms_digital_post` sub-module (cf. [`phpstan.neon`](./phpstan.neon)).
156+
**Note**: Currently the code analysis is only run on the `os2forms_digital_post` and `os2forms_fbs_handler` sub-modules
157+
(cf. [`phpstan.neon`](./phpstan.neon)).

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "os2forms/os2forms",
3-
"description": "Drupal 8 OS2Form module provides advanced webform functionality for Danish Municipalities",
3+
"description": "Drupal 10 OS2Form module provides advanced webform functionality for Danish Municipalities",
44
"license": "EUPL-1.2",
55
"type": "drupal-module",
66
"require": {

0 commit comments

Comments
 (0)