Testing issue: Excessive output from `PhasorDynamicsControllerRepcaTest`

[pelesh]

Failed test outputs or steps to reproduce the failure(s)

PhasorDynamicsControllerRepcaTest generates excessive output. See below. Perhaps We should reconsider how tests for failures are designed. So many warnings and error messages printed are confusing for a user.

Other tests should be reviewed, as well.

Details

test 48
      Start 48: PhasorDynamicsControllerRepcaTest

48: Test command: /Users/55y/src/gridkit/build-clang/tests/UnitTests/PhasorDynamics/test_phasor_controller_repca
48: Working Directory: /Users/55y/src/gridkit/build-clang/tests/UnitTests/PhasorDynamics
48: Test timeout computed to be: 1500
48: [MESSAGE] Testing REPCA defaults, parameter floors, and invalid configurations. Logged errors and warnings are expected.
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: ir signal is required
48: [ERROR] Repca: ii signal is required
48: [ERROR] Repca: p signal is required
48: [ERROR] Repca: q signal is required
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: ir signal is required
48: [ERROR] Repca: ii signal is required
48: [ERROR] Repca: p signal is required
48: [ERROR] Repca: q signal is required
48: [ERROR] Repca: mva must define a finite positive component power base
48: [ERROR] Repca: Tfv must be non-negative
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: dbdlow <= 0 <= dbdupper is required
48: [ERROR] Repca: dbdlow <= 0 <= dbdupper is required
48: [ERROR] Repca: emin <= 0 <= emax is required
48: [ERROR] Repca: emin <= 0 <= emax is required
48: [ERROR] Repca: Qmin must be less than or equal to Qmax
48: [ERROR] Repca: fdbd1 <= 0 <= fdbd2 is required
48: [ERROR] Repca: fdbd1 <= 0 <= fdbd2 is required
48: [ERROR] Repca: Ddn must be non-negative
48: [ERROR] Repca: Dup must be non-negative
48: [ERROR] Repca: femin <= 0 <= femax is required
48: [ERROR] Repca: femin <= 0 <= femax is required
48: [ERROR] Repca: Pmin must be less than or equal to Pmax
48: [ERROR] Repca: parameter 'mva' must be numeric
48: [ERROR] Repca: Tfltr must be non-negative
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: Tft must be non-negative
48: [ERROR] Repca: Tp must be non-negative
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: Tlag must be non-negative
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: parameter 'mva' must be finite
48: [ERROR] Repca: parameter 'mva' must be finite
48: [ERROR] Repca: parameter 'mva' must be finite
48: [ERROR] Repca: parameter 'Tfltr' must be finite
48: [ERROR] Repca: parameter 'Tfltr' must be finite
48: [ERROR] Repca: parameter 'Tfltr' must be finite
48: [ERROR] Repca: parameter 'Vfrz' must be finite
48: [ERROR] Repca: parameter 'Vfrz' must be finite
48: [ERROR] Repca: parameter 'Vfrz' must be finite
48: [ERROR] Repca: parameter 'Rc' must be finite
48: [ERROR] Repca: parameter 'Rc' must be finite
48: [ERROR] Repca: parameter 'Rc' must be finite
48: [ERROR] Repca: parameter 'Xc' must be finite
48: [ERROR] Repca: parameter 'Xc' must be finite
48: [ERROR] Repca: parameter 'Xc' must be finite
48: [ERROR] Repca: parameter 'Kc' must be finite
48: [ERROR] Repca: parameter 'Kc' must be finite
48: [ERROR] Repca: parameter 'Kc' must be finite
48: [ERROR] Repca: parameter 'dbdlow' must be finite
48: [ERROR] Repca: parameter 'dbdlow' must be finite
48: [ERROR] Repca: parameter 'dbdlow' must be finite
48: [ERROR] Repca: parameter 'dbdupper' must be finite
48: [ERROR] Repca: parameter 'dbdupper' must be finite
48: [ERROR] Repca: parameter 'dbdupper' must be finite
48: [ERROR] Repca: parameter 'emax' must be finite
48: [ERROR] Repca: parameter 'emax' must be finite
48: [ERROR] Repca: parameter 'emax' must be finite
48: [ERROR] Repca: parameter 'emin' must be finite
48: [ERROR] Repca: parameter 'emin' must be finite
48: [ERROR] Repca: parameter 'emin' must be finite
48: [ERROR] Repca: parameter 'Kp' must be finite
48: [ERROR] Repca: parameter 'Kp' must be finite
48: [ERROR] Repca: parameter 'Kp' must be finite
48: [ERROR] Repca: parameter 'Ki' must be finite
48: [ERROR] Repca: parameter 'Ki' must be finite
48: [ERROR] Repca: parameter 'Ki' must be finite
48: [ERROR] Repca: parameter 'Qmax' must be finite
48: [ERROR] Repca: parameter 'Qmax' must be finite
48: [ERROR] Repca: parameter 'Qmax' must be finite
48: [ERROR] Repca: parameter 'Qmin' must be finite
48: [ERROR] Repca: parameter 'Qmin' must be finite
48: [ERROR] Repca: parameter 'Qmin' must be finite
48: [ERROR] Repca: parameter 'Tft' must be finite
48: [ERROR] Repca: parameter 'Tft' must be finite
48: [ERROR] Repca: parameter 'Tft' must be finite
48: [ERROR] Repca: parameter 'Tfv' must be finite
48: [ERROR] Repca: parameter 'Tfv' must be finite
48: [ERROR] Repca: parameter 'Tfv' must be finite
48: [ERROR] Repca: parameter 'Tp' must be finite
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: parameter 'Tp' must be finite
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: parameter 'Tp' must be finite
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: parameter 'fdbd1' must be finite
48: [ERROR] Repca: parameter 'fdbd1' must be finite
48: [ERROR] Repca: parameter 'fdbd1' must be finite
48: [ERROR] Repca: parameter 'fdbd2' must be finite
48: [ERROR] Repca: parameter 'fdbd2' must be finite
48: [ERROR] Repca: parameter 'fdbd2' must be finite
48: [ERROR] Repca: parameter 'Ddn' must be finite
48: [ERROR] Repca: parameter 'Ddn' must be finite
48: [ERROR] Repca: parameter 'Ddn' must be finite
48: [ERROR] Repca: parameter 'Dup' must be finite
48: [ERROR] Repca: parameter 'Dup' must be finite
48: [ERROR] Repca: parameter 'Dup' must be finite
48: [ERROR] Repca: parameter 'femax' must be finite
48: [ERROR] Repca: parameter 'femax' must be finite
48: [ERROR] Repca: parameter 'femax' must be finite
48: [ERROR] Repca: parameter 'femin' must be finite
48: [ERROR] Repca: parameter 'femin' must be finite
48: [ERROR] Repca: parameter 'femin' must be finite
48: [ERROR] Repca: parameter 'Kpg' must be finite
48: [ERROR] Repca: parameter 'Kpg' must be finite
48: [ERROR] Repca: parameter 'Kpg' must be finite
48: [ERROR] Repca: parameter 'Kig' must be finite
48: [ERROR] Repca: parameter 'Kig' must be finite
48: [ERROR] Repca: parameter 'Kig' must be finite
48: [ERROR] Repca: parameter 'Pmax' must be finite
48: [ERROR] Repca: parameter 'Pmax' must be finite
48: [ERROR] Repca: parameter 'Pmax' must be finite
48: [ERROR] Repca: parameter 'Pmin' must be finite
48: [ERROR] Repca: parameter 'Pmin' must be finite
48: [ERROR] Repca: parameter 'Pmin' must be finite
48: [ERROR] Repca: parameter 'Tlag' must be finite
48: [ERROR] Repca: parameter 'Tlag' must be finite
48: [ERROR] Repca: parameter 'Tlag' must be finite
48: [ERROR] Repca: mva must define a finite positive component power base
48: [ERROR] Repca: system power base must be finite and positive
48: [ERROR] Repca: system/component power-base conversion ratios must be finite and positive
48: [ERROR] Repca: parameter 'VcompFlag' must be boolean
48: [ERROR] Repca: parameter 'VcompFlag' must be boolean
48: [ERROR] Repca: parameter 'VcompFlag' must be boolean
48: [ERROR] Repca: parameter 'VcompFlag' must be boolean
48: [ERROR] Repca: parameter 'VcompFlag' must be boolean
48: [ERROR] Repca: parameter 'VcompFlag' must be boolean
48: [ERROR] Repca: parameter 'VcompFlag' must be boolean
48: [ERROR] Repca: parameter 'VcompFlag' must be boolean
48: [ERROR] Repca: parameter 'RefFlag' must be boolean
48: [ERROR] Repca: parameter 'RefFlag' must be boolean
48: [ERROR] Repca: parameter 'RefFlag' must be boolean
48: [ERROR] Repca: parameter 'RefFlag' must be boolean
48: [ERROR] Repca: parameter 'RefFlag' must be boolean
48: [ERROR] Repca: parameter 'RefFlag' must be boolean
48: [ERROR] Repca: parameter 'RefFlag' must be boolean
48: [ERROR] Repca: parameter 'RefFlag' must be boolean
48: [ERROR] Repca: parameter 'Freqflag' must be boolean
48: [ERROR] Repca: parameter 'Freqflag' must be boolean
48: [ERROR] Repca: parameter 'Freqflag' must be boolean
48: [ERROR] Repca: parameter 'Freqflag' must be boolean
48: [ERROR] Repca: parameter 'Freqflag' must be boolean
48: [ERROR] Repca: parameter 'Freqflag' must be boolean
48: [ERROR] Repca: parameter 'Freqflag' must be boolean
48: [ERROR] Repca: parameter 'Freqflag' must be boolean
48: [ERROR] Repca: regulated bus is required
48: [ERROR] Repca: ir signal is required
48: [ERROR] Repca: ii signal is required
48: [ERROR] Repca: p signal is required
48: [ERROR] Repca: q signal is required
48: [ERROR] Repca: ir signal attached with no linked source
48: [ERROR] Repca: ii signal attached with no linked source
48: [ERROR] Repca: p signal attached with no linked source
48: [ERROR] Repca: q signal attached with no linked source
48: [ERROR] Repca: freq signal attached with no linked source
48: [ERROR] Repca: vref signal attached with no linked source
48: [ERROR] Repca: pref signal attached with no linked source
48: [ERROR] Repca: qref signal attached with no linked source
48: [ERROR] Repca: freqref signal attached with no linked source
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: --- PASS: Test validation
48: [MESSAGE] Testing REPCA initialization without an attached frequency signal. A warning is expected.
48: [WARNING] Repca: Freqflag is enabled without a freq signal; frequency remains nominal and cannot track bus-frequency deviations
48: --- PASS: Test initializationAndSignals
48: [MESSAGE] Testing REPCA adjusted limits and inadmissible initialization points. Logged warnings and errors are expected.
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: initial bus, signal, and command values must be finite
48: [ERROR] Repca: derived initial values must be finite
48: [ERROR] Repca: Tfv must be non-negative
48: [WARNING] Repca: Tfltr, Tfv, Tp, and Tlag below 0.001 s are raised to that floor to keep the controller lags well posed
48: [ERROR] Repca: cannot initialize with invalid configuration
48: [WARNING] Repca: initial reactive PI output is outside [Qmin, Qmax]; the limits are adjusted to include the initialized value
48: [WARNING] Repca: initial reactive PI output is outside [Qmin, Qmax]; the limits are adjusted to include the initialized value
48: [WARNING] Repca: initial active PI output is outside [Pmin, Pmax]; the limits are adjusted to include the initialized value
48: [WARNING] Repca: initial active PI output is outside [Pmin, Pmax]; the limits are adjusted to include the initialized value
48: [WARNING] Repca: initial active PI output is outside [Pmin, Pmax]; the limits are adjusted to include the initialized value
48: [WARNING] Repca: initial reactive PI output is outside [Qmin, Qmax]; the limits are adjusted to include the initialized value
48: [WARNING] Repca: initial active PI output is outside [Pmin, Pmax]; the limits are adjusted to include the initialized value
48: --- PASS: Test initializationDomain
48: --- PASS: Test residualEquations
48: --- PASS: Test reactiveControl
48: 

GridKit™ version

develop

System and environment details

All

Additional information

Instead of printing message giving heads up that warning/error messages are printed, the output should be turned off before the test and turned on again after the test.

[lukelowry]

Can we have better logger verbosity levels? The verbose output is very helpful during development because I can follow the test logic line by line and compare the output, which could really help with intramodel tests later. I dont want to turn it off-off but I agree its too much for standard tests

Edit: to clarify, I think we need more capable testing utils. I don't really know what is typical/possible. The tests are not very maintainable and were by far more difficult to make than the models themselves, partly because of how verbose the code is is