Skip to content

Commit 304d635

Browse files
committed
API updates part 1
1 parent a185c9e commit 304d635

1 file changed

Lines changed: 33 additions & 28 deletions

File tree

odmtools/odmservices/series_service.py

Lines changed: 33 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -124,31 +124,35 @@ def get_variables_by_site_code(self, site_code):
124124

125125
# Series Catalog methods
126126

127-
#
128-
# def get_series_by_site(self , site_id):
129-
# """
130-
#
131-
# :param site_id: int
132-
# :return: List[Series]
133-
# """
134-
# try:
135-
# selectedSeries = self._edit_session.query(Series).filter_by(site_id=site_id).order_by(Series.id).all()
136-
# return selectedSeries
137-
# except:
138-
# return None
139127

128+
def get_series_by_site(self , site_id):
129+
"""
130+
131+
:param site_id: int
132+
:return: List[Series]
133+
"""
134+
# try:
135+
# selectedSeries = self._edit_session.query(Series).filter_by(site_id=site_id).order_by(Series.id).all()
136+
# return selectedSeries
137+
# except:
138+
# return None
139+
140+
return self.read.getResult(type="site", ids = [site_id])[0]
141+
##TODO : check is this the right way to get the series??
142+
143+
144+
145+
146+
# Site methods
147+
def get_all_sites(self):
148+
"""
149+
150+
:return: List[Sites]
151+
"""
152+
#return self._edit_session.query(Site).order_by(Site.code).all()
153+
return self.read.getResults(type="site")
140154

141155

142-
#
143-
# # Site methods
144-
# def get_all_sites(self):
145-
# """
146-
#
147-
# :return: List[Sites]
148-
# """
149-
# return self._edit_session.query(Site).order_by(Site.code).all()
150-
#
151-
#
152156
#
153157
def get_site_by_id(self, site_id):
154158
"""
@@ -166,12 +170,13 @@ def get_site_by_id(self, site_id):
166170
#
167171

168172
#
169-
# def get_all_variables(self):
170-
# """
171-
#
172-
# :return: List[Variables]
173-
# """
174-
# return self._edit_session.query(Variable).all()
173+
def get_all_variables(self):
174+
"""
175+
176+
:return: List[Variables]
177+
"""
178+
#return self._edit_session.query(Variable).all()
179+
return self.read.getVariables()
175180
#
176181
def get_variable_by_id(self, variable_id):
177182
"""

0 commit comments

Comments
 (0)