Skip to content

Commit fb0f61c

Browse files
committed
Updated models. RelatedModels to use RelatedId, and Not RelationID. Relationship was reversed. getRelatedModelsByCode returned Parent models and not child models.
1 parent 2e85eba commit fb0f61c

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

odm2api/ODM2/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1024,7 +1024,7 @@ class RelatedModels(Base):
10241024
__tablename__ = 'relatedmodels'
10251025
__table_args__ = {u'schema': 'odm2'} # __table_args__ = {u'schema': Schema.getSchema()}
10261026

1027-
RelationID = Column('relationid', Integer, primary_key=True, nullable=False)
1027+
RelatedID = Column('relatedid', Integer, primary_key=True, nullable=False)
10281028
ModelID = Column('modelid', ForeignKey(Models.ModelID), nullable=False)
10291029
RelationshipTypeCV = Column('relationshiptypecv', ForeignKey(CVRelationshipType.Name), nullable=False,
10301030
index=True)

odm2api/ODM2/models_sqlite.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1016,7 +1016,7 @@ class RelatedModels(Base):
10161016
__tablename__ = 'relatedmodels'
10171017
# __table_args__ = {u'schema': 'odm2'} # # __table_args__ = {u'schema': Schema.getSchema()}
10181018

1019-
RelationID = Column('relationid', Integer, primary_key=True, nullable=False)
1019+
RelatedID = Column('relatedid', Integer, primary_key=True, nullable=False)
10201020
ModelID = Column('modelid', ForeignKey(Models.ModelID), nullable=False)
10211021
RelationshipTypeCV = Column('relationshiptypecv', ForeignKey(CVRelationshipType.Name), nullable=False,
10221022
index=True)

odm2api/ODM2/services/readService.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -944,7 +944,8 @@ def getRelatedModelsByID(self, modelid):
944944
:return: all models related to the specified id
945945
"""
946946
try:
947-
return self._session.query(RelatedModels).filter_by(RelatedModelID=modelid).all()
947+
# note this was RelatedModelID = modelid which would return all Parent models of RelatedModelID
948+
return self._session.query(RelatedModels).filter_by(ModelID=modelid).all()
948949
except Exception, e:
949950
print e
950951
return None
@@ -956,7 +957,8 @@ def getRelatedModelsByCode(self, modelcode):
956957
:return: all models related to the provided model code
957958
"""
958959
try:
959-
return self._session.query(RelatedModels).join(Models, RelatedModels.RelatedModelID == Models.ModelID) \
960+
# note this was RelatedModels.RelatedModelID == Models.ModelID which would return all Parent models of RelatedModelID
961+
return self._session.query(RelatedModels).join(Models, RelatedModels.ModelID == Models.ModelID) \
960962
.filter(Models.ModelCode == modelcode).all()
961963
except Exception, e:
962964
print e

0 commit comments

Comments
 (0)