Skip to content

Commit 17a9e31

Browse files
author
stephanie
committed
update detailed result obj
1 parent e0c274c commit 17a9e31

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

odm2api/ODM2/services/readService.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def getDetailedAffiliationInfo(self):
178178
affiliationList.append(detailedAffiliation)
179179
return affiliationList
180180

181-
def getDetailedResultInfo(self, resultTypeCV=None, resultID=None):
181+
def getDetailedResultInfo(self, resultTypeCV=None, resultID=None, sfID=None):
182182
q = self._session.query(Actions, Results, SamplingFeatures.SamplingFeatureCode, SamplingFeatures.SamplingFeatureName, Methods, Variables,
183183
ProcessingLevels, Units).filter(Results.VariableID == Variables.VariableID) \
184184
.filter(Results.UnitsID == Units.UnitsID) \
@@ -190,16 +190,15 @@ def getDetailedResultInfo(self, resultTypeCV=None, resultID=None):
190190
.filter(Results.ResultTypeCV == resultTypeCV) \
191191
.order_by(Results.ResultID)
192192
resultList = []
193+
if sfID:
194+
q= q.filter(SamplingFeatures.SamplingFeatureID == sfID)
193195
if resultID:
194-
for a, r, sc, sn, m, v, p, u in q.filter_by(ResultID=resultID).all():
195-
detailedResult = DetailedResult( \
196-
a, r, sc, sn, m, v, p, u)
197-
resultList.append(detailedResult)
198-
else:
199-
for a, r, sc, sn, m, v, p, u in q.all():
200-
detailedResult = DetailedResult( \
201-
a, r, sc, sn, m, v, p, u)
202-
resultList.append(detailedResult)
196+
q= q.q.filter_by(ResultID=resultID)
197+
198+
for a, r, sc, sn, m, v, p, u in q.all():
199+
detailedResult = DetailedResult( \
200+
a, r, sc, sn, m, v, p, u)
201+
resultList.append(detailedResult)
203202
return resultList
204203

205204
"""

odm2api/ODMconnection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def __init__(self, connection_string, echo=True, version = 2.0):
2828
self.test_engine = create_engine(connection_string, encoding='utf-8', echo=echo, pool_recycle=3600, pool_timeout=5, max_overflow=0, connect_args={'connect_timeout': 1})
2929

3030
# Create session maker
31-
self.Session = sessionmaker(bind=self.engine)
31+
self.Session = sessionmaker(bind=self.engine, autoflush=True)
3232
self.test_Session = sessionmaker(bind=self.test_engine)
3333
setSchema(self.engine)
3434
self.version=version

odm2api/base.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ def __init__(self, session_factory, debug=False):
2323
self._session = self._session_factory.getSession()
2424
self._version = session_factory.version
2525
self._debug = debug
26+
2627
#self._sessiona
2728

2829
#self._session_factory=""

0 commit comments

Comments
 (0)