[MIG] attachment_preview: Migration to 19.0

Author: gregory-rutecki

attachment_preview/__manifest__.py

@@ -3,8 +3,8 @@
 
 {
     "name": "Preview attachments",
-    "version": "18.0.1.0.0",
-    "author": "Therp BV," "Onestein," "Odoo Community Association (OCA)",
+    "version": "19.0.1.0.0",
+    "author": "Therp BV,Onestein,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/knowledge",
     "license": "AGPL-3",
     "summary": "Preview attachments supported by Viewer.js",

attachment_preview/models/ir_attachment.py

@@ -76,12 +76,13 @@ def get_binary_extension(self, model, ids, binary_field, filename_field=None):
     def get_attachment_extension(self, ids):
         return self.get_binary_extension(self._name, ids, "datas", "name")
 
-    def _to_store(self, store: Store, /, *, fields=None, extra_fields=None):
-        """Adds extension in Store for attachments"""
-        res = super()._to_store(store=store, fields=fields, extra_fields=extra_fields)
-        attachment_extension = self.get_attachment_extension(self.ids)
-        for attachment in store.data.get("ir.attachment"):
-            store.data["ir.attachment"][attachment]["extension"] = (
-                attachment_extension.get(attachment[0], "")
+    def _to_store_defaults(self, target):
+        """Adds extension in Store defaults for attachments"""
+        defaults = super()._to_store_defaults(target)
+        defaults.append(
+            Store.Attr(
+                "extension",
+                lambda a: a.get_attachment_extension(a.id),
             )
-        return res
+        )
+        return defaults

attachment_preview/static/src/js/attachmentPreviewWidget.esm.js

@@ -35,7 +35,6 @@ export class AttachmentPreviewWidget extends Component {
 
     _onPopoutClick() {
         if (!this.attachments[this.state.activeIndex]) return;
-        // eslint-disable-next-line no-undef
         window.open(this.attachments[this.state.activeIndex].previewUrl);
     }
 

attachment_preview/static/src/js/mail_core/attachment_list.esm.js

@@ -4,7 +4,6 @@ import {patch} from "@web/core/utils/patch";
 
 patch(AttachmentList.prototype, {
     _onPreviewAttachment(attachment) {
-        // eslint-disable-next-line no-undef
         var $target = $(event.currentTarget);
         var split_screen = $target.attr("data-target") !== "new";
         showPreview(

attachment_preview/static/src/js/utils.esm.js

@@ -25,11 +25,9 @@ export function getUrl(
     var url = "";
     if (attachment_url) {
         if (attachment_url.slice(0, 21) === "/web/static/lib/pdfjs") {
-            // eslint-disable-next-line no-undef
             url = (window.location.origin || "") + attachment_url;
         } else {
             url =
-                // eslint-disable-next-line no-undef
                 (window.location.origin || "") +
                 "/attachment_preview/static/lib/ViewerJS/index.html" +
                 "?type=" +
@@ -38,13 +36,11 @@ export function getUrl(
                 encodeURIComponent(attachment_title) +
                 "&zoom=automatic" +
                 "#" +
-                // eslint-disable-next-line no-undef
                 attachment_url.replace(window.location.origin, "");
         }
         return url;
     }
     url =
-        // eslint-disable-next-line no-undef
         (window.location.origin || "") +
         "/attachment_preview/static/lib/ViewerJS/index.html" +
         "?type=" +
@@ -74,7 +70,6 @@ export function showPreview(
             attachment_info_list,
         });
     } else {
-        // eslint-disable-next-line no-undef
         window.open(
             getUrl(
                 attachment_id,

attachment_preview/static/src/js/viewerjs_tweaks.js

@@ -5,13 +5,11 @@
 // OpenERP's context
 (function (original_Viewer) {
     "use strict";
-    // eslint-disable-next-line no-undef
     window.Viewer = function (plugin, parameters) {
         if (!plugin) {
-            // eslint-disable-next-line no-undef, no-alert
+            // eslint-disable-next-line no-alert
             alert("Unsupported file type");
         }
         return original_Viewer(plugin, parameters);
     };
-    // eslint-disable-next-line no-undef
 })(window.Viewer);

attachment_preview/static/src/scss/attachment_preview.scss

@@ -5,7 +5,7 @@
     background-color: #fff;
     border-left: 1px solid $gray-800;
 }
-@include media-breakpoint-up(xxl, $o-extra-grid-breakpoints) {
+@include media-breakpoint-up(xxl) {
     .attachment_preview_widget {
         position: absolute;
         left: 65.3%;
@@ -20,7 +20,7 @@
         border-left: 1px solid $gray-800;
     }
 }
-@include media-breakpoint-down(xxl, $o-extra-grid-breakpoints) {
+@include media-breakpoint-down(xxl) {
     .attachment_preview_iframe {
         width: 100%;
     }

attachment_preview/tests/test_attachment_preview.py

@@ -30,7 +30,7 @@ def test_get_extension(self):
         res = self.env["ir.attachment"].get_attachment_extension(attachment.id)
         self.assertEqual(res, "txt")
         store = Store()
-        attachment._to_store(store)
+        store.add(attachment)
         store_data = store.get_result()
         self.assertIn("extension", store_data["ir.attachment"][0])
         res = self.env["ir.attachment"].get_attachment_extension(

setup/attachment_preview/pyproject.toml

@@ -0,0 +1,7 @@
+[project]
+name = "odoo-addon-attachment_preview"
+dynamic = ["version"]
+
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"