#4087 check error before loading indicator

Author: chpy04

src/frontend/src/pages/GuestDivisionPage/GuestTeamPage.tsx

@@ -21,9 +21,9 @@ const GuestTeamPage: React.FC<GuestTeamPageProps> = ({ teamTypeId }) => {
     error: teamTypesError
   } = useAllTeamTypes();
 
-  if (teamsIsLoading || !allTeams || teamTypesIsLoading || !allTeamTypes) return <LoadingIndicator />;
   if (teamsIsError) return <ErrorPage message={teamsError.message} />;
   if (teamTypesIsError) return <ErrorPage message={teamTypesError.message} />;
+  if (teamsIsLoading || !allTeams || teamTypesIsLoading || !allTeamTypes) return <LoadingIndicator />;
 
   const teams = allTeams.filter((team) => team.teamType?.teamTypeId === teamTypeId);
   const teamTypeName = allTeamTypes.find((tt) => tt.teamTypeId === teamTypeId)?.name ?? '';

src/frontend/src/pages/TeamsPage/Teams.tsx

@@ -20,8 +20,8 @@ const TeamOrDivisionPage: React.FC = () => {
   const user = useCurrentUser();
   const { isLoading: teamsLoading, isError: isTeamsError, data: teamTypes, error: teamsError } = useAllTeamTypes();
 
-  if (teamsLoading || !teamTypes) return <LoadingIndicator />;
   if (isTeamsError) return <ErrorPage message={teamsError.message} />;
+  if (teamsLoading || !teamTypes) return <LoadingIndicator />;
 
   if (isGuest(user.role) && teamTypes?.some((t) => t.teamTypeId === teamId)) {
     return <GuestTeamPage teamTypeId={teamId} />;