Skip to content

Commit e7dd005

Browse files
committed
only include teamtype name and id in all team query args
1 parent e874f4d commit e7dd005

3 files changed

Lines changed: 9 additions & 14 deletions

File tree

src/backend/src/prisma-query-args/teams.query-args.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,7 @@ export const getTeamQueryArgs = (organizationId: string) =>
1313
head: getUserQueryArgs(organizationId),
1414
leads: getUserQueryArgs(organizationId),
1515
userArchived: getUserQueryArgs(organizationId),
16-
teamType: {
17-
select: {
18-
name: true
19-
}
20-
},
16+
teamType: { select: { teamTypeId: true, name: true } },
2117
projects: {
2218
where: {
2319
wbsElement: {
@@ -44,9 +40,7 @@ export const getTeamPreviewQueryArgs = (organizationId: string) =>
4440
head: getUserQueryArgs(organizationId),
4541
leads: getUserQueryArgs(organizationId),
4642
teamType: {
47-
select: {
48-
name: true
49-
}
43+
select: { teamTypeId: true, name: true }
5044
}
5145
}
5246
});

src/backend/src/transformers/teams.transformer.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { Prisma } from '@prisma/client';
22
import { Team, TeamPreview, TeamBase } from 'shared';
33
import { getTeamBaseQueryArgs, TeamPreviewQueryArgs, TeamQueryArgs } from '../prisma-query-args/teams.query-args.js';
44
import { userTransformer } from './user.transformer.js';
5-
import { teamTypeTransformer } from './team-types.transformer.js';
65
import { projectGanttTransformer } from './projects.transformer.js';
76

87
const teamTransformer = (team: Prisma.TeamGetPayload<TeamQueryArgs>): Team => {
@@ -17,7 +16,7 @@ const teamTransformer = (team: Prisma.TeamGetPayload<TeamQueryArgs>): Team => {
1716
leads: team.leads.map(userTransformer),
1817
userArchived: team.userArchived ? userTransformer(team.userArchived) : undefined,
1918
dateArchived: team.dateArchived ?? undefined,
20-
teamType: team.teamType ? teamTypeTransformer(team.teamType) : undefined
19+
teamType: team.teamType ?? undefined
2120
};
2221
};
2322

@@ -28,7 +27,7 @@ export const teamBaseTransformer = (team: Prisma.TeamGetPayload<ReturnType<typeo
2827
slackId: team.slackId,
2928
description: team.description,
3029
dateArchived: team.dateArchived ?? undefined,
31-
teamType: team.teamType ? teamTypeTransformer(team.teamType) : undefined
30+
teamType: team.teamType ?? undefined
3231
};
3332
};
3433

@@ -39,7 +38,7 @@ export const teamPreviewTransformer = (team: Prisma.TeamGetPayload<TeamPreviewQu
3938
members: team.members.map(userTransformer),
4039
head: userTransformer(team.head),
4140
dateArchived: team.dateArchived ?? undefined,
42-
teamType: team.teamType ? teamTypeTransformer(team.teamType) : undefined
41+
teamType: team.teamType ?? undefined
4342
};
4443
};
4544

src/shared/src/types/team-types.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* See the LICENSE file in the repository root folder for details.
44
*/
55

6-
import { TeamType } from './calendar-types.js';
76
import { ProjectGantt } from './project-types.js';
87
import { User } from './user-types.js';
98

@@ -13,7 +12,10 @@ export interface TeamBase {
1312
slackId: string;
1413
description: string;
1514
dateArchived?: Date;
16-
teamType?: TeamType;
15+
teamType?: {
16+
teamTypeId: string;
17+
name: string;
18+
};
1719
}
1820

1921
export interface TeamPreview extends TeamBase {

0 commit comments

Comments
 (0)