Skip to content

Commit d0f9a51

Browse files
committed
changes from review
1 parent cde701c commit d0f9a51

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

src/backend/src/services/finance.services.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export default class FinanceServices {
5757
* @param contactPosition The position of the sponsor contact.
5858
* @param sponsorTasks An array of sponsor tasks associated with the sponsor.
5959
* @param organization The organization for which the sponsor is being created.
60-
*
60+
* @param logoImage An optional logo image file for the sponsor.
6161
* @returns The created sponsor object, including associated tasks.
6262
*
6363
* @throws AccessDeniedAdminOnlyException If the submitter does not have permission to create a sponsor.
@@ -109,9 +109,6 @@ export default class FinanceServices {
109109
let logoImageId: string | undefined;
110110
if (logoImage) {
111111
const logoImageData = await uploadFile(logoImage);
112-
if (!logoImageData?.id || !logoImageData?.name) {
113-
throw new HttpException(500, 'Sponsor logo upload failed');
114-
}
115112
logoImageId = logoImageData.id;
116113
}
117114

@@ -1212,6 +1209,8 @@ export default class FinanceServices {
12121209
* @param contactPosition The position of the sponsor contact.
12131210
* @param sponsorTasks An array of sponsor tasks associated with the sponsor.
12141211
* @param organization The organization for which the sponsor is being edited.
1212+
* @param logoImage An optional logo image file for the sponsor.
1213+
*
12151214
* @returns the edited sponsor.
12161215
*/
12171216

@@ -1337,9 +1336,6 @@ export default class FinanceServices {
13371336
let logoImageId: string | undefined;
13381337
if (logoImage) {
13391338
const logoImageData = await uploadFile(logoImage);
1340-
if (!logoImageData?.id || !logoImageData?.name) {
1341-
throw new HttpException(500, 'Sponsor logo upload failed');
1342-
}
13431339
logoImageId = logoImageData.id;
13441340
}
13451341

0 commit comments

Comments
 (0)