#4148: removed createdId parameter

Author: jasperpinkus

src/backend/src/controllers/recruitment.controllers.ts

@@ -118,12 +118,11 @@ export default class RecruitmentController {
 
   static async getGuestDefinition(req: Request, res: Response, next: NextFunction) {
     try {
-      const { userCreatedId, organizationId, definitionId } = req.params as {
-        userCreatedId: string;
-        organizationId: string;
-        definitionId: string;
-      };
-      const definition = await RecruitmentServices.getGuestDefinition(userCreatedId, organizationId, definitionId);
+      console.log({ organizationId: req.organization.organizationId, definitionId: req.params.definitionId as string });
+      const definition = await RecruitmentServices.getGuestDefinition(
+        req.organization.organizationId,
+        req.params.definitionId as string
+      );
       res.status(200).json(definition);
     } catch (error: unknown) {
       next(error);

src/backend/src/routes/recruitment.routes.ts

@@ -62,6 +62,6 @@ recruitmentRouter.post(
   RecruitmentController.createGuestDefinition
 );
 
-recruitmentRouter.get('/guestDefinition/:id', RecruitmentController.getGuestDefinition);
+recruitmentRouter.get('/guestDefinition/:definitionId', RecruitmentController.getGuestDefinition);
 
 export default recruitmentRouter;

src/backend/src/services/recruitment.services.ts

@@ -256,23 +256,18 @@ export default class RecruitmentServices {
 
   /**
    * Gets a single guest defenition with the given user, organization, and definition ids
-   * @param userCreatedId the id of guest to retrieve
    * @param organizationId the organization the user is currently in
    * @param definitionId the id of the specific defenition being found
    * @returns a definition
    * @throws if the defenition is not found in the db
    */
-  static async getGuestDefinition(
-    userCreatedId: string,
-    organizationId: string,
-    definitionId: string
-  ): Promise<Guest_Definition> {
-    const guest = await prisma.guest_Definition.findFirst({
-      where: { userCreatedId, organizationId, definitionId }
+  static async getGuestDefinition(organizationId: string, definitionId: string): Promise<Guest_Definition> {
+    const guest = await prisma.guest_Definition.findUnique({
+      where: { organizationId, definitionId }
     });
 
     if (!guest) {
-      throw new NotFoundException('User', userCreatedId);
+      throw new NotFoundException('Guest Defenition', definitionId);
     }
 
     return guest;

src/backend/src/utils/errors.utils.ts

@@ -212,4 +212,5 @@ export type ExceptionObjectNames =
   | 'Event'
   | 'Schedule Slot'
   | 'ProspectiveSponsor'
-  | 'SponsorTier';
+  | 'SponsorTier'
+  | 'Guest Defenition';