Skip to content

Commit be417a9

Browse files
authored
Merge pull request #3809 from Northeastern-Electric-Racing/dr-scheduling-dm-failure
don't throw on users just bc of wrong slack id
2 parents 367d8bc + 847f04c commit be417a9

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/backend/src/services/design-reviews.services.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,10 @@ export default class DesignReviewsService {
207207
}
208208
} catch (err: unknown) {
209209
if (err instanceof Error) {
210-
throw new HttpException(500, `Failed to send slack notification: ${err.message}`);
210+
if (!err.message.includes('channel_not_found') && !err.message.includes('is_archived')) {
211+
// don't throw if slack id not found because sometimes users put the wrong slack id in or leave workspace
212+
throw new HttpException(500, `Failed to send slack notification: ${err.message}`);
213+
}
211214
}
212215
}
213216
}

0 commit comments

Comments
 (0)