linting and tests fix

Author: chpy04

src/backend/tests/unit/users.test.ts

@@ -72,7 +72,7 @@ describe('User Tests', () => {
 
       await expect(
         async () => await UsersService.updateUserRole(guest.userId, leadership, RoleEnum.HEAD, organization)
-      ).rejects.toThrow(new AccessDeniedException('Guests, members, and leadership cannot update user roles!'));
+      ).rejects.toThrow(new AccessDeniedException('Cannot promote someone to your own role or higher'));
     });
 
     it('prevents leadership from promoting member to higher role', async () => {
@@ -81,7 +81,7 @@ describe('User Tests', () => {
 
       await expect(
         async () => await UsersService.updateUserRole(memberUser.userId, leadership, RoleEnum.HEAD, organization)
-      ).rejects.toThrow(new AccessDeniedException('Guests, members, and leadership cannot update user roles!'));
+      ).rejects.toThrow(new AccessDeniedException('Cannot promote someone to your own role or higher'));
     });
 
     it('allows head to promote guest to member (existing functionality)', async () => {
@@ -107,7 +107,7 @@ describe('User Tests', () => {
 
       await expect(
         async () => await UsersService.updateUserRole(guest2.userId, guest1, RoleEnum.MEMBER, organization)
-      ).rejects.toThrow(new AccessDeniedException('Guests, members, and leadership cannot update user roles!'));
+      ).rejects.toThrow(new AccessDeniedException('Guests and members cannot update user roles!'));
     });
 
     it('prevents member from updating any user role', async () => {
@@ -116,7 +116,7 @@ describe('User Tests', () => {
 
       await expect(
         async () => await UsersService.updateUserRole(guest.userId, memberUser, RoleEnum.MEMBER, organization)
-      ).rejects.toThrow(new AccessDeniedException('Guests, members, and leadership cannot update user roles!'));
+      ).rejects.toThrow(new AccessDeniedException('Guests and members cannot update user roles!'));
     });
   });
 });

src/frontend/src/pages/AdminToolsPage/AdminToolsUserManagement.tsx

@@ -12,7 +12,7 @@ import { useAllUsers, useCurrentUser, useUpdateUserRole } from '../../hooks/user
 import LoadingIndicator from '../../components/LoadingIndicator';
 import ErrorPage from '../ErrorPage';
 import { fullNamePipe } from '../../utils/pipes';
-import { RoleEnum, User, isAdmin, isLeadership, rankUserRole } from 'shared';
+import { RoleEnum, User, rankUserRole } from 'shared';
 import NERAutocomplete from '../../components/NERAutocomplete';
 import { useToast } from '../../hooks/toasts.hooks';
 

src/frontend/src/pages/AdminToolsPage/ScheduleConfig/Machinery/EditMachineryModal.tsx

@@ -34,7 +34,6 @@ const EditMachineryModal = ({ open, onClose, machinery }: EditMachineryModalProp
       currentMachineryId = updatedMachinery.machineryId;
     }
 
-    const originalShopIds = new Set(originalShops.map((sm) => sm.shop.shopId));
     const newShopIds = new Set(shopEntries.map((e) => e.shopId));
 
     // Remove shops that were removed from the form