Skip to content

Commit a8e16bb

Browse files
authored
Merge pull request #3753 from Northeastern-Electric-Racing/#3752-task-creator-can-delete-own-tasks
#3752: task creators can now delete their own tasks regardless of role
2 parents 5f57a68 + 446efb3 commit a8e16bb

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

src/backend/src/services/tasks.services.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,11 @@ export default class TasksService {
266266

267267
// this checks the current users permissions
268268
const isLead = wbsElement.leadId === currentUser.userId || wbsElement.managerId === currentUser.userId;
269-
if (!(await userHasPermission(currentUser.userId, organization.organizationId, isAdmin)) && !isLead) {
270-
throw new AccessDeniedException('Only admin, app-admins, project leads, and project managers can delete tasks');
269+
const isCreator = task.createdByUserId === currentUser.userId;
270+
if (!(await userHasPermission(currentUser.userId, organization.organizationId, isAdmin)) && !isLead && !isCreator) {
271+
throw new AccessDeniedException(
272+
'Only admin, app-admins, project leads, project managers, and the task creator can delete tasks'
273+
);
271274
}
272275

273276
const deletedTask = await prisma.task.update({

0 commit comments

Comments
 (0)