Skip to content

Commit a3c7f0f

Browse files
committed
#3494 updated tests
1 parent 57b373c commit a3c7f0f

1 file changed

Lines changed: 61 additions & 65 deletions

File tree

src/backend/tests/unit/change-requests.test.ts

Lines changed: 61 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,16 @@ describe('Change Request Tests', () => {
1414
organization = await createTestOrganization();
1515
orgId = organization.organizationId;
1616
user = await createTestUser(supermanAdmin, orgId);
17+
await prisma.wBS_Element.create({
18+
data: {
19+
carNumber: 12,
20+
projectNumber: 13,
21+
workPackageNumber: 14,
22+
name: 'test wbs',
23+
organizationId: orgId,
24+
status: WBS_Element_Status.INACTIVE
25+
}
26+
});
1727
});
1828

1929
afterEach(async () => {
@@ -22,20 +32,6 @@ describe('Change Request Tests', () => {
2232

2333
describe('Create Change Request', () => {
2434
it('create change request on an inactive project - project changes', async () => {
25-
await prisma.wBS_Element.update({
26-
where: {
27-
wbsNumber: {
28-
carNumber: 0,
29-
projectNumber: 1,
30-
workPackageNumber: 0,
31-
organizationId: organization.organizationId
32-
}
33-
},
34-
data: {
35-
status: WBS_Element_Status.INACTIVE
36-
}
37-
});
38-
3935
const projPropChanges: ProjectProposedChangesCreateArgs = {
4036
name: 'Project name changes',
4137
descriptionBullets: [],
@@ -48,9 +44,9 @@ describe('Change Request Tests', () => {
4844

4945
const cr = await ChangeRequestsService.createStandardChangeRequest(
5046
user,
51-
0,
52-
1,
53-
0,
47+
12,
48+
13,
49+
14,
5450
CR_Type.DEFINITION_CHANGE,
5551
'What',
5652
[
@@ -66,9 +62,9 @@ describe('Change Request Tests', () => {
6662
);
6763

6864
expect(cr.submitter.userId).toEqual(user.userId);
69-
expect(cr.wbsNum?.carNumber).toEqual(0);
70-
expect(cr.wbsNum?.projectNumber).toEqual(1);
71-
expect(cr.wbsNum?.workPackageNumber).toEqual(0);
65+
expect(cr.wbsNum?.carNumber).toEqual(12);
66+
expect(cr.wbsNum?.projectNumber).toEqual(13);
67+
expect(cr.wbsNum?.workPackageNumber).toEqual(14);
7268

7369
expect(cr.type).toEqual(CR_Type.DEFINITION_CHANGE);
7470
expect(cr.what).toEqual('What');
@@ -80,26 +76,26 @@ describe('Change Request Tests', () => {
8076
const wbsElement = await prisma.wBS_Element.findUnique({
8177
where: {
8278
wbsNumber: {
83-
carNumber: 0,
84-
projectNumber: 1,
85-
workPackageNumber: 0,
79+
carNumber: 12,
80+
projectNumber: 13,
81+
workPackageNumber: 14,
8682
organizationId: organization.organizationId
8783
}
8884
}
8985
});
9086

9187
expect(wbsElement?.status).toEqual(WBS_Element_Status.INACTIVE);
92-
expect(wbsElement?.carNumber).toEqual(0);
93-
expect(wbsElement?.projectNumber).toEqual(1);
94-
expect(wbsElement?.workPackageNumber).toEqual(0);
88+
expect(wbsElement?.carNumber).toEqual(12);
89+
expect(wbsElement?.projectNumber).toEqual(13);
90+
expect(wbsElement?.workPackageNumber).toEqual(14);
9591
});
9692
it('create change request does not make active project inactive - project changes', async () => {
9793
await prisma.wBS_Element.update({
9894
where: {
9995
wbsNumber: {
100-
carNumber: 0,
101-
projectNumber: 1,
102-
workPackageNumber: 0,
96+
carNumber: 12,
97+
projectNumber: 13,
98+
workPackageNumber: 14,
10399
organizationId: organization.organizationId
104100
}
105101
},
@@ -121,9 +117,9 @@ describe('Change Request Tests', () => {
121117

122118
await ChangeRequestsService.createStandardChangeRequest(
123119
user,
124-
0,
125-
1,
126-
0,
120+
12,
121+
13,
122+
14,
127123
CR_Type.DEFINITION_CHANGE,
128124
'What',
129125
[
@@ -141,26 +137,26 @@ describe('Change Request Tests', () => {
141137
const wbsElement = await prisma.wBS_Element.findUnique({
142138
where: {
143139
wbsNumber: {
144-
carNumber: 0,
145-
projectNumber: 1,
146-
workPackageNumber: 0,
140+
carNumber: 12,
141+
projectNumber: 13,
142+
workPackageNumber: 14,
147143
organizationId: organization.organizationId
148144
}
149145
}
150146
});
151147

152148
expect(wbsElement?.status).toEqual(WBS_Element_Status.ACTIVE);
153-
expect(wbsElement?.carNumber).toEqual(0);
154-
expect(wbsElement?.projectNumber).toEqual(1);
155-
expect(wbsElement?.workPackageNumber).toEqual(0);
149+
expect(wbsElement?.carNumber).toEqual(12);
150+
expect(wbsElement?.projectNumber).toEqual(13);
151+
expect(wbsElement?.workPackageNumber).toEqual(14);
156152
});
157153
it('create change request does not make active project inactive - work package changes', async () => {
158154
await prisma.wBS_Element.update({
159155
where: {
160156
wbsNumber: {
161-
carNumber: 0,
162-
projectNumber: 1,
163-
workPackageNumber: 0,
157+
carNumber: 12,
158+
projectNumber: 13,
159+
workPackageNumber: 14,
164160
organizationId: organization.organizationId
165161
}
166162
},
@@ -182,9 +178,9 @@ describe('Change Request Tests', () => {
182178

183179
const cr = await ChangeRequestsService.createStandardChangeRequest(
184180
user,
185-
0,
186-
1,
187-
0,
181+
12,
182+
13,
183+
14,
188184
CR_Type.DEFINITION_CHANGE,
189185
'What',
190186
[
@@ -202,17 +198,17 @@ describe('Change Request Tests', () => {
202198
const wbsElement = await prisma.wBS_Element.findUnique({
203199
where: {
204200
wbsNumber: {
205-
carNumber: 0,
206-
projectNumber: 1,
207-
workPackageNumber: 0,
201+
carNumber: 12,
202+
projectNumber: 13,
203+
workPackageNumber: 14,
208204
organizationId: organization.organizationId
209205
}
210206
}
211207
});
212208
expect(cr.submitter.userId).toEqual(user.userId);
213-
expect(cr.wbsNum?.carNumber).toEqual(0);
214-
expect(cr.wbsNum?.projectNumber).toEqual(1);
215-
expect(cr.wbsNum?.workPackageNumber).toEqual(0);
209+
expect(cr.wbsNum?.carNumber).toEqual(12);
210+
expect(cr.wbsNum?.projectNumber).toEqual(13);
211+
expect(cr.wbsNum?.workPackageNumber).toEqual(14);
216212

217213
expect(cr.type).toEqual(CR_Type.DEFINITION_CHANGE);
218214
expect(cr.what).toEqual('What');
@@ -222,17 +218,17 @@ describe('Change Request Tests', () => {
222218
expect(cr.wbsNum).not.toBeNull();
223219

224220
expect(wbsElement?.status).toEqual(WBS_Element_Status.ACTIVE);
225-
expect(wbsElement?.carNumber).toEqual(0);
226-
expect(wbsElement?.projectNumber).toEqual(1);
227-
expect(wbsElement?.workPackageNumber).toEqual(0);
221+
expect(wbsElement?.carNumber).toEqual(12);
222+
expect(wbsElement?.projectNumber).toEqual(13);
223+
expect(wbsElement?.workPackageNumber).toEqual(14);
228224
});
229225
it('create change request on an inactive project - work package changes', async () => {
230226
await prisma.wBS_Element.update({
231227
where: {
232228
wbsNumber: {
233-
carNumber: 0,
234-
projectNumber: 1,
235-
workPackageNumber: 0,
229+
carNumber: 12,
230+
projectNumber: 13,
231+
workPackageNumber: 14,
236232
organizationId: organization.organizationId
237233
}
238234
},
@@ -254,9 +250,9 @@ describe('Change Request Tests', () => {
254250

255251
await ChangeRequestsService.createStandardChangeRequest(
256252
user,
257-
0,
258-
1,
259-
0,
253+
12,
254+
13,
255+
14,
260256
CR_Type.DEFINITION_CHANGE,
261257
'What',
262258
[
@@ -274,18 +270,18 @@ describe('Change Request Tests', () => {
274270
const wbsElement = await prisma.wBS_Element.findUnique({
275271
where: {
276272
wbsNumber: {
277-
carNumber: 0,
278-
projectNumber: 1,
279-
workPackageNumber: 0,
273+
carNumber: 12,
274+
projectNumber: 13,
275+
workPackageNumber: 14,
280276
organizationId: organization.organizationId
281277
}
282278
}
283279
});
284280

285281
expect(wbsElement?.status).toEqual(WBS_Element_Status.INACTIVE);
286-
expect(wbsElement?.carNumber).toEqual(0);
287-
expect(wbsElement?.projectNumber).toEqual(1);
288-
expect(wbsElement?.workPackageNumber).toEqual(0);
282+
expect(wbsElement?.carNumber).toEqual(12);
283+
expect(wbsElement?.projectNumber).toEqual(13);
284+
expect(wbsElement?.workPackageNumber).toEqual(14);
289285
});
290286
});
291287
});

0 commit comments

Comments
 (0)