Skip to content

Commit a0bdd03

Browse files
committed
#3802 fix prettier and tests
1 parent 2b55f58 commit a0bdd03

1 file changed

Lines changed: 4 additions & 22 deletions

File tree

src/backend/tests/unit/change-requests.test.ts

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
11
import { CR_Type, Organization, Scope_CR_Why_Type, User, WBS_Element_Status } from '@prisma/client';
22
import { createTestOrganization, createTestUser, resetUsers } from '../test-utils';
33
import ChangeRequestsService from '../../src/services/change-requests.services';
4-
import {
5-
supermanAdmin,
6-
aquamanLeadership,
7-
greenlanternHead,
8-
flashAdmin,
9-
robinMember
10-
} from '../test-data/users.test-data';
4+
import { supermanAdmin, aquamanLeadership, greenlanternHead, flashAdmin, robinMember } from '../test-data/users.test-data';
115
import { ProjectProposedChangesCreateArgs, WorkPackageProposedChangesCreateArgs } from 'shared';
126
import prisma from '../../src/prisma/prisma';
137
import { AccessDeniedException } from '../../src/utils/errors.utils';
@@ -301,7 +295,7 @@ describe('Change Request Tests', () => {
301295
let changeRequestId: string;
302296

303297
beforeEach(async () => {
304-
submitterUser = await createTestUser(supermanAdmin, orgId);
298+
submitterUser = user;
305299
leadershipUser1 = await createTestUser(aquamanLeadership, orgId);
306300
leadershipUser2 = await createTestUser(greenlanternHead, orgId);
307301
nonRequestedLeadership = await createTestUser(flashAdmin, orgId);
@@ -448,24 +442,12 @@ describe('Change Request Tests', () => {
448442
);
449443

450444
await expect(
451-
ChangeRequestsService.reviewChangeRequest(
452-
memberUser,
453-
changeRequestId,
454-
'I want to review',
455-
false,
456-
organization,
457-
null
458-
)
445+
ChangeRequestsService.reviewChangeRequest(memberUser, changeRequestId, 'I want to review', false, organization, null)
459446
).rejects.toThrow();
460447
});
461448

462449
it('allows rejection by non-requested leadership when reviewers are requested', async () => {
463-
await ChangeRequestsService.requestCRReview(
464-
submitterUser,
465-
[leadershipUser1.userId],
466-
changeRequestId,
467-
organization
468-
);
450+
await ChangeRequestsService.requestCRReview(submitterUser, [leadershipUser1.userId], changeRequestId, organization);
469451

470452
await expect(
471453
ChangeRequestsService.reviewChangeRequest(

0 commit comments

Comments
 (0)