#3937 finalize unit testing

Author: staysgt

src/backend/src/controllers/recruitment.controllers.ts

@@ -118,21 +118,21 @@ export default class RecruitmentController {
 
   static async editGuestDefinition(req: Request, res: Response, next: NextFunction) {
     try {
-      const { guestId } = req.params as Record<string, string>;
+      const { definitionId } = req.params as Record<string, string>;
       const { term, description, order, icon, buttonText, buttonLink } = req.body;
 
-      const guest = await RecruitmentServices.editGuestDefinition(
+      const definition = await RecruitmentServices.editGuestDefinition(
         req.currentUser,
         req.organization,
         term,
         description,
-        guestId,
+        definitionId,
         order,
         icon,
         buttonText,
         buttonLink
       );
-      res.status(200).json(guest);
+      res.status(200).json(definition);
     } catch (error: unknown) {
       next(error);
     }

src/backend/tests/unit/recruitment.test.ts

@@ -393,7 +393,7 @@ describe('Recruitment Tests', () => {
             'buttonTxt',
             'buttonLink'
           )
-      ).rejects.toThrow(new AccessDeniedAdminOnlyException('edit guest definition'));
+      ).rejects.toThrow(new AccessDeniedAdminOnlyException('edit a guest definition'));
     });
 
     it('Fails if guest definition doesn`t exist', async () => {
@@ -409,7 +409,70 @@ describe('Recruitment Tests', () => {
             'buttonTxt',
             'buttonLink'
           )
-      ).rejects.toThrow(new NotFoundException('Milestone', 1));
+      ).rejects.toThrow(new NotFoundException('Guest Definition', 'definition id'));
+    });
+
+    it('Successful edit guest definition', async () => {
+      const def = await RecruitmentServices.createGuestDefinition(
+        superman,
+        organization,
+        'test term',
+        'test description',
+        2,
+        'iconname',
+        'buttonTxt',
+        'buttonLink'
+      );
+
+      const edited = await RecruitmentServices.editGuestDefinition(
+        await createTestUser(batmanAppAdmin, orgId),
+        organization,
+        'new term',
+        'new description',
+        def.definitionId,
+        4,
+        'new icon',
+        'new text',
+        'new link'
+      );
+
+      expect(edited.term).toBe('new term');
+      expect(edited.description).toBe('new description');
+      expect(edited.order).toBe(4);
+      expect(edited.icon).toBe('new icon');
+      expect(edited.buttonText).toBe('new text');
+      expect(edited.buttonLink).toBe('new link');
+    });
+
+    it('Edit guest definition fails if defintion is deleted', async () => {
+      const def = await RecruitmentServices.createGuestDefinition(
+        superman,
+        organization,
+        'test term',
+        'test description',
+        2,
+        'iconname',
+        'buttonTxt',
+        'buttonLink'
+      );
+
+      const batman = await createTestUser(batmanAppAdmin, orgId);
+
+      await RecruitmentServices.deleteGuestDefinition(batman, def.definitionId, organization);
+
+      await expect(
+        async () =>
+          await RecruitmentServices.editGuestDefinition(
+            batman,
+            organization,
+            'term',
+            'description',
+            def.definitionId,
+            2,
+            'buttonTxt',
+            'buttonLink'
+          )
+      ).rejects.toThrow(new DeletedException('Guest Definition', def.definitionId));
     });
 
     it('Fails if milestone is deleted', async () => {