format dates in api layer for backend

chpy04 · chpy04 · commit 943aba667625 · 2026-03-04T12:01:47.000-05:00
diff --git a/src/backend/src/routes/change-requests.routes.ts b/src/backend/src/routes/change-requests.routes.ts
@@ -4,6 +4,7 @@ import { ChangeRequestReason, ChangeRequestType } from 'shared';
 import ChangeRequestsController from '../controllers/change-requests.controllers.js';
 import {
   intMinZero,
+  isDateOnly,
   nonEmptyString,
   projectProposedChangesValidators,
   validateInputs,
@@ -38,14 +39,7 @@ changeRequestsRouter.post(
   intMinZero(body('wbsNum.projectNumber')),
   intMinZero(body('wbsNum.workPackageNumber')),
   body('type').custom((value) => value === ChangeRequestType.Activation),
-  body('startDate').custom((value) => {
-    const parsed = Date.parse(value);
-    if (isNaN(parsed)) return false;
-    const date = new Date(parsed);
-    return (
-      date.getUTCHours() === 0 && date.getUTCMinutes() === 0 && date.getUTCSeconds() === 0 && date.getUTCMilliseconds() === 0
-    );
-  }),
+  isDateOnly(body('startDate')),
   nonEmptyString(body('leadId')),
   nonEmptyString(body('managerId')),
   body('confirmDetails').isBoolean(),
diff --git a/src/frontend/src/apis/calendar.api.ts b/src/frontend/src/apis/calendar.api.ts
@@ -5,6 +5,7 @@ import {
   Machinery,
   EventType,
   AvailabilityCreateArgs,
+  dateToMidnightUTC,
   Event,
   EventStatus,
   EventTypeCreateArgs,
@@ -118,7 +119,9 @@ export const editShop = (shopId: string, payload: { name: string; description: s
 };
 
 export const markUserConfirmed = async (id: string, payload: { availability: AvailabilityCreateArgs[] }) => {
-  return axios.post<Event>(apiUrls.calendarEventMarkUserConfirmed(id), payload);
+  return axios.post<Event>(apiUrls.calendarEventMarkUserConfirmed(id), {
+    availability: payload.availability.map((a) => ({ ...a, dateSet: dateToMidnightUTC(a.dateSet) }))
+  });
 };
 
 export const getSingleEvent = async (id: string) => {
diff --git a/src/frontend/src/apis/finance.api.ts b/src/frontend/src/apis/finance.api.ts
@@ -26,6 +26,7 @@ import {
 } from '../hooks/finance.hooks';
 import axios from '../utils/axios';
 import { apiUrls } from '../utils/urls';
+import { dateToMidnightUTC } from 'shared';
 import {
   reimbursementRequestDataTransformer,
   reimbursementRequestTransformer,
@@ -71,7 +72,10 @@ export const uploadSingleReceipt = (file: File, id: string) => {
  * @returns the created reimbursement request
  */
 export const createReimbursementRequest = (formData: CreateReimbursementRequestPayload) => {
-  return axios.post(apiUrls.financeCreateReimbursementRequest(), formData);
+  return axios.post(apiUrls.financeCreateReimbursementRequest(), {
+    ...formData,
+    dateOfExpense: formData.dateOfExpense ? dateToMidnightUTC(formData.dateOfExpense) : undefined
+  });
 };
 
 /**
@@ -102,7 +106,10 @@ export const markReimbursementRequestAsReimbursed = (id: string) => {
  * @returns the edited reimbursement request
  */
 export const editReimbursementRequest = (id: string, formData: EditReimbursementRequestPayload) => {
-  return axios.post(apiUrls.financeEditReimbursementRequest(id), formData);
+  return axios.post(apiUrls.financeEditReimbursementRequest(id), {
+    ...formData,
+    dateOfExpense: formData.dateOfExpense ? dateToMidnightUTC(formData.dateOfExpense) : undefined
+  });
 };
 
 /**
diff --git a/src/frontend/src/apis/recruitment.api.ts b/src/frontend/src/apis/recruitment.api.ts
@@ -1,7 +1,7 @@
 import axios from '../utils/axios';
 import { MilestonePayload, FaqPayload } from '../hooks/recruitment.hooks';
 import { apiUrls } from '../utils/urls';
-import { Milestone } from 'shared';
+import { dateToMidnightUTC, Milestone } from 'shared';
 import { FrequentlyAskedQuestion } from 'shared';
 
 export const getAllMilestones = () => {
@@ -12,13 +12,15 @@ export const getAllMilestones = () => {
 
 export const createMilestone = (payload: MilestonePayload) => {
   return axios.post(apiUrls.milestoneCreate(), {
-    ...payload
+    ...payload,
+    dateOfEvent: dateToMidnightUTC(payload.dateOfEvent)
   });
 };
 
 export const editMilestone = (payload: MilestonePayload, id: string) => {
   return axios.post(apiUrls.milestoneEdit(id), {
-    ...payload
+    ...payload,
+    dateOfEvent: dateToMidnightUTC(payload.dateOfEvent)
   });
 };
 
diff --git a/src/frontend/src/apis/tasks.api.ts b/src/frontend/src/apis/tasks.api.ts
@@ -3,7 +3,17 @@
  * See the LICENSE file in the repository root folder for details.
  */
 
-import { CalendarTask, FilterTaskArgs, Task, TaskCardPreview, TaskPriority, TaskStatus, WbsNumber, wbsPipe } from 'shared';
+import {
+  CalendarTask,
+  dateToMidnightUTC,
+  FilterTaskArgs,
+  Task,
+  TaskCardPreview,
+  TaskPriority,
+  TaskStatus,
+  WbsNumber,
+  wbsPipe
+} from 'shared';
 import axios from '../utils/axios';
 import { apiUrls } from '../utils/urls';
 import { taskTransformer } from './transformers/tasks.transformers';
@@ -69,8 +79,8 @@ export const editTask = (
     title,
     notes,
     priority,
-    deadline,
-    startDate
+    deadline: deadline ? dateToMidnightUTC(deadline) : undefined,
+    startDate: startDate ? dateToMidnightUTC(startDate) : undefined
   });
 };
 
diff --git a/src/frontend/src/apis/users.api.ts b/src/frontend/src/apis/users.api.ts
@@ -5,6 +5,7 @@
 
 import axios from '../utils/axios';
 import {
+  dateToMidnightUTC,
   ProjectOverview,
   SetUserScheduleSettingsPayload,
   Task,
@@ -170,7 +171,10 @@ export const updateUserSecureSettings = (settings: UserSecureSettings) => {
  * Update the given user's schedule settings by UserId
  */
 export const updateUserScheduleSettings = (settings: SetUserScheduleSettingsPayload) => {
-  return axios.post<UserScheduleSettings>(apiUrls.userScheduleSettingsSet(), settings);
+  return axios.post<UserScheduleSettings>(apiUrls.userScheduleSettingsSet(), {
+    ...settings,
+    availability: settings.availability.map((a) => ({ ...a, dateSet: dateToMidnightUTC(a.dateSet) }))
+  });
 };
 
 export const updateUserRole = (id: string, role: string) => {
diff --git a/src/frontend/src/apis/work-packages.api.ts b/src/frontend/src/apis/work-packages.api.ts
@@ -4,7 +4,7 @@
  */
 
 import axios from '../utils/axios';
-import { DescriptionBulletPreview, WbsNumber, WorkPackage, WorkPackagePreview, WorkPackageStage } from 'shared';
+import { dateToMidnightUTC, DescriptionBulletPreview, WbsNumber, WorkPackage, WorkPackagePreview, WorkPackageStage } from 'shared';
 import { wbsPipe } from '../utils/pipes';
 import { apiUrls } from '../utils/urls';
 import { workPackagePreviewTransformer, workPackageTransformer } from './transformers/work-packages.transformers';
@@ -109,7 +109,7 @@ export const getManyWorkPackages = (wbsNums: WbsNumber[]) => {
  */
 export const slackUpcomingDeadlines = (deadline: Date) => {
   return axios.post<{ message: string }>(apiUrls.workPackagesSlackUpcomingDeadlines(), {
-    deadline
+    deadline: dateToMidnightUTC(deadline)
   });
 };
 
diff --git a/src/frontend/src/pages/CalendarPage/Components/CalendarCreateTaskModal.tsx b/src/frontend/src/pages/CalendarPage/Components/CalendarCreateTaskModal.tsx
@@ -3,7 +3,7 @@ import { yupResolver } from '@hookform/resolvers/yup';
 import { Autocomplete, FormControl, FormHelperText, FormLabel, Grid, MenuItem, TextField } from '@mui/material';
 import { DatePicker } from '@mui/x-date-pickers';
 import { Controller, useForm } from 'react-hook-form';
-import { countWords, isUnderWordCount, ProjectPreview, TaskPriority, TaskStatus, wbsPipe } from 'shared';
+import { countWords, dateToMidnightUTC, isUnderWordCount, ProjectPreview, TaskPriority, TaskStatus, wbsPipe } from 'shared';
 import { useAllMembers } from '../../../hooks/users.hooks';
 import { useAllProjects } from '../../../hooks/projects.hooks';
 import { useCreateTask } from '../../../hooks/tasks.hooks';
@@ -85,8 +85,8 @@ const CalendarCreateTaskModal: React.FC<CalendarCreateTaskModalProps> = ({ open,
         status: data.status,
         assignees: data.assignees,
         notes: data.notes,
-        deadline: data.deadline?.toISOString(),
-        startDate: data.startDate?.toISOString()
+        deadline: data.deadline ? dateToMidnightUTC(data.deadline).toISOString() : undefined,
+        startDate: data.startDate ? dateToMidnightUTC(data.startDate).toISOString() : undefined
       });
       toast.success('Task created successfully!');
       onClose();
diff --git a/src/frontend/src/pages/GanttPage/ProjectGanttChart/ProjectGanttChangeModals/GanttProjectCreateModal.tsx b/src/frontend/src/pages/GanttPage/ProjectGanttChart/ProjectGanttChangeModals/GanttProjectCreateModal.tsx
@@ -1,5 +1,5 @@
 import { Box, Typography } from '@mui/material';
-import { ProjectGantt } from 'shared';
+import { dateToMidnightUTC, ProjectGantt } from 'shared';
 import dayjs from 'dayjs';
 import LoadingIndicator from '../../../../components/LoadingIndicator';
 import { useToast } from '../../../../hooks/toasts.hooks';
@@ -46,7 +46,7 @@ export const GanttProjectCreateModal = ({ change, handleClose, open }: GanttProj
 
     const workPackagePayloads: WorkPackageApiInputs[] = project.workPackages.map((workPackage) => ({
       name: workPackage.name,
-      startDate: workPackage.startDate.toISOString(),
+      startDate: dateToMidnightUTC(workPackage.startDate).toISOString(),
       duration: dayjs(workPackage.endDate).diff(dayjs(workPackage.startDate), 'week'),
       crId: undefined,
       blockedBy: workPackage.blockedBy,
@@ -73,8 +73,8 @@ export const GanttProjectCreateModal = ({ change, handleClose, open }: GanttProj
               status: task.status,
               assignees: task.assignees.map((user) => user.userId),
               notes: task.notes || '',
-              deadline: task.deadline ? task.deadline.toISOString() : undefined,
-              startDate: task.startDate ? task.startDate.toISOString() : undefined
+              deadline: task.deadline ? dateToMidnightUTC(task.deadline).toISOString() : undefined,
+              startDate: task.startDate ? dateToMidnightUTC(task.startDate).toISOString() : undefined
             });
             toast.success('All tasks created successfully!');
           } catch (error) {
diff --git a/src/frontend/src/pages/GanttPage/ProjectGanttChart/ProjectGanttChangeModals/GanttTimeLineChangeModal.tsx b/src/frontend/src/pages/GanttPage/ProjectGanttChart/ProjectGanttChangeModals/GanttTimeLineChangeModal.tsx
@@ -2,6 +2,7 @@ import { Box, FormControl, InputLabel, MenuItem, Select, SelectChangeEvent, Text
 import {
   ChangeRequestReason,
   ChangeRequestType,
+  dateToMidnightUTC,
   Link,
   LinkCreateArgs,
   ProjectGantt,
@@ -151,7 +152,7 @@ export const GanttTimeLineChangeModal = ({ change, handleClose, open }: GanttTim
                 name: workPackage.name,
                 stage: workPackage.stage,
                 duration,
-                startDate: change.newStart.toISOString(),
+                startDate: dateToMidnightUTC(change.newStart).toISOString(),
                 blockedBy: workPackage.blockedBy,
                 descriptionBullets: workPackage.descriptionBullets,
                 leadId: workPackage.lead ? workPackage.lead.userId : undefined,
@@ -180,7 +181,7 @@ export const GanttTimeLineChangeModal = ({ change, handleClose, open }: GanttTim
         await createSingleWorkPackage({
           projectWbsNum: project.wbsNum,
           name: workPackage.name,
-          startDate: workPackage.startDate.toISOString(),
+          startDate: dateToMidnightUTC(workPackage.startDate).toISOString(),
           duration,
           stage: workPackage.stage ?? 'NONE',
           blockedBy: [],
@@ -198,8 +199,8 @@ export const GanttTimeLineChangeModal = ({ change, handleClose, open }: GanttTim
             status: task.status,
             assignees: task.assignees?.map((user) => user.userId) || [],
             notes: task.notes || '',
-            deadline: task.deadline?.toISOString(),
-            startDate: task.startDate?.toISOString()
+            deadline: task.deadline ? dateToMidnightUTC(task.deadline).toISOString() : undefined,
+            startDate: task.startDate ? dateToMidnightUTC(task.startDate).toISOString() : undefined
           };
 
           try {
diff --git a/src/frontend/src/pages/ProjectDetailPage/ProjectForm/ProjectCreateContainer.tsx b/src/frontend/src/pages/ProjectDetailPage/ProjectForm/ProjectCreateContainer.tsx
@@ -20,7 +20,7 @@ import * as yup from 'yup';
 import { FormInput } from '../../CreateChangeRequestPage/CreateChangeRequestView';
 import { StandardChangeRequestType } from '../../CreateChangeRequestPage/CreateChangeRequestView';
 import { ProjectCreateChangeRequestFormInput } from './ProjectEditContainer';
-import { ProjectProposedChangesCreateArgs, WbsNumber, WorkPackageStage } from 'shared';
+import { dateToMidnightUTC, ProjectProposedChangesCreateArgs, WbsNumber, WorkPackageStage } from 'shared';
 import { CreateStandardChangeRequestPayload, useCreateStandardChangeRequest } from '../../../hooks/change-requests.hooks';
 import { useCreateSingleWorkPackage } from '../../../hooks/work-packages.hooks';
 import { useGetAllCars } from '../../../hooks/cars.hooks';
@@ -249,7 +249,7 @@ const ProjectCreateContainer: React.FC = () => {
       for (const wp of sortedWorkPackages) {
         const created = await createWpMutateAsync({
           name: wp.name,
-          startDate: wp.startDate.toISOString(),
+          startDate: dateToMidnightUTC(wp.startDate).toISOString(),
           duration: Number(wp.duration),
           blockedBy: wp.blockedBy.map((blocker) => idToWbs.get(blocker)!),
           projectWbsNum: project.wbsNum,
diff --git a/src/frontend/src/pages/WorkPackageDetailPage/ActivateWorkPackageModalContainer/ActivateWorkPackageModalContainer.tsx b/src/frontend/src/pages/WorkPackageDetailPage/ActivateWorkPackageModalContainer/ActivateWorkPackageModalContainer.tsx
@@ -4,7 +4,7 @@
  */
 
 import { useHistory } from 'react-router-dom';
-import { ChangeRequestType, WbsNumber } from 'shared';
+import { ChangeRequestType, dateToMidnightUTC, WbsNumber } from 'shared';
 import { useAuth } from '../../../hooks/auth.hooks';
 import { useCreateActivationChangeRequest } from '../../../hooks/change-requests.hooks';
 import { useAllMembers } from '../../../hooks/users.hooks';
@@ -54,7 +54,7 @@ const ActivateWorkPackageModalContainer: React.FC<ActivateWorkPackageModalContai
         type: ChangeRequestType.Activation,
         leadId,
         managerId,
-        startDate: startDate.toISOString(),
+        startDate: dateToMidnightUTC(startDate).toISOString(),
         confirmDetails
       });
       history.push(routes.CHANGE_REQUESTS);
diff --git a/src/shared/src/date-format.ts b/src/shared/src/date-format.ts
@@ -54,6 +54,14 @@ export const formatTimeForSlack = (date: Date): string => dayjs(date).tz('Americ
  */
 export const toDateString = (date: Date): string => dayjs(date).format('YYYY-MM-DD');
 
+/**
+ * Normalize a Date to midnight UTC, preserving the local calendar date.
+ * Use this before sending date-only values to the backend so they pass isDateOnly validation.
+ * Example: 2026-03-04T16:49:00 local → 2026-03-04T00:00:00.000Z
+ */
+export const dateToMidnightUTC = (date: Date): Date =>
+  new Date(Date.UTC(date.getFullYear(), date.getMonth(), date.getDate()));
+
 /**
  * Convert a @db.Date value (midnight UTC) to a local Date representing the same calendar date.
  * Use this when passing date-only values to functions that use local-time methods (getDay, getDate, etc).
