Skip to content

Commit 895018e

Browse files
committed
Merge branch 'develop' into multitenancy
2 parents 83ab2cb + 060a209 commit 895018e

4 files changed

Lines changed: 15 additions & 4 deletions

File tree

src/backend/src/services/change-requests.services.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export default class ChangeRequestsService {
146146
dateReviewed: null
147147
},
148148
{
149-
NOT: { scopeChangeRequest: null }
149+
NOT: [{ scopeChangeRequest: null }, { submitterId: user.userId }]
150150
}
151151
],
152152
organizationId: organization.organizationId,

src/frontend/src/pages/CalendarPage/DesignReviewDetailPage/FinalizeDesignReviewDetailsModal.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,18 @@ const FinalizeDesignReviewDetailsModal = ({
7777
};
7878

7979
useEffect(() => {
80-
if (userScheduleSettings && !designReview.zoomLink) {
80+
if (userScheduleSettings && designReview.isOnline && !designReview.zoomLink) {
8181
reset({
8282
docTemplateLink: designReview.docTemplateLink ?? '',
8383
zoomLink: userScheduleSettings.personalZoomLink ?? '',
8484
location: designReview.location ?? undefined
8585
});
8686
}
87+
if (designReview.zoomLink === '' && !designReview.isOnline) {
88+
reset({
89+
zoomLink: undefined
90+
});
91+
}
8792
}, [userScheduleSettings, designReview, reset]);
8893

8994
return (

src/frontend/src/pages/ChangeRequestDetailPage/DiffSection/DiffSection.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import { StandardChangeRequest } from 'shared';
44
import ProjectDiffSection from './ProjectDiffSection';
55
import WorkPackageDiffSection from './WorkPackageDiffSection';
66
import LoadingIndicator from '../../../components/LoadingIndicator';
7+
import DiffSectionEdit from './DiffSectionEdit';
8+
import { getChangesForWorkPackage } from '../../../utils/diff-page.utils';
79
interface DiffSectionProps {
810
changeRequest: StandardChangeRequest;
911
}
@@ -18,7 +20,11 @@ const DiffSection: React.FC<DiffSectionProps> = ({ changeRequest }) => {
1820
projectProposedChanges ? (
1921
<ProjectDiffSection projectProposedChanges={projectProposedChanges} wbsNum={wbsNum} />
2022
) : workPackageProposedChanges ? (
21-
<WorkPackageDiffSection workPackageProposedChanges={workPackageProposedChanges} wbsNum={wbsNum} />
23+
wbsNum.workPackageNumber === 0 ? (
24+
<DiffSectionEdit collections={[getChangesForWorkPackage(undefined, workPackageProposedChanges)]} />
25+
) : (
26+
<WorkPackageDiffSection workPackageProposedChanges={workPackageProposedChanges} wbsNum={wbsNum} />
27+
)
2228
) : (
2329
<></>
2430
)

src/frontend/src/pages/TeamsPage/TeamSpecificPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ const TeamSpecificPage: React.FC = () => {
153153
{TeamActionsDropdown}
154154
</Stack>
155155
}
156-
title={`${data.teamName} - ${data.teamType}`}
156+
title={`${data.teamName} ${data.teamType ? `- ${data.teamType?.name}` : ''}`}
157157
chips={
158158
data.dateArchived ? (
159159
<Box display="flex" gap="20px">

0 commit comments

Comments
 (0)