Skip to content

Commit 7e67a13

Browse files
committed
Merge branch 'develop' into #3864-SathvikCharugundla-credits
2 parents 950f247 + 99a3c70 commit 7e67a13

4 files changed

Lines changed: 39 additions & 9 deletions

File tree

src/backend/src/services/change-requests.services.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ export default class ChangeRequestsService {
178178
dateReviewed: null
179179
},
180180
{
181-
NOT: { scopeChangeRequest: null }
181+
changes: { none: {} }
182182
}
183183
];
184184

@@ -666,9 +666,7 @@ export default class ChangeRequestsService {
666666
include: {
667667
changeRequests: {
668668
where: {
669-
dateDeleted: {
670-
not: null
671-
}
669+
dateDeleted: null
672670
},
673671
include: {
674672
changes: true

src/frontend/src/components/ChangeRequestTab.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import { WbsElement } from 'shared';
7-
import { useGetUnreviewedChangeRequests } from '../hooks/change-requests.hooks';
7+
import { useGetApprovedChangeRequests, useGetUnreviewedChangeRequests } from '../hooks/change-requests.hooks';
88
import ErrorPage from '../pages/ErrorPage';
99
import LoadingIndicator from './LoadingIndicator';
1010
import ChangeRequestRow from './ChangeRequestRow';
@@ -21,7 +21,7 @@ const ChangeRequestTab = ({ wbsElement }: { wbsElement: WbsElement }) => {
2121
isError: approvedCRIsError,
2222
isLoading: approvedCRIsLoading,
2323
error: approvedCRError
24-
} = useGetUnreviewedChangeRequests(wbsElement.wbsNum);
24+
} = useGetApprovedChangeRequests(wbsElement.wbsNum);
2525

2626
if (unreviewedCRIsError) return <ErrorPage message={unreviewedCRError?.message} />;
2727
if (approvedCRIsError) return <ErrorPage message={approvedCRError?.message} />;

src/frontend/src/pages/CreditsPage/CreditsPage.tsx

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ const CreditsPage: React.FC = () => {
300300
}
301301
}
302302
},
303+
{ name: 'Mimo Olowu', color: 'white', sx: { px: 1, backgroundColor: '#ac59eb', borderRadius: 2 } },
303304
{ name: 'Saul Manzanares', color: '#AF34FA' },
304305
{ name: 'Richard Feng', color: '#FFFF', sx: { textShadow: '0 0 2px rgba(0,26,255), 0 0 5px rgba(255,255,255)' } },
305306
{
@@ -314,7 +315,29 @@ const CreditsPage: React.FC = () => {
314315
'100%': { textShadow: '0 0 4px rgba(190, 0, 0, 0.7), 0 0 10px rgba(190, 0, 0, 0.4)' }
315316
}
316317
}
317-
}
318+
},
319+
{
320+
name: 'Santiago Ordonez Merizalde',
321+
color: 'transparent',
322+
sx: {
323+
textShadow: `
324+
0 0 8px rgba(180, 0, 255, 0.8),
325+
0 0 15px rgba(140, 0, 255, 0.6),
326+
0 0 25px rgba(200, 100, 255, 0.5)
327+
`,
328+
background: 'linear-gradient(90deg, #d9a7ff, #b58eff, #7f6fff, #b58eff, #d9a7ff)',
329+
'-webkit-background-clip': 'text',
330+
backgroundSize: '300% 300%',
331+
animation: 'purpleFlow 6s ease-in-out infinite',
332+
'@keyframes purpleFlow': {
333+
'0%': { backgroundPosition: '0% 50%' },
334+
'50%': { backgroundPosition: '100% 50%' },
335+
'100%': { backgroundPosition: '0% 50%' }
336+
},
337+
filter: 'drop-shadow(0 0 4px rgba(190, 80, 255, 0.6))'
338+
}
339+
},
340+
{ name: 'Josh Len', color: '#000000ff' }
318341
];
319342

320343
const snark = ['Add your name!', "Shouldn't you do it yourself?", 'Seriously', 'go', 'do', 'it'];

src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -654,6 +654,9 @@ const ReimbursementRequestFormView: React.FC<ReimbursementRequestFormViewProps>
654654
'& .MuiOutlinedInput-root': {
655655
borderRadius: '20px',
656656
color: '#989898'
657+
},
658+
'& .MuiOutlinedInput-input': {
659+
color: '#ffffff'
657660
}
658661
}}
659662
onClose={() => setDatePickerOpen(false)}
@@ -665,8 +668,14 @@ const ReimbursementRequestFormView: React.FC<ReimbursementRequestFormViewProps>
665668
textField: {
666669
error: !!errors.dateOfExpense,
667670
helperText: errors.dateOfExpense?.message,
668-
onClick: () => setDatePickerOpen(true),
669-
inputProps: { readOnly: true }
671+
InputProps: {
672+
onClick: (e) => {
673+
const target = e.target as HTMLElement;
674+
if (target.closest('button')) {
675+
setDatePickerOpen(true);
676+
}
677+
}
678+
}
670679
}
671680
}}
672681
/>

0 commit comments

Comments
 (0)