Skip to content

Commit 650bcd0

Browse files
Samuel ShresthaSamuel Shrestha
authored andcommitted
material form fixes
1 parent 7f05c72 commit 650bcd0

2 files changed

Lines changed: 15 additions & 8 deletions

File tree

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/BOM/MaterialForm/MaterialForm.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ const schema = yup.object().shape({
2929
linkUrl: yup.string().optional(),
3030
notes: yup.string().optional(),
3131
pdmFileName: yup.string().optional(),
32-
assemblyId: yup.string().optional()
32+
assemblyId: yup.string().optional(),
33+
reimbursementRequestId: yup.string().optional()
3334
});
3435

3536
export interface MaterialFormInput {
@@ -45,6 +46,7 @@ export interface MaterialFormInput {
4546
linkUrl?: string;
4647
notes?: string;
4748
assemblyId?: string;
49+
reimbursementRequestId?: string;
4850
}
4951

5052
export interface MaterialDataSubmission {
@@ -101,7 +103,8 @@ const MaterialForm: React.FC<MaterialFormProps> = ({
101103
unitName: defaultValues?.unitName,
102104
linkUrl: defaultValues?.linkUrl ?? '',
103105
notes: defaultValues?.notes,
104-
assemblyId: defaultValues?.assemblyId
106+
assemblyId: defaultValues?.assemblyId,
107+
reimbursementRequestId: defaultValues?.reimbursementRequestId
105108
},
106109
resolver: yupResolver(schema)
107110
});

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/BOM/MaterialForm/MaterialFormView.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
} from '@mui/material';
1616
import { Box } from '@mui/system';
1717
import { Control, Controller, FieldErrors, UseFormHandleSubmit, UseFormSetValue, UseFormWatch } from 'react-hook-form';
18-
import { Assembly, Manufacturer, MaterialType, Unit } from 'shared';
18+
import { Assembly, Manufacturer, Material, MaterialType, Unit } from 'shared';
1919
import ReactHookTextField from '../../../../../components/ReactHookTextField';
2020
import { MaterialFormInput } from './MaterialForm';
2121
import NERFormModal from '../../../../../components/NERFormModal';
@@ -44,7 +44,6 @@ export interface MaterialFormViewProps {
4444
watch: UseFormWatch<MaterialFormInput>;
4545
createManufacturer: (name: string) => void;
4646
setValue: UseFormSetValue<MaterialFormInput>;
47-
copyFromExistingBomAction?: React.ReactNode;
4847
fromRRForm?: boolean;
4948
}
5049

@@ -81,19 +80,19 @@ const MaterialFormView: React.FC<MaterialFormViewProps> = ({
8180

8281
const [copyModalOpen, setCopyModalOpen] = React.useState(false);
8382

84-
const handleCopySelect = (m: any) => {
83+
const handleCopySelect = (m: Material) => {
8584
setValue('name', m.name ?? '');
86-
setValue('status', m.status ?? MaterialStatus.Ordered);
8785
setValue('materialTypeName', m.materialTypeName ?? '');
8886
setValue('manufacturerName', m.manufacturerName ?? '');
8987
setValue('manufacturerPartNumber', m.manufacturerPartNumber ?? '');
9088
setValue('pdmFileName', m.pdmFileName ?? '');
9189
setValue('linkUrl', m.linkUrl ?? '');
92-
setValue('quantity', m.quantity ?? undefined);
90+
setValue('quantity', m.quantity != null ? Number(m.quantity) : undefined);
9391
setValue('unitName', m.unitName ?? undefined);
9492
setValue('price', m.price != null ? m.price / 100 : undefined);
9593
setValue('notes', m.notes ?? '');
9694
setValue('assemblyId', undefined);
95+
setValue('reimbursementRequestId', undefined);
9796

9897
setCopyModalOpen(false);
9998
};
@@ -548,7 +547,12 @@ const MaterialFormView: React.FC<MaterialFormViewProps> = ({
548547
</Box>
549548
</Grid>
550549
)}
551-
<SelectMaterialToCopyModal open={copyModalOpen} onHide={() => setCopyModalOpen(false)} onSelect={handleCopySelect} />
550+
<SelectMaterialToCopyModal
551+
open={copyModalOpen}
552+
onHide={() => setCopyModalOpen(false)}
553+
onSelect={handleCopySelect}
554+
assemblies={assemblies ?? []}
555+
/>
552556
</NERFormModal>
553557
);
554558
};

0 commit comments

Comments
 (0)