slack fails silently so endpoints don't fail bc of external api

Author: chpy04

src/backend/src/integrations/slack.ts

@@ -28,7 +28,8 @@ export const sendMessage = async (slackId: string, message: string, link?: strin
 
     return response && response.channel && response.ts && { channelId: response.channel, ts: response.ts };
   } catch (error) {
-    throw new HttpException(500, 'Error sending slack message, reason: ' + (error as any).data.error);
+    console.error('Failed to send Slack message:', (error as any)?.data?.error ?? error);
+    return undefined;
   }
 };
 
@@ -61,7 +62,8 @@ export const replyToMessageInThread = async (
       blocks: [block]
     });
   } catch (error) {
-    throw new HttpException(500, 'Error sending slack reply to thread, reason: ' + (error as any).data.error);
+    console.error('Failed to send Slack thread reply:', (error as any)?.data?.error ?? error);
+    return undefined;
   }
 };
 
@@ -94,7 +96,8 @@ export const editMessage = async (
       blocks: [block]
     });
   } catch (error) {
-    throw new HttpException(500, 'Error sending slack reply to thread, reason: ' + (error as any).data.error);
+    console.error('Failed to edit Slack message:', (error as any)?.data?.error ?? error);
+    return undefined;
   }
 };
 
@@ -116,7 +119,8 @@ export const reactToMessage = async (slackId: string, parentTimestamp: string, e
       name: emoji
     });
   } catch (error) {
-    throw new HttpException(500, 'Error reacting to slack message, reason: ' + (error as any).data.error);
+    console.error('Failed to react to Slack message:', (error as any)?.data?.error ?? error);
+    return undefined;
   }
 };
 

src/backend/src/services/calendar.services.ts

@@ -514,17 +514,12 @@ export default class CalendarService {
       if (newEvent.status === Event_Status.UNCONFIRMED) {
         for (const memberUserSetting of memberUserSettings) {
           if (memberUserSetting.slackId) {
-            try {
-              // For each project associated with this event
-              await sendSlackEventConfirmNotification(
-                memberUserSetting.slackId,
-                newEvent.eventId,
-                newEvent.title,
-                projects.map((project) => project.wbsElement.name).join(', ')
-              );
-            } catch (err: unknown) {
-              console.error('Failed to send slack notification for event:', err);
-            }
+            await sendSlackEventConfirmNotification(
+              memberUserSetting.slackId,
+              newEvent.eventId,
+              newEvent.title,
+              projects.map((project) => project.wbsElement.name).join(', ')
+            );
           }
         }
       }
@@ -535,17 +530,13 @@ export default class CalendarService {
       for (const project of projects) {
         const projectTeams = project.teams;
         if (projectTeams.length > 0) {
-          try {
-            await sendSlackEventNotifications(
-              projectTeams,
-              createdEvent,
-              submitter,
-              workPackageNames,
-              project.wbsElement.name
-            );
-          } catch (err: unknown) {
-            console.error('Failed to send slack notification for event:', err);
-          }
+          await sendSlackEventNotifications(
+            projectTeams,
+            createdEvent,
+            submitter,
+            workPackageNames,
+            project.wbsElement.name
+          );
         }
       }
     }

src/backend/src/services/reimbursement-requests.services.ts

@@ -1288,15 +1288,11 @@ export default class ReimbursementRequestService {
       ...getReimbursementStatusQueryArgs(organization.organizationId)
     });
 
-    try {
-      await sendPendingSaboSubmissionNotification(
-        reimbursementRequest.notificationSlackThreads,
-        submitter.userId,
-        reimbursementRequest.recipientId
-      );
-    } catch (e: unknown) {
-      console.error('Error sending pending SABO submission notification:', e);
-    }
+    await sendPendingSaboSubmissionNotification(
+      reimbursementRequest.notificationSlackThreads,
+      submitter.userId,
+      reimbursementRequest.recipientId
+    );
 
     return reimbursementStatusTransformer(reimbursementStatus);
   }
@@ -1370,11 +1366,7 @@ export default class ReimbursementRequestService {
       ...getReimbursementStatusQueryArgs(organization.organizationId)
     });
 
-    try {
-      await sendSubmittedToSaboNotification(reimbursementRequest.notificationSlackThreads);
-    } catch (e: unknown) {
-      console.error('Error sending submitted to SABO notification:', e);
-    }
+    await sendSubmittedToSaboNotification(reimbursementRequest.notificationSlackThreads);
 
     return reimbursementStatusTransformer(reimbursementStatus);
   }
@@ -1443,11 +1435,7 @@ export default class ReimbursementRequestService {
         'Reimbursement Request successfully updated, however no slack message was sent as recipient is missing their settings!'
       );
 
-    try {
-      await sendReimbursementRequestDeniedNotification(recipientSettings.slackId, reimbursementRequestId);
-    } catch (e: unknown) {
-      console.error('Error sending reimbursement request denied notification:', e);
-    }
+    await sendReimbursementRequestDeniedNotification(recipientSettings.slackId, reimbursementRequestId);
 
     return reimbursementStatusTransformer(reimbursementStatus);
   }
@@ -1734,14 +1722,10 @@ export default class ReimbursementRequestService {
       ...getReimbursementStatusQueryArgs(organization.organizationId)
     });
 
-    try {
-      await sendReimbursementRequestPendingFinanceNotification(
-        reimbursementRequest.notificationSlackThreads,
-        reimbursementRequest.assigneeId
-      );
-    } catch (e: unknown) {
-      console.error('Error sending reimbursement request pending finance notification:', e);
-    }
+    await sendReimbursementRequestPendingFinanceNotification(
+      reimbursementRequest.notificationSlackThreads,
+      reimbursementRequest.assigneeId
+    );
 
     return reimbursementStatusTransformer(updatedReimbursementStatus);
   }
@@ -1795,11 +1779,7 @@ export default class ReimbursementRequestService {
       ...getReimbursementStatusQueryArgs(organization.organizationId)
     });
 
-    try {
-      await sendReimbursementRequestChangesRequestedNotification(reimbursementRequest.notificationSlackThreads, user.userId);
-    } catch (e: unknown) {
-      console.error('Error sending reimbursement request changes requested notification:', e);
-    }
+    await sendReimbursementRequestChangesRequestedNotification(reimbursementRequest.notificationSlackThreads, user.userId);
 
     return reimbursementStatusTransformer(deletedStatus);
   }

src/backend/src/utils/change-requests.utils.ts

@@ -608,18 +608,12 @@ export const sendCRSubmitterReviewedNotification = async (
 ) => {
   const creatorUserSettings = await prisma.user_Settings.findUnique({ where: { userId: foundCR.submitterId } });
   if (creatorUserSettings && creatorUserSettings.slackId) {
-    try {
-      await sendSlackCRReviewedNotification(
-        creatorUserSettings.slackId,
-        foundCR.crId,
-        foundCR.identifier,
-        foundCR.reviewNotes
-      );
-    } catch (err: unknown) {
-      if (err instanceof Error) {
-        throw new HttpException(500, `Failed to send slack notification: ${err.message}`);
-      }
-    }
+    await sendSlackCRReviewedNotification(
+      creatorUserSettings.slackId,
+      foundCR.crId,
+      foundCR.identifier,
+      foundCR.reviewNotes
+    );
   }
 };
 

src/backend/src/utils/slack.utils.ts

@@ -147,22 +147,16 @@ export const sendReimbursementRequestCreatedNotificationAndCreateMessageInfo = a
 
   if (!financeTeam) throw new HttpException(500, 'Finance team does not exist!');
 
-  try {
-    const messageInfo = await sendMessage(financeTeam.slackId, msg, link, linkButtonText);
-    if (!messageInfo) return; // Not on prod
-
-    await prisma.message_Info.create({
-      data: {
-        reimbursementRequestId: requestId,
-        channelId: messageInfo.channelId,
-        timestamp: messageInfo.ts
-      }
-    });
-  } catch (error: unknown) {
-    if (error instanceof Error) {
-      throw new HttpException(500, `Failed to send slack notification: ${error.message}`);
+  const messageInfo = await sendMessage(financeTeam.slackId, msg, link, linkButtonText);
+  if (!messageInfo) return;
+
+  await prisma.message_Info.create({
+    data: {
+      reimbursementRequestId: requestId,
+      channelId: messageInfo.channelId,
+      timestamp: messageInfo.ts
     }
-  }
+  });
 };
 
 /**
@@ -177,26 +171,14 @@ export const sendReimbursementRequestDeniedNotification = async (slackId: string
   const link = `https://finishlinebyner.com/finance/reimbursement-requests/${requestId}`;
   const linkButtonText = 'View Reimbursement Request';
 
-  try {
-    await sendMessage(slackId, msg, link, linkButtonText);
-  } catch (error: unknown) {
-    if (error instanceof Error) {
-      throw new HttpException(500, `Failed to send slack notification: ${error.message}`);
-    }
-  }
+  await sendMessage(slackId, msg, link, linkButtonText);
 };
 
 export const sendThreadResponse = async (threads: SlackMessageThread[], message: string) => {
   if (process.env.NODE_ENV !== 'production' && !DEV_TESTING_OVERRIDE) return; // don't send msgs unless in prod
-  try {
-    if (threads && threads.length !== 0) {
-      const msgs = threads.map((thread) => replyToMessageInThread(thread.channelId, thread.timestamp, message));
-      await Promise.all(msgs);
-    }
-  } catch (err: unknown) {
-    if (err instanceof Error) {
-      throw new HttpException(500, `Failed to send slack notifications: ${err.message}`);
-    }
+  if (threads && threads.length !== 0) {
+    const msgs = threads.map((thread) => replyToMessageInThread(thread.channelId, thread.timestamp, message));
+    await Promise.all(msgs);
   }
 };
 
@@ -257,13 +239,7 @@ export const sendSlackEventConfirmNotification = async (
     : `http://localhost:3000/calendar/event/${eventId}`;
   const linkButtonText = 'Confirm Availability';
 
-  try {
-    await sendMessage(slackId, msg, fullLink, linkButtonText);
-  } catch (error: unknown) {
-    if (error instanceof Error) {
-      throw new HttpException(500, `Failed to send slack notification: ${error.message}`);
-    }
-  }
+  await sendMessage(slackId, msg, fullLink, linkButtonText);
 };
 
 /**
@@ -390,31 +366,19 @@ export const sendEventUserConfirmationToThread = async (threads: SlackMessageThr
   if (process.env.NODE_ENV !== 'production' && !DEV_TESTING_OVERRIDE) return; // don't send msgs unless in prod
   const slackPing = userToSlackPing(submitter);
   const fullMsg = `${slackPing} confirmed their availability!`;
-  try {
-    if (threads && threads.length !== 0) {
-      const msgs = threads.map((thread) => replyToMessageInThread(thread.channelId, thread.timestamp, fullMsg));
-      await Promise.all(msgs);
-    }
-  } catch (err: unknown) {
-    if (err instanceof Error) {
-      throw new HttpException(500, `Failed to send slack notification: ${err.message}`);
-    }
+  if (threads && threads.length !== 0) {
+    const msgs = threads.map((thread) => replyToMessageInThread(thread.channelId, thread.timestamp, fullMsg));
+    await Promise.all(msgs);
   }
 };
 
 export const sendEventConfirmationToThread = async (threads: SlackMessageThread[], submitter: UserWithSettings) => {
   if (process.env.NODE_ENV !== 'production' && !DEV_TESTING_OVERRIDE) return; // don't send msgs unless in prod
   const slackPing = userToSlackPing(submitter);
   const fullMsg = `${slackPing} All of the required attendees have confirmed their availability!`;
-  try {
-    if (threads && threads.length !== 0) {
-      const msgs = threads.map((thread) => replyToMessageInThread(thread.channelId, thread.timestamp, fullMsg));
-      await Promise.all(msgs);
-    }
-  } catch (err: unknown) {
-    if (err instanceof Error) {
-      throw new HttpException(500, `Failed to send slack notification: ${err.message}`);
-    }
+  if (threads && threads.length !== 0) {
+    const msgs = threads.map((thread) => replyToMessageInThread(thread.channelId, thread.timestamp, fullMsg));
+    await Promise.all(msgs);
   }
 };
 
@@ -456,19 +420,13 @@ export const sendEventScheduledSlackNotif = async (threads: SlackMessageThread[]
   const docLink = event.questionDocumentLink ? `<${event.questionDocumentLink}|Doc Link>` : '';
   const threadMsg = `This event has been Scheduled! \n` + docLink;
 
-  try {
-    if (threads && threads.length !== 0) {
-      const msgs = threads.map((thread) => editMessage(thread.channelId, thread.timestamp, msg));
-      await Promise.all(msgs);
-      const threadMsgs = threads.map((thread) => replyToMessageInThread(thread.channelId, thread.timestamp, threadMsg));
-      await Promise.all(threadMsgs);
-      const reactions = threads.map((thread) => reactToMessage(thread.channelId, thread.timestamp, 'calendar'));
-      await Promise.all(reactions);
-    }
-  } catch (err: unknown) {
-    if (err instanceof Error) {
-      throw new HttpException(500, `Failed to send slack notification: ${err.message}`);
-    }
+  if (threads && threads.length !== 0) {
+    const msgs = threads.map((thread) => editMessage(thread.channelId, thread.timestamp, msg));
+    await Promise.all(msgs);
+    const threadMsgs = threads.map((thread) => replyToMessageInThread(thread.channelId, thread.timestamp, threadMsg));
+    await Promise.all(threadMsgs);
+    const reactions = threads.map((thread) => reactToMessage(thread.channelId, thread.timestamp, 'calendar'));
+    await Promise.all(reactions);
   }
 };
 
@@ -509,20 +467,14 @@ export const sendSlackCRStatusToThread = async (
   const fullMsg = `This Change Request was ${approved ? 'approved! :tada:' : 'denied.'} Click the link to view.`;
   const fullLink = `https://finishlinebyner.com/cr/${crId}`;
   const btnText = `View CR#${identifier}`;
-  try {
-    if (threads && threads.length !== 0) {
-      const msgs = threads.map((thread) =>
-        replyToMessageInThread(thread.channelId, thread.timestamp, fullMsg, fullLink, btnText)
-      );
-      const reactions = threads.map((thread) =>
-        reactToMessage(thread.channelId, thread.timestamp, approved ? 'white_check_mark' : 'x')
-      );
-      await Promise.all([...msgs, ...reactions]);
-    }
-  } catch (err: unknown) {
-    if (err instanceof Error) {
-      throw new HttpException(500, `Failed to send slack notification: ${err.message}`);
-    }
+  if (threads && threads.length !== 0) {
+    const msgs = threads.map((thread) =>
+      replyToMessageInThread(thread.channelId, thread.timestamp, fullMsg, fullLink, btnText)
+    );
+    const reactions = threads.map((thread) =>
+      reactToMessage(thread.channelId, thread.timestamp, approved ? 'white_check_mark' : 'x')
+    );
+    await Promise.all([...msgs, ...reactions]);
   }
 };