#3888 fixed variable naming

Author: rbessin

src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx

@@ -62,8 +62,8 @@ interface ReimbursementRequestFormViewProps {
   allVendors: Vendor[];
   allAccountCodes: AccountCode[];
   receiptFiles: ReimbursementReceiptUploadArgs[];
-  allWbsElements: ProjectPreview[];
-  wbsElementAutocompleteOptions: {
+  allProjects: ProjectPreview[];
+  projectAutocompleteOptions: {
     label: string;
     id: string;
   }[];
@@ -91,8 +91,8 @@ interface ReimbursementRequestFormViewProps {
 const ReimbursementRequestFormView: React.FC<ReimbursementRequestFormViewProps> = ({
   allVendors,
   allAccountCodes,
-  allWbsElements,
-  wbsElementAutocompleteOptions,
+  allProjects,
+  projectAutocompleteOptions,
   receiptFiles,
   reimbursementProducts,
   control,
@@ -843,7 +843,7 @@ const ReimbursementRequestFormView: React.FC<ReimbursementRequestFormViewProps>
               reimbursementProducts={reimbursementProducts}
               appendProduct={reimbursementProductAppend}
               removeProduct={reimbursementProductRemove}
-              wbsElementAutocompleteOptions={wbsElementAutocompleteOptions}
+              projectAutocompleteOptions={projectAutocompleteOptions}
               watch={watch}
               register={register}
               setValue={setValue}
@@ -853,7 +853,7 @@ const ReimbursementRequestFormView: React.FC<ReimbursementRequestFormViewProps>
               secondRefundSourceIndexCode={secondRefundSourcePassed}
               firstRefundSourceName={firstRefundSource.name}
               secondRefundSourceName={secondRefundSource.name}
-              allWbsElements={allWbsElements}
+              allProjects={allProjects}
             />
             <FormHelperText error>{errors.reimbursementProducts?.message}</FormHelperText>
           </FormControl>

src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementProductTable.tsx

@@ -45,7 +45,7 @@ interface ReimbursementProductTableProps {
   reimbursementProducts: ReimbursementProductFormArgs[];
   removeProduct: (index: number) => void;
   appendProduct: (args: ReimbursementProductFormArgs) => void;
-  wbsElementAutocompleteOptions: {
+  projectAutocompleteOptions: {
     label: string;
     id: string;
   }[];
@@ -59,7 +59,7 @@ interface ReimbursementProductTableProps {
   secondRefundSourceIndexCode?: IndexCode;
   firstRefundSourceName?: string;
   secondRefundSourceName?: string;
-  allWbsElements: ProjectPreview[];
+  allProjects: ProjectPreview[];
 }
 
 const ListItem = styled('li')(({ theme }) => ({
@@ -70,7 +70,7 @@ const ReimbursementProductTable: React.FC<ReimbursementProductTableProps> = ({
   reimbursementProducts,
   removeProduct,
   appendProduct,
-  wbsElementAutocompleteOptions,
+  projectAutocompleteOptions,
   control,
   errors,
   setValue,
@@ -80,7 +80,7 @@ const ReimbursementProductTable: React.FC<ReimbursementProductTableProps> = ({
   firstRefundSourceName,
   secondRefundSourceName,
   watch,
-  allWbsElements
+  allProjects
 }) => {
   const uniqueWbsElementsWithProducts = new Map<
     string,
@@ -158,12 +158,11 @@ const ReimbursementProductTable: React.FC<ReimbursementProductTableProps> = ({
     }
   };
 
-  const handleOpenCreateMaterial = (productIndex: number, wbsNumber: WbsNumber) => {
-    const project = allWbsElements.find(
+  const handleOpenCreateMaterial = (productIndex: number, projectWbsNum: WbsNumber) => {
+    const project = allProjects.find(
       (proj) =>
-        proj.wbsNum.carNumber === wbsNumber.carNumber &&
-        proj.wbsNum.projectNumber === wbsNumber.projectNumber &&
-        proj.wbsNum.workPackageNumber === wbsNumber.workPackageNumber
+        proj.wbsNum.carNumber === projectWbsNum.carNumber &&
+        proj.wbsNum.projectNumber === projectWbsNum.projectNumber
     );
 
     if (project) {
@@ -333,7 +332,7 @@ const ReimbursementProductTable: React.FC<ReimbursementProductTableProps> = ({
                 >
                   <Autocomplete
                     sx={{ flex: 1 }}
-                    options={wbsElementAutocompleteOptions}
+                    options={projectAutocompleteOptions}
                     onChange={(_e, value) => {
                       if (value) {
                         appendProduct({
@@ -403,7 +402,7 @@ const ReimbursementProductTable: React.FC<ReimbursementProductTableProps> = ({
                       }}
                     >
                       {
-                        wbsElementAutocompleteOptions
+                        projectAutocompleteOptions
                           .concat(
                             (otherReasons || []).map((reason) => ({
                               id: reason.name,

src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementRequestForm.tsx

@@ -283,7 +283,7 @@ const ReimbursementRequestForm: React.FC<ReimbursementRequestFormProps> = ({
     }
   };
 
-  const wbsElementAutocompleteOptions = allProjects.map((proj) => ({
+  const projectAutocompleteOptions = allProjects.map((proj) => ({
     label: wbsPipe(proj.wbsNum) + ' - ' + proj.name,
     id: wbsPipe(proj.wbsNum)
   }));
@@ -355,8 +355,8 @@ const ReimbursementRequestForm: React.FC<ReimbursementRequestFormProps> = ({
       reimbursementProductRemove={reimbursementProductRemove}
       onSubmit={onSubmitWrapper}
       handleSubmit={handleSubmit}
-      allWbsElements={allProjects}
-      wbsElementAutocompleteOptions={wbsElementAutocompleteOptions}
+      allProjects={allProjects}
+      projectAutocompleteOptions={projectAutocompleteOptions}
       submitText={submitText}
       setValue={setValue}
       hasSecureSettingsSet={hasSecureSettingsSet}